From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id A8FE41B56C for ; Fri, 23 Nov 2018 16:42:17 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Nov 2018 07:42:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,270,1539673200"; d="scan'208";a="110594361" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga001.fm.intel.com with ESMTP; 23 Nov 2018 07:42:16 -0800 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 23 Nov 2018 07:42:16 -0800 Received: from hasmsx108.ger.corp.intel.com (10.184.198.18) by fmsmsx121.amr.corp.intel.com (10.18.125.36) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 23 Nov 2018 07:42:16 -0800 Received: from hasmsx112.ger.corp.intel.com ([169.254.11.97]) by hasmsx108.ger.corp.intel.com ([169.254.9.165]) with mapi id 14.03.0415.000; Fri, 23 Nov 2018 17:42:13 +0200 From: "Jozwiak, TomaszX" To: "Richardson, Bruce" , "Varghese, Vipin" CC: "dev@dpdk.org" , "Trahe, Fiona" , "Shally.Verma@cavium.com" , "akhil.goyal@nxp.com" Thread-Topic: [dpdk-dev] [PATCH v4 1/5] app/compress-perf: add parser Thread-Index: AQHUgzjCl3rDE6yvYUaeHlOggpptdaVdVXiAgAAD2gCAACWPUA== Date: Fri, 23 Nov 2018 15:42:12 +0000 Message-ID: References: <1542978409-28668-1-git-send-email-tomaszx.jozwiak@intel.com> <1542983269-30093-1-git-send-email-tomaszx.jozwiak@intel.com> <1542983269-30093-2-git-send-email-tomaszx.jozwiak@intel.com> <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2C1B41@BGSMSX101.gar.corp.intel.com> <20181123152438.GA14972@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20181123152438.GA14972@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.103.104.46] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 1/5] app/compress-perf: add parser X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Nov 2018 15:42:18 -0000 > -----Original Message----- > From: Richardson, Bruce > Sent: Friday, November 23, 2018 4:25 PM > To: Varghese, Vipin > Cc: Jozwiak, TomaszX ; dev@dpdk.org; Trahe, > Fiona ; Shally.Verma@cavium.com; > akhil.goyal@nxp.com > Subject: Re: [dpdk-dev] [PATCH v4 1/5] app/compress-perf: add parser >=20 > On Fri, Nov 23, 2018 at 03:10:51PM +0000, Varghese, Vipin wrote: > > > > > > > +#define MAX_DRIVER_NAME 64 > > > +#define MAX_INPUT_FILE_NAME 64 > > > > > > > > > +comp_perf_options_check(struct comp_test_data *test_data) { > > > + if (strcmp(test_data->driver_name, "") =3D=3D 0) { > > > > Should we use strncmp for boundary? > > > Shouldn't be necessary here, but a better check might be just to check if > test_data->driver_name[0] =3D=3D '\0'. No need to use a string function f= or > checking for an empty string. >=20 > /Bruce True Bruce :D , thx, will update these lines.