From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lukego@gmail.com>
Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com [74.125.82.52])
 by dpdk.org (Postfix) with ESMTP id 2DBF33239
 for <dev@dpdk.org>; Thu, 23 Apr 2015 15:57:04 +0200 (CEST)
Received: by wgso17 with SMTP id o17so19314681wgs.1
 for <dev@dpdk.org>; Thu, 23 Apr 2015 06:57:04 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date:message-id:subject
 :from:to:cc:content-type;
 bh=hqql8neu+O44Cs6HRmbR2C7Rk0hiYASRp9Lq25qxZAM=;
 b=v0a/y8oPQ/Qq1r7PkotnbK2Xm1lwghHa44LxJH6GrJFqPqOLo74ONfzC1idLl3wZYn
 5zzlDUIve+dn1C5Um3C88UeygF/XvwIolPa2VyIS93SJf45mk4s024EE8/AhOF4UwDdp
 EgLRnUc2lYjbvK/gK16g6hzDVmIPWhKygemB1x1hqOSxtp8ZHxf6eiOt3uhIY6h4XkZR
 rT2hfBeZMXSELJqtysx9MvOeDBItRStcUWJAymGKUji4J87WyOqVjsrRt5ayhCEKB8VS
 +ZAsU1i87GXwh5BpAE0WQmRsGx7vdXuTwa7Mtv9HEyGMeWHm3nwHitccRxRfJ7tR9ypU
 XLHw==
MIME-Version: 1.0
X-Received: by 10.180.19.100 with SMTP id d4mr6098215wie.29.1429797424061;
 Thu, 23 Apr 2015 06:57:04 -0700 (PDT)
Sender: lukego@gmail.com
Received: by 10.27.134.198 with HTTP; Thu, 23 Apr 2015 06:57:04 -0700 (PDT)
In-Reply-To: <1429720392-25345-1-git-send-email-huawei.xie@intel.com>
References: <1429720392-25345-1-git-send-email-huawei.xie@intel.com>
Date: Thu, 23 Apr 2015 15:57:04 +0200
X-Google-Sender-Auth: qtSaqbNHSC1gZdz77g1N4eir4a0
Message-ID: <CAA2XHbd+jD5Os-Uji6ykwDKcjGuV8jH-GJ-=rEwaku-+OSpWsw@mail.gmail.com>
From: Luke Gorrie <luke@snabb.co>
To: Huawei Xie <huawei.xie@intel.com>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [dpdk-dev] [PATCH] vhost: flush used->idx update before reading
	avail->flags
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Apr 2015 13:57:04 -0000

On 22 April 2015 at 18:33, Huawei Xie <huawei.xie@intel.com> wrote:

> update of used->idx and read of avail->flags could be reordered.
> memory fence should be used to ensure the order, otherwise guest could see
> a stale used->idx value after it toggles the interrupt suppression flag.
>

This patch looks right to me.