From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2B4E144120; Fri, 31 May 2024 23:06:43 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EA61040C35; Fri, 31 May 2024 23:06:42 +0200 (CEST) Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by mails.dpdk.org (Postfix) with ESMTP id C5ED1402D0 for ; Fri, 31 May 2024 23:06:41 +0200 (CEST) Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-2c1a4192d55so1837517a91.2 for ; Fri, 31 May 2024 14:06:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1717189601; x=1717794401; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=dbk0rfw9Fv93WiQTj5cEK+Nsbl8Dmfc40YkC29+nzLY=; b=B9Ri44PjhvjZqxtRRwAo97Np2HRB0O6rkitV9/oii8gb9/sIL+49rhvS111Zrig3LN bppgELYLVcrhI5akq1cMt3uCOVkLYdDKqsd4NfRCvdI8N1x1wwSSbkkfMlyHXstfzgwu 6aRT6pOwW7ZIHWOAGbXUAv0OlQU7exKVtxMP8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717189601; x=1717794401; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dbk0rfw9Fv93WiQTj5cEK+Nsbl8Dmfc40YkC29+nzLY=; b=k20yeTkPx20fSXIYZulRM51qWswDQwn77coRRDJOe2n4OQhNs1slcs56G3xPE2myG5 oCNS4FheXzAMgk8+2+fTaDAtCZxyvIeEk8EI9+Lepq8yl1Quem5ErGIN4L4FCwym2RxA GxqZweKWhvwCEeUlvWuKQ1i+B9Na/oHqP/zMZ7ihe2LOupm8abGduOhwxKintRu5J4bc 330xsMjLp5/LDX0cFqK3xrze+RlOnEh7z4bak/GUinEITHfL0hUqta9cc+8N9Vaip5bw /wb9zVhPNdzCf3x6nJ5lFyaOmVvZbKFdVONYHuAp/tMuAFQXvm60rM8MpkeIWcILvhgE /4DA== X-Gm-Message-State: AOJu0Yx7g/pksvddtexfR/is9v/+yVu52c+YucLNiHabLNcTlVQTAjcO bPjjNR5c77S4KuSh2iKfXeyvDWzHO9MUn3DVukTXTdOcYvUiN2ByuHtjTSiYdiu9tL6ZNV8wh+h hl0XO+a3ga/0j5TqFSaWdLN1tpbkSyFTRgvGngg== X-Google-Smtp-Source: AGHT+IGNDCW0DdHfuj3QK96FEd6Cpvl+1T6m4ve3+K7gG0eRyvEtS0rIlMmQLGZzaQNaYAqqXvWlcxuRcFNSpVcT53Q= X-Received: by 2002:a17:90a:f015:b0:2b4:329e:a0ca with SMTP id 98e67ed59e1d1-2c1dc58fa09mr2952405a91.26.1717189600734; Fri, 31 May 2024 14:06:40 -0700 (PDT) MIME-Version: 1.0 References: <20240412111136.3470304-1-luca.vizzarro@arm.com> <20240509112635.1170557-1-luca.vizzarro@arm.com> <20240509112635.1170557-2-luca.vizzarro@arm.com> In-Reply-To: <20240509112635.1170557-2-luca.vizzarro@arm.com> From: Jeremy Spewock Date: Fri, 31 May 2024 17:06:29 -0400 Message-ID: Subject: Re: [PATCH v2 1/5] dts: fix InteractiveShell command prompt filtering To: Luca Vizzarro Cc: dev@dpdk.org, =?UTF-8?Q?Juraj_Linke=C5=A1?= , Paul Szczepanek Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, May 9, 2024 at 7:26=E2=80=AFAM Luca Vizzarro wrote: > > When sending a command using an instance of InteractiveShell the output > should filter out the trailing shell prompt when returning it. After > every command two shell prompts are summoned. One is consumed as it is > used as a delimiter for the command output. The second one is not > consumed and left for the next command to be sent. > > Given that the consumed prompt is merely a delimiter, this should not be > added to the returned output, as it may be mistakenly be interpreted as > the command's own output. > > Bugzilla ID: 1411 > Fixes: 88489c0501af ("dts: add smoke tests") > > Signed-off-by: Luca Vizzarro > Reviewed-by: Paul Szczepanek > --- > dts/framework/remote_session/interactive_shell.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Jeremy Spewock