From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1D78A454BF; Fri, 21 Jun 2024 23:27:40 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EBF4D4027D; Fri, 21 Jun 2024 23:27:39 +0200 (CEST) Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by mails.dpdk.org (Postfix) with ESMTP id 596D440041 for ; Fri, 21 Jun 2024 23:27:38 +0200 (CEST) Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-2c7dbdc83bfso2001815a91.1 for ; Fri, 21 Jun 2024 14:27:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1719005257; x=1719610057; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=FWT+ecOBiDnV1fAp2FzzGEsyAd57uE2JOlMD4YMYRxs=; b=TP34Sbj2i+MtMnCNGeV9ujJi9byHXRotU0EpU/aoA8R4yzS0x84N/xsQ7GOvBE2GCN Qz4qiMRZXMHGIo7LjR3ADnj6yJu9+sxKFUGEPSUvi4egLvlK3k4U3GinT9KWRbkzeeik wVMQ4f/TJOeUJOQ+gFtUn6Pvo9H+lgRKnk0mA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719005257; x=1719610057; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FWT+ecOBiDnV1fAp2FzzGEsyAd57uE2JOlMD4YMYRxs=; b=SE+WwK+XJ9KPyg4jbtyQEbHlRS/BnSdXLJQPUujRKplk8VAAbk8EVDUdFbozvHfp/T IxZJi2W0RRWVtf5z3ZN0X7slqLjnvw3mLLj0D/o3AIzLgffbsAMA5M9TKy09I53HuDDw fwyAiOBBbErBnyl2p3ZxZ2cabpFUSWgBbYP3pmjDciMoxXlx3hIrBxkXRJbAC9qdOdrQ tSc7sq9A6yNqrFxQPJD73zLSEs60i4QNgHMwqqB2Aryd2ecTUBT1g3BhmRegf9klngX+ 1Z+X5fTfivPkTsrwkLtZwNAPbJ+OdUZGdhpca/Dp60dFZ3dwyLKEkst18lnd6pxEjRoC z8Jw== X-Forwarded-Encrypted: i=1; AJvYcCUbawOnIEKBqPc7S/SoMxUpd9Cocjske7ndfTkH1LSm3DgNi8OWR2SmS/q1BOZ45VndUNCb7m4nf9/+ANA= X-Gm-Message-State: AOJu0Yw7ggUuK7pu20K9IeB91Qshy5JmSGeisWMW7hTvxxxWXWGe6SJ+ 6ejd9ZXrYp11jB6aUWPFQ3u/2460BaghcNrC1b/5DxsgSLZKJ/8T4T0gooh+r1I0fQqGCX+qDQK WJyLdRhnBXK9d3r35KfUaLIUib1CgYK5TzzmlIw== X-Google-Smtp-Source: AGHT+IGH87NVKH6gw+ldAKLPp7qYLy5l0whFxgRPdzbyHrTMEvWj79GXRILdEf5ivrp4GnRh9N/uQIgkIxL75u/gCWA= X-Received: by 2002:a17:90a:f2c2:b0:2c7:cc35:2819 with SMTP id 98e67ed59e1d1-2c7cc354740mr7290920a91.3.1719005257352; Fri, 21 Jun 2024 14:27:37 -0700 (PDT) MIME-Version: 1.0 References: <20240617194638.12926-2-dmarx@iol.unh.edu> In-Reply-To: <20240617194638.12926-2-dmarx@iol.unh.edu> From: Jeremy Spewock Date: Fri, 21 Jun 2024 17:27:26 -0400 Message-ID: Subject: Re: [PATCH v2 0/3] dts: queue start/stop suite To: Dean Marx Cc: Honnappa.Nagarahalli@arm.com, juraj.linkes@pantheon.tech, probb@iol.unh.edu, paul.szczepanek@arm.com, yoan.picchi@foss.arm.com, bruce.richardson@intel.com, luca.vizzarro@arm.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hey Dean, One thing I think might make sense in this series is switching the order of the commits so that the additions to the testpmd shell come before the test suite. Since the test suite relies on these methods, if they aren't implemented anywhere that commit would actually be broken until the testpmd shell commit is applied. Putting the testpmd shell patch first shows that the test suite should actually be added after the methods are added to testpmd. On Mon, Jun 17, 2024 at 3:47=E2=80=AFPM Dean Marx wrote= : > > Queue start/stop suite ensures the Poll Mode Driver can functionally > enable and disable Rx/Tx queues on ports. The suite contains two test > cases: > > 1. All queues enabled - verifies that packets are received when all > queues on all ports are enabled. > 2. Queue start/stop - verifies that packets are not received when the Rx > queue on port 0 is disabled, and then again when the Tx queue on port 1 > is disabled. > > An important aspect of DPDK is queueing packets for transmission to > bypass the kernel, which makes this test suite necessary to ensure > performance. > > Dean Marx (3): > dts: initial queue start/stop suite implementation > dts: added promisc/verbose func to testpmd shell > dts: queue suite conf schema > > dts/framework/config/conf_yaml_schema.json | 3 +- > dts/framework/remote_session/testpmd_shell.py | 179 +++++++++++++++++- > dts/tests/TestSuite_queue_start_stop.py | 79 ++++++++ > 3 files changed, 259 insertions(+), 2 deletions(-) > create mode 100644 dts/tests/TestSuite_queue_start_stop.py > > -- > 2.44.0 >