From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4889F44104; Wed, 29 May 2024 22:38:25 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3A55D40691; Wed, 29 May 2024 22:38:25 +0200 (CEST) Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by mails.dpdk.org (Postfix) with ESMTP id E37E840649 for ; Wed, 29 May 2024 22:38:23 +0200 (CEST) Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-2c195eb9af3so123609a91.0 for ; Wed, 29 May 2024 13:38:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1717015103; x=1717619903; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=0DnvjTgHaIzlNchoIfBMOTJ+ciUGJtT9o1W69YQMHAU=; b=CIfbKIppBUbAVK2aI2M7EK1gapQW1P2picBvlB8rOmH4YkFp7OByjdp0xM/hqZRJ5o 5mRVNprA0yi540K+4fIxdt/4UMrsXxeHgUhO3mDoB/yUXHdBrHXZR6DbkuRp8xk+G52c liYdSLREWYkk4EQLQP4krQz3YgFGF+1G4Ziu8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717015103; x=1717619903; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0DnvjTgHaIzlNchoIfBMOTJ+ciUGJtT9o1W69YQMHAU=; b=aWvmwzzZdDss5n9CCvy1xA4y7TlI2vxFHVjhHMZKRCk8kqGI8KW0wY/aFnK11yU8QF JWwgy7wqRXRq0VvdllF5ka4OIZwQSY7Gg7w8Yb46ANdbjc/aQeH3w9qAkRqN0dC6aoOL 6cug4BF1LTDlvxLnGk+w6eRNgiSE87cLVVIXQYT1LP9/aaYfIQfDwhQRreJHFeDdjFjv qAW3O0jlhin/q/+Czzb9NcBtLFG0w1p4MevYC9QpZtcz8Er28cOzgqvS5oTP4BvEExma YeYcTo8qoooFjPyVkd+sqXScq95MgcHcT8f1poNCDq+ZZURj5wxxu+iIJtaiodRpGNp1 bnVg== X-Forwarded-Encrypted: i=1; AJvYcCULvBgCJRa9SqVNylP08dgBCKLQaSFUUJvQe2I/2RXCUgCkvye5KZp+0F9mlOGRdhUmx+eH/dDXEk5j1Wk= X-Gm-Message-State: AOJu0YxttlXzCK2XTdZgBv/GKg2U+gmNiX4Q29+begl3SftVAkEBzDV5 ItEQHdrP420e48h32Fc11W2yocRymNSGNSa5e9CBUGjXejqZ28wd1i4M4T7p/8Nl23ZL6GFoTVc 0jNngSPMS6gmW0cXQHHxLFFzZPLXTAEmW6ZyVu9Mv2nLAxlRg X-Google-Smtp-Source: AGHT+IGYiMjSIegGGK/BSuh4CXpHXY1qlSdAlGXFuQEr5azaUy4FjH1CmjWErDXRZn5mEKOvGdcm/pu7FExSM99yfec= X-Received: by 2002:a17:90a:4803:b0:2c0:13de:e641 with SMTP id 98e67ed59e1d1-2c1ab9e23eamr250177a91.14.1717015103123; Wed, 29 May 2024 13:38:23 -0700 (PDT) MIME-Version: 1.0 References: <20240514201436.2496-1-jspewock@iol.unh.edu> <20240514201436.2496-4-jspewock@iol.unh.edu> <5121cc48-3be6-45fa-9c0b-bd745cfee589@arm.com> In-Reply-To: <5121cc48-3be6-45fa-9c0b-bd745cfee589@arm.com> From: Jeremy Spewock Date: Wed, 29 May 2024 16:38:12 -0400 Message-ID: Subject: Re: [PATCH v1 3/4] dts: add methods for modifying MTU to testpmd shell To: Luca Vizzarro Cc: yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com, juraj.linkes@pantheon.tech, probb@iol.unh.edu, wathsala.vithanage@arm.com, thomas@monjalon.net, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, May 20, 2024 at 1:35=E2=80=AFPM Luca Vizzarro wrote: > > On 14/05/2024 21:14, jspewock@iol.unh.edu wrote: > > diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framew= ork/remote_session/testpmd_shell.py > > index 33b3e7c5a3..4e608998f9 100644 > > --- a/dts/framework/remote_session/testpmd_shell.py > > +++ b/dts/framework/remote_session/testpmd_shell.py > > @@ -227,6 +227,74 @@ def set_forward_mode(self, mode: TestPmdForwarding= Modes, verify: bool =3D True): > > f"Test pmd failed to set fwd mode to {mode.value}" > > ) > > > > + def _stop_port(self, port_id: int, verify: bool =3D True) -> None: > > + """Stop port `port_id` in testpmd. > > + > > + Depending on the PMD, the port may need to be stopped before c= onfiguration can take place. > > + This method wraps the command needed to properly stop ports an= d take their link down. > > + > > + Args: > > + port_id: ID of the port to take down. > > + verify: If :data:`True` the output will be scanned in an a= ttempt to verify that the > > + stopping of ports was successful. Defaults to True. > > + > > + Raises: > > + InteractiveCommandExecutionError: If `verify` is :data:'Tr= ue` and the port did not > just a nit: apostrophe used instead of backtick 'True` Good catch, I think this does matter for doc generation, so definitely good to fix. > >