From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9153645460; Fri, 14 Jun 2024 20:10:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7F9E4427B2; Fri, 14 Jun 2024 20:10:11 +0200 (CEST) Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by mails.dpdk.org (Postfix) with ESMTP id 15207427B0 for ; Fri, 14 Jun 2024 20:10:11 +0200 (CEST) Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-2c19e6dc3dcso2133255a91.3 for ; Fri, 14 Jun 2024 11:10:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1718388610; x=1718993410; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=kGQp/oJ+CJ+I4KEI1HE8E41Di2ZWhOqC4O2z3Uk/ZWU=; b=foe1rbcoepOO2FK2iQn3ecKSzcqdb6sk/VEYie98F5pVykA7nqTUBjlNvHrEXijsDZ xphlaPH2F0xlO5BB9HuklAuFyO4BzMjBCciK2z7/Dy5qntlnvBug1/VuG/0TFGvj3Wpi gWD7BH3EMpIIXjmBkMQi/ljDhFVZ4r7e8fpbI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718388610; x=1718993410; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kGQp/oJ+CJ+I4KEI1HE8E41Di2ZWhOqC4O2z3Uk/ZWU=; b=vrkmsos9fxn+QWITf8+Ao1sxeLUM6e+lxodH63DOwihEIm2/uyyPxzjwrzAaPPLs7i mCLnrSeJtj4HNzH7fhCOL8i+X4fThXA1htfbKvMJpWYnH63pBC/N3Jg2O1Ad6oVxfGaP AP7coBnzXHQuOgI8s4WLryYAq2SaflhQRxAqAC5lOLa38Wft0d/efAOqsCJ92tRZIcza pxvAaeMIcXCqfxqNoWVVm3Dx1Qy18irzyoB6Pk4rpgLYVNcM2kOcMVxNwa9vF2p14PZY /G0swuAtgUDKb7Gbaa9Mxhdokm+dURtHlUmKWO0AvekRvVO7QryJVHHTocwRptTZHAhC 4szQ== X-Forwarded-Encrypted: i=1; AJvYcCWKnzze9YeUcrZyF9OIi0zuVdRvmJv3UxdDVoj+JI2Y+rFjymvK7Uhx4InlFmZFdnEfXqS0Q2KUUWD004M= X-Gm-Message-State: AOJu0YwI6QhxAknWRZL+X8RmNp1NT1CrO1DDTKXlMpsz7RTTiW57kjy2 Y/pfYrOevi5zd41GE7nMtIPr3ui8qe+WeXeeEI5ehxW+dUcfXUYIUS4/s1XCXdshFZVfKSNNNil kVz6rEid0loo6katYubXkgKhKbAcm4GJkvg4IOw== X-Google-Smtp-Source: AGHT+IExJpBMoQuYr7aYp+801BaqvKwFSss7NEyWsD3TtvIyei+ra9OBW9QJXvZT/TI3jMC5HYlUTJbtTf4d8qT42XY= X-Received: by 2002:a17:90a:43a1:b0:2bf:de8b:bef5 with SMTP id 98e67ed59e1d1-2c4db24e934mr3400327a91.12.1718388610311; Fri, 14 Jun 2024 11:10:10 -0700 (PDT) MIME-Version: 1.0 References: <20240613201831.9748-3-npratte@iol.unh.edu> <20240613201831.9748-9-npratte@iol.unh.edu> In-Reply-To: <20240613201831.9748-9-npratte@iol.unh.edu> From: Jeremy Spewock Date: Fri, 14 Jun 2024 14:09:59 -0400 Message-ID: Subject: Re: [PATCH 3/4] dts: Self-Discovering Architecture Change To: Nicholas Pratte Cc: Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com, luca.vizzarro@arm.com, juraj.linkes@pantheon.tech, bruce.richardson@intel.com, probb@iol.unh.edu, dmarx@iol.unh.edu, yoan.picchi@foss.arm.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Looks good to me, just looks like a testing command got left behind. Otherwise though: Reviewed-by: Jeremy Spewock On Thu, Jun 13, 2024 at 4:22=E2=80=AFPM Nicholas Pratte wrote: > > The 'arch' attribute in the conf.yaml is unnecessary, as this can be > readily discovered within the constructor of any given node. Since OS is > determined within user configuration, finding system arch can be done > both reliably and easily within the framework. > > For Linux/Posix systems, the 'uname' command is used to determine system > architecture. I believe that this is posix-standard and utilizes a > standardized output. > > Bugzilla ID: 1360 > Signed-off-by: Nicholas Pratte > > --- > diff --git a/dts/framework/testbed_model/posix_session.py b/dts/framework= /testbed_model/posix_session.py > index d279bb8b53..91afca61ea 100644 > --- a/dts/framework/testbed_model/posix_session.py > +++ b/dts/framework/testbed_model/posix_session.py > @@ -295,3 +295,9 @@ def get_node_info(self) -> NodeInfo: > ).stdout.split("\n") > kernel_version =3D self.send_command("uname -r", SETTINGS.timeou= t).stdout > return NodeInfo(os_release_info[0].strip(), os_release_info[1].s= trip(), kernel_version) > + > + def get_arch_info(self) -> str: > + """Overrides :meth'~.os_session.OSSession.get_arch_info'.""" > + # return str(self.send_command('arch')).stdout Right here is the testing I was referencing. > + > + return str(self.send_command("uname -m").stdout.removesuffix("\n= ")) > -- > 2.44.0 >