From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 763C444177; Thu, 6 Jun 2024 20:52:40 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0465240EAB; Thu, 6 Jun 2024 20:52:40 +0200 (CEST) Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) by mails.dpdk.org (Postfix) with ESMTP id A5E2340E96 for ; Thu, 6 Jun 2024 20:52:38 +0200 (CEST) Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-6bce380eb96so904294a12.0 for ; Thu, 06 Jun 2024 11:52:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1717699957; x=1718304757; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=kHKOqECuX99278LGZthIShBxHlh2j5AcgKUNXSwoR/w=; b=GagT7G4LlMIDnwXDZmVQQBGHSiVaFrh/ryEYwzF5AY9PB1ARTEvOdBHtJNPnNpYaTO f2rIPiq0pJFgT2RP5x6UrsNjQN7B/I5aEFqO8Y4VT8GLG1YGngysi93ko4V0ZdF93qIs vp+BnHr1zt1VmrSpIPo1k7yQqSIrSzWHUaR+E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717699957; x=1718304757; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kHKOqECuX99278LGZthIShBxHlh2j5AcgKUNXSwoR/w=; b=l4zndmdTjlkKr7YlMoqZFwbpT3r5azU3sDJwbTbjTZUadR1XL2+TvV3Xealh8uoyIV s639YJyDDfgiprQrleIToflfx6jgfH0eak+/pQ5ZYjFawlnU9DBReyINjQrGFGtZ8XZw RPpLxPKrhX0UpHWhulRhKzbgcIOCt9VCzOwM1qmwGbO2+TGlTSBQuPoHyA5B5SeK/3i/ m1Acyoy35P47PxDZZRVsPjfLXkO910SHodP1kY3S73hI4+o4gYyjP9zWENgAxtVGFL3O NkNe+LWW60xWP3tfWm7JDJPeGklFfgiNuECQi1vvB1+gObTju1QEZKiS/nDMrhQMLC9y zYmg== X-Gm-Message-State: AOJu0YzqhZQ/ozQPl6WvRfQp8l15lr05cOlZl6OELVB0H7Har1rgO9wZ Mdfls7nOMg7v8eYzQQephvRaP07FAe4LMRD30cKX9CEAhz0WFSpmkVKV+M2uiHCv39Qw0ikMBBU hC4MPFwGa+8phSaPuZnycEgGmW6IAOvF2OewC6g== X-Google-Smtp-Source: AGHT+IEmCI7YaM4817edOqMuiLmnDMEbcCCWT4JPT+OT1S6e70DT45Fr4KUB4w/cWRTVl3ASVVoP3CNKifl74Mn14GQ= X-Received: by 2002:a17:90b:19d8:b0:2b2:7e94:c5e0 with SMTP id 98e67ed59e1d1-2c2bcb007c1mr414720a91.20.1717699957496; Thu, 06 Jun 2024 11:52:37 -0700 (PDT) MIME-Version: 1.0 References: <20240412111136.3470304-1-luca.vizzarro@arm.com> <20240606091718.151516-1-luca.vizzarro@arm.com> <20240606091718.151516-2-luca.vizzarro@arm.com> In-Reply-To: <20240606091718.151516-2-luca.vizzarro@arm.com> From: Jeremy Spewock Date: Thu, 6 Jun 2024 14:52:26 -0400 Message-ID: Subject: Re: [PATCH v4 1/5] dts: fix InteractiveShell command prompt filtering To: Luca Vizzarro Cc: dev@dpdk.org, =?UTF-8?Q?Juraj_Linke=C5=A1?= , Paul Szczepanek Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jun 6, 2024 at 5:17=E2=80=AFAM Luca Vizzarro wrote: > > When sending a command using an instance of InteractiveShell the output > should filter out the trailing shell prompt when returning it. After > every command two shell prompts are summoned. One is consumed as it is > used as a delimiter for the command output. The second one is not > consumed and left for the next command to be sent. > > Given that the consumed prompt is merely a delimiter, this should not be > added to the returned output, as it may be mistakenly be interpreted as > the command's own output. > > Bugzilla ID: 1411 > Fixes: 88489c0501af ("dts: add smoke tests") > > Signed-off-by: Luca Vizzarro > Reviewed-by: Paul Szczepanek Reviewed-by: Jeremy Spewock