From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5D97E43D6D; Thu, 28 Mar 2024 17:49:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4C8C7427DB; Thu, 28 Mar 2024 17:49:01 +0100 (CET) Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by mails.dpdk.org (Postfix) with ESMTP id B9C46427D8 for ; Thu, 28 Mar 2024 17:48:59 +0100 (CET) Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-5bdbe2de25fso815465a12.3 for ; Thu, 28 Mar 2024 09:48:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1711644539; x=1712249339; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Os3ZAy3kdS6+I8Tiyzb05ZMBdKlXRT0hw2m/BLb7Cxc=; b=hOEZvcQU5DTEzJtqikhCOrn0qDav5aiCJCunCGb8b3XJblRr1ElApgf0r7LdUvZFyc msix6oMOJR+EpLwlFPrxXnNb8/FGqDXQ8nrWBnct/EpGfEBb5Ec28RyL5Roe2b563sZh 84GQ67e2/JIlxY8yNWczlBAD4MpRihidKOeyI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711644539; x=1712249339; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Os3ZAy3kdS6+I8Tiyzb05ZMBdKlXRT0hw2m/BLb7Cxc=; b=tn08oKt01XEo8eqPgxCrJRGDugCp/5pNuLBqCZHetAQg4smB0nRgRq+7JuOChyxOiC OevD0x08tCU2+a+QL0ytoWtcFcbBdIGEXNAKna+K1QzZMmmGGxTYubmmRE+kOx/rJscW byLXh+m2u7QRaizkcpQi6L3JbteWNqDruPkMnlCy9tgjL3uAc8MrjyzMrvjOTaK/u33z ib1fOOFhJ/SQK5vawC6LNEhA31E1n2kVhvPHZpWdI3IWIiKh/gGKrHILA98HhwCbW8zw 3Iu5kv4ZE2ozFLwVTx1pRHLhbdXGEnXTcEuexCpASu/WsaLMbuhW2SAq6OO2nUWlaV0r IfJA== X-Gm-Message-State: AOJu0Yx/JPN7w3AnQH2ki61aIbnWRw31rsPmwL3UUnUIkWUqEjxcSQX4 ss7XMC/Ucw81ik+VsbPslxNNUIhGIEGg6lHNmEyokhdfa6eW4kCi4rQm55s/7t/ES81adUqceS+ XMnEkud+y5mqrwbLSZiLcD+TYnq/jLloU6CMP6Q== X-Google-Smtp-Source: AGHT+IGjH8WaJc/EKeyBPF6ECexPYv/SPYTEMHLhyq9LpajL11rYasCMO0P4bD+FIMmD+vAl3xL8suWpNMd92RgD8ZQ= X-Received: by 2002:a17:90b:1085:b0:2a1:fcf1:59de with SMTP id gj5-20020a17090b108500b002a1fcf159demr3408422pjb.26.1711644539002; Thu, 28 Mar 2024 09:48:59 -0700 (PDT) MIME-Version: 1.0 References: <20240326190422.577028-1-luca.vizzarro@arm.com> <20240326190422.577028-6-luca.vizzarro@arm.com> In-Reply-To: <20240326190422.577028-6-luca.vizzarro@arm.com> From: Jeremy Spewock Date: Thu, 28 Mar 2024 12:48:48 -0400 Message-ID: Subject: Re: [PATCH 5/6] dts: add statefulness to InteractiveShell To: Luca Vizzarro Cc: dev@dpdk.org, =?UTF-8?Q?Juraj_Linke=C5=A1?= , Jack Bond-Preston , Honnappa Nagarahalli Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Mar 26, 2024 at 3:04=E2=80=AFPM Luca Vizzarro wrote: > diff --git a/dts/framework/remote_session/interactive_shell.py b/dts/fram= ework/remote_session/interactive_shell.py > index a2c7b30d9f..5d80061e8d 100644 > --- a/dts/framework/remote_session/interactive_shell.py > +++ b/dts/framework/remote_session/interactive_shell.py > @@ -41,8 +41,10 @@ class InteractiveShell(ABC): > _stdout: channel.ChannelFile > _ssh_channel: Channel > _logger: DTSLogger > + __default_timeout: float Only single underscores are used for other private variables, probably better to keep that consistent with this one. > _timeout: float > _app_args: Params | None > + _is_privileged: bool =3D False > 2.34.1 >