Re: [PATCH 1/4] dts: Remove build target config and list of devices

[Jeremy Spewock <jspewock@iol.unh.edu>]

On Thu, Jun 13, 2024 at 4:21 PM Nicholas Pratte <npratte@iol.unh.edu> wrote:
>
> Remove the list of devices from the schema, as these are unuesed.
> Likewise, removed build-target information since these is not currently
> used, and it is unlikely to be used in the future. Adjustments to the
> dts.rst are made to reflect these changes.
>
> Bugzilla ID: 1360
> Signed-off-by: Nicholas Pratte <npratte@iol.unh.edu>
>
> ---
>  doc/guides/tools/dts.rst                   | 11 ---
>  dts/conf.yaml                              |  5 +-
>  dts/framework/config/__init__.py           | 30 +-------
>  dts/framework/config/conf_yaml_schema.json | 79 ----------------------
>  dts/framework/config/types.py              |  6 --
>  dts/framework/runner.py                    |  2 +-
>  dts/framework/test_result.py               | 14 +---
>  dts/framework/testbed_model/sut_node.py    |  8 +--
>  8 files changed, 5 insertions(+), 150 deletions(-)
>
<snip>
>  @unique
>  class Compiler(StrEnum):
>      r"""The supported compilers of :class:`~framework.testbed_model.node.Node`\s."""
> @@ -340,28 +324,20 @@ class BuildTargetConfiguration:
>      The configuration used for building DPDK.
>
>      Attributes:
> -        arch: The target architecture to build for.
> -        os: The target os to build for.
> -        cpu: The target CPU to build for.
>          compiler: The compiler executable to use.
>          compiler_wrapper: This string will be put in front of the compiler when
>              executing the build. Useful for adding wrapper commands, such as ``ccache``.
>          name: The name of the compiler.

This attribute got removed from the class, we should take it out of
the docstring too.

>      """
>
> -    arch: Architecture
> -    os: OS
> -    cpu: CPUType
>      compiler: Compiler
>      compiler_wrapper: str
> -    name: str
>
>      @staticmethod
>      def from_dict(d: BuildTargetConfigDict) -> "BuildTargetConfiguration":
<snip>
> diff --git a/dts/framework/testbed_model/sut_node.py b/dts/framework/testbed_model/sut_node.py
> index 97aa26d419..34213f6884 100644
> --- a/dts/framework/testbed_model/sut_node.py
> +++ b/dts/framework/testbed_model/sut_node.py
<snip>
> @@ -253,7 +248,6 @@ def _configure_build_target(self, build_target_config: BuildTargetConfiguration)
>          """Populate common environment variables and set build target config."""
>          self._env_vars = {}
>          self._build_target_config = build_target_config
> -        self._env_vars.update(self.main_session.get_dpdk_build_env_vars(build_target_config.arch))

I'm not sure what the implications of removing this method call are,
it seems like it adds some value to the DPDK build process by adding a
CFLAG and a path to the pkgconfig directory. Maybe we don't need this,
but there might be a reason it was there originally as well.



>          self._env_vars["CC"] = build_target_config.compiler.name
>          if build_target_config.compiler_wrapper:
>              self._env_vars["CC"] = (
> --
> 2.44.0
>