From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 98B4145460; Fri, 14 Jun 2024 20:08:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7597240B9A; Fri, 14 Jun 2024 20:08:01 +0200 (CEST) Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) by mails.dpdk.org (Postfix) with ESMTP id 3CE6140B95 for ; Fri, 14 Jun 2024 20:08:00 +0200 (CEST) Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-681953ad4f2so1989126a12.2 for ; Fri, 14 Jun 2024 11:08:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1718388479; x=1718993279; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=zdnwLlTeDyGlVNNT4ZbtxSp4TUdm168L9z3rQnk7By4=; b=E8bJbD+MUu9qugrz8cWZg2A7aoRXQZ40Yurnge7lUAzDg+EK9Pjhd5OlOxNAOhh4jH V2myqh1FYuWeiu67NlKJFTDnlOyeaFdBp9jTjjvqBicUV0aOY5ps3CtMzKwSjy2YAUyI PCvUXbGZC0yscsPDmr23tvodTLi/OpcgIrkDA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718388479; x=1718993279; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zdnwLlTeDyGlVNNT4ZbtxSp4TUdm168L9z3rQnk7By4=; b=fKMYnvDxWrkKo0guxewiWRrnx8tZTTiakjpFMh8IXqyKG2fg+YRQA8Qyu6B2kSRj4p azrPJHKYiqXeAqqn4lIp/lTEIY1YzOpelOZasujPMlPSyvgYvN3/D96fCEjgo6ypVWkE nv+V4/68FkRzajHCtgnCbO/e+oEkAXKSyY2IFLSQTZGwVORjAuweRqML6y9MH4zujZ6q 8EH9Oyj9rK499IuNSV+XH3GHe1TNTQbLoAPQTGPlz/7rSeQPgMOckL6jcXzCA830mxHW JG7mTmHa9Ta9p9WtYF9OcktuE90TiOKUuaQgWdbAQiavUMZLOGKc+fVHpfWcQ0u8jOnU rypA== X-Forwarded-Encrypted: i=1; AJvYcCXPpgJHu+2ZEepVN9qRq6U/UvVak3Wp8RXzIPFclGkFDU+XiiW6Lrks8Oy9uWQ1oDMOwE3jsLPd7N0xLkU= X-Gm-Message-State: AOJu0Yw5OyobvMQPDWbLuezXP8RzoAML3HIxWKrdtw5KVYRfDb6r7pBs VXhxLjqSbnRLxnTbTO8qM9bIPIQLDlkX/jhcB0ACKabLPT+GbM+jajD6Qz5+edzwP3xieMc14hg gICift7Nr7hnRjE8NSevfmXv0VSm0qL0Xu3xh4w== X-Google-Smtp-Source: AGHT+IECFMGJZDjEaotQJL5zuoISkKZd5msKlR/NQTXuiKCYjmirSRfRXL76R28fD8fsFq36lywXN8pTkiuqHin0fvA= X-Received: by 2002:a17:90a:6547:b0:2c2:cfd1:768b with SMTP id 98e67ed59e1d1-2c4db24bc7amr3388119a91.12.1718388479232; Fri, 14 Jun 2024 11:07:59 -0700 (PDT) MIME-Version: 1.0 References: <20240613201831.9748-3-npratte@iol.unh.edu> <20240613201831.9748-5-npratte@iol.unh.edu> In-Reply-To: <20240613201831.9748-5-npratte@iol.unh.edu> From: Jeremy Spewock Date: Fri, 14 Jun 2024 14:07:47 -0400 Message-ID: Subject: Re: [PATCH 1/4] dts: Remove build target config and list of devices To: Nicholas Pratte Cc: Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com, luca.vizzarro@arm.com, juraj.linkes@pantheon.tech, bruce.richardson@intel.com, probb@iol.unh.edu, dmarx@iol.unh.edu, yoan.picchi@foss.arm.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jun 13, 2024 at 4:21=E2=80=AFPM Nicholas Pratte wrote: > > Remove the list of devices from the schema, as these are unuesed. > Likewise, removed build-target information since these is not currently > used, and it is unlikely to be used in the future. Adjustments to the > dts.rst are made to reflect these changes. > > Bugzilla ID: 1360 > Signed-off-by: Nicholas Pratte > > --- > doc/guides/tools/dts.rst | 11 --- > dts/conf.yaml | 5 +- > dts/framework/config/__init__.py | 30 +------- > dts/framework/config/conf_yaml_schema.json | 79 ---------------------- > dts/framework/config/types.py | 6 -- > dts/framework/runner.py | 2 +- > dts/framework/test_result.py | 14 +--- > dts/framework/testbed_model/sut_node.py | 8 +-- > 8 files changed, 5 insertions(+), 150 deletions(-) > > @unique > class Compiler(StrEnum): > r"""The supported compilers of :class:`~framework.testbed_model.node= .Node`\s.""" > @@ -340,28 +324,20 @@ class BuildTargetConfiguration: > The configuration used for building DPDK. > > Attributes: > - arch: The target architecture to build for. > - os: The target os to build for. > - cpu: The target CPU to build for. > compiler: The compiler executable to use. > compiler_wrapper: This string will be put in front of the compil= er when > executing the build. Useful for adding wrapper commands, suc= h as ``ccache``. > name: The name of the compiler. This attribute got removed from the class, we should take it out of the docstring too. > """ > > - arch: Architecture > - os: OS > - cpu: CPUType > compiler: Compiler > compiler_wrapper: str > - name: str > > @staticmethod > def from_dict(d: BuildTargetConfigDict) -> "BuildTargetConfiguration= ": > diff --git a/dts/framework/testbed_model/sut_node.py b/dts/framework/test= bed_model/sut_node.py > index 97aa26d419..34213f6884 100644 > --- a/dts/framework/testbed_model/sut_node.py > +++ b/dts/framework/testbed_model/sut_node.py > @@ -253,7 +248,6 @@ def _configure_build_target(self, build_target_config= : BuildTargetConfiguration) > """Populate common environment variables and set build target co= nfig.""" > self._env_vars =3D {} > self._build_target_config =3D build_target_config > - self._env_vars.update(self.main_session.get_dpdk_build_env_vars(= build_target_config.arch)) I'm not sure what the implications of removing this method call are, it seems like it adds some value to the DPDK build process by adding a CFLAG and a path to the pkgconfig directory. Maybe we don't need this, but there might be a reason it was there originally as well. > self._env_vars["CC"] =3D build_target_config.compiler.name > if build_target_config.compiler_wrapper: > self._env_vars["CC"] =3D ( > -- > 2.44.0 >