From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0654345482; Mon, 17 Jun 2024 16:36:04 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C90C34028B; Mon, 17 Jun 2024 16:36:03 +0200 (CEST) Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by mails.dpdk.org (Postfix) with ESMTP id 7869D4028A for ; Mon, 17 Jun 2024 16:36:02 +0200 (CEST) Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-2bfffa3c748so3588585a91.3 for ; Mon, 17 Jun 2024 07:36:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1718634961; x=1719239761; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=kfm7/VR4Fd4n4fBpXrulY7v1Kc59eaU7QVFlyCIDi4o=; b=V1cDqJItGawbsrPrTH9/A3lr4G9PY2NIGsMAhrnpY0yHyNYrozUHYgdSy1+7V/AR+7 Y7KEYWhDnlp1yT+62q1XSzpZQpB8HqwnjbmoKHxRwtN6tAn3kz4c9zaf6bvoSwCUfBr8 QNZ1rW7ItX1sj6tQKSMpM7YZ9LjV5OuP99kB0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718634961; x=1719239761; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kfm7/VR4Fd4n4fBpXrulY7v1Kc59eaU7QVFlyCIDi4o=; b=u0LkiF9vAHiGN7s/vyanG2dZVsB8h0+ukDMysuK30R/0AKChZ/RhyvTHwTgjodTrZn DECGOJrKoaKqKlSGAfYp5wn3LPos00izyTyNe/rffNTt8KD2UKEAkNWzc3OHI9pEBXJl lABH1xVKtL6T2eGDg4Fqhc5U1Zr3f8kQVDOW2bJGnUakt+v/n+16S47zNpIPd7vdI1jg 1S0jwEKNKpudVUQNA8NBqQdhZ8wa8QZtqQXW1ey1Z0mjsDurC5QkL2BhcROarchd8DNP dDwBzNdjUleIYzNxucYyhYSXaD/bre81RBdzz2R3MODbKjkE32bnb9uih6MewSr68bPs S/qg== X-Forwarded-Encrypted: i=1; AJvYcCWDRhjqii9xQTb5dO1bNYTm8K2HHo0MYvxIwno37lFlcW8E7LrjpvwKTeAPNOU5DxWEGVV7I7GnFv5bWuw= X-Gm-Message-State: AOJu0YwplHGUOHSgDNNiJWg9A4UAMvZ4Q2C9WJiBR3yqW43JWEYarDaK ZCjupokhhVGF1ea4Gn9bHRHfk01tKVxiunBsfZ6MK8PioKcPheAT62gOlyGheBnWKpoDv1fFfXW OMBLWYf2nkhm6zo5d+r8hLObk+rYs/La0iDHLaQ== X-Google-Smtp-Source: AGHT+IELv4+sOEC1ZlKmJQnHU3/gmFkIj8hPZ2zOBZHZ9/GeuTQ+KoE6ahq/ChnNQXOrJ7t1drTSS6CCjulp1ozlgoI= X-Received: by 2002:a17:90a:4281:b0:2c2:5a29:9bb5 with SMTP id 98e67ed59e1d1-2c4db1356f1mr9302357a91.5.1718634961336; Mon, 17 Jun 2024 07:36:01 -0700 (PDT) MIME-Version: 1.0 References: <20240611161606.23881-2-dmarx@iol.unh.edu> <20240614150238.26374-1-dmarx@iol.unh.edu> In-Reply-To: <20240614150238.26374-1-dmarx@iol.unh.edu> From: Jeremy Spewock Date: Mon, 17 Jun 2024 10:35:49 -0400 Message-ID: Subject: Re: [PATCH v3 0/3] VLAN Test Suite To: Dean Marx Cc: Honnappa.Nagarahalli@arm.com, juraj.linkes@pantheon.tech, probb@iol.unh.edu, paul.szczepanek@arm.com, yoan.picchi@foss.arm.com, bruce.richardson@intel.com, luca.vizzarro@arm.com, dev@dpdk.org Content-Type: multipart/alternative; boundary="0000000000005e9572061b16e2c6" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --0000000000005e9572061b16e2c6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hey Dean, Thanks for the series! One thing that caught my eye which I figured I'd mention here since it applies to all the commits is that generally with patches submitted to the dev mailing list the subject lines of the commits should include the component that the commit is relevant to. In our case with DTS, the component that you'd put at the start of the commit message would be "dts:". So, for example, your second commit in the series would be "dts: initial implementation for VLAN test suite". Another guideline is they should be all lowercase other than acronyms. You can see where I got this information from here: https://doc.dpdk.org/guides/contributing/patches.html#commit-messages-subje= ct-line . On Fri, Jun 14, 2024 at 11:03=E2=80=AFAM Dean Marx wrot= e: > VLAN test suite for ensuring VLAN filtering, stripping, and header > insertion is functional on DPDK Poll Mode Drivers. The suite contains > four test cases: > > 1. Enable VLAN filtering and disable stripping - verifies that packets > with a VLAN tag found in the filter list are received with the tag when > stripping is disabled. > 2. Enable VLAN filtering and stripping - verifies that packets with a > VLAN tag found in the filter list are received without the tag when > stripping is enabled. > 3. Disable VLAN packet receipt - verifies that packets with a VLAN tag > not found in the filter list are dropped. > 4. Enable VLAN header insertion in transmitted packets - verifies that > packets without a VLAN tag are received with a VLAN tag when header > insertion is enabled. > > VLAN functions are offloaded by the DPDK driver and use the Ethernet > Device API (rte_ethdev.) > > Dean Marx (3): > Added VLAN commands to testpmd_shell class > Initial implementation for VLAN test suite > Config schema > > dts/framework/config/conf_yaml_schema.json | 3 +- > dts/framework/remote_session/testpmd_shell.py | 164 +++++++++++++++++ > dts/tests/TestSuite_vlan.py | 172 ++++++++++++++++++ > 3 files changed, 338 insertions(+), 1 deletion(-) > create mode 100644 dts/tests/TestSuite_vlan.py > > -- > 2.44.0 > > --0000000000005e9572061b16e2c6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hey Dean,

Thanks for the series! One thing that caught my eye which I figured I'd mention here sinc= e it applies to all the commits is that generally with patches submitted to= the dev mailing list the subject lines of the commits should include the c= omponent that the commit is relevant to. In our case with DTS, the componen= t that you'd put at the start of the commit message would be "dts:= ". So, for example, your second commit in the series would be "dt= s: initial implementation for VLAN test suite". Another guideline is t= hey should be all lowercase other than acronyms. You can see where I got th= is information from here: https://doc= .dpdk.org/guides/contributing/patches.html#commit-messages-subject-line= .



On Fri, Jun 14, 2024 at 11:03=E2=80=AFAM Dean Ma= rx <dmarx@iol.unh= .edu> wrote:
VLAN test suite for ensuring VLAN filtering, stripping, and header
insertion is functional on DPDK Poll Mode Drivers. The suite contains
four test cases:

1. Enable VLAN filtering and disable stripping - verifies that packets
with a VLAN tag found in the filter list are received with the tag when
stripping is disabled.
2. Enable VLAN filtering and stripping - verifies that packets with a
VLAN tag found in the filter list are received without the tag when
stripping is enabled.
3. Disable VLAN packet receipt - verifies that packets with a VLAN tag
not found in the filter list are dropped.
4. Enable VLAN header insertion in transmitted packets - verifies that
packets without a VLAN tag are received with a VLAN tag when header
insertion is enabled.

VLAN functions are offloaded by the DPDK driver and use the Ethernet
Device API (rte_ethdev.)

Dean Marx (3):
=C2=A0 Added VLAN commands to testpmd_shell class
=C2=A0 Initial implementation for VLAN test suite
=C2=A0 Config schema

=C2=A0dts/framework/config/conf_yaml_schema.json=C2=A0 =C2=A0 |=C2=A0 =C2= =A03 +-
=C2=A0dts/framework/remote_session/testpmd_shell.py | 164 +++++++++++++++++=
=C2=A0dts/tests/TestSuite_vlan.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0| 172 ++++++++++++++++++
=C2=A03 files changed, 338 insertions(+), 1 deletion(-)
=C2=A0create mode 100644 dts/tests/TestSuite_vlan.py

--
2.44.0

--0000000000005e9572061b16e2c6--