From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B263144180; Fri, 7 Jun 2024 15:11:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9230842D55; Fri, 7 Jun 2024 15:11:20 +0200 (CEST) Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by mails.dpdk.org (Postfix) with ESMTP id BE7E7402B4 for ; Fri, 7 Jun 2024 15:11:18 +0200 (CEST) Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-702508bf0a9so1744280b3a.0 for ; Fri, 07 Jun 2024 06:11:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1717765878; x=1718370678; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=jdQO58detoxSojod5QHZ1nPr+5bgHSiBlXQUpe17psk=; b=L7QOBeT8epjkqcOpZxbrq0ZsL2sExWeqr1bejah35Dv1Zi/QHbMh+UjQEl6XjvJM3j iOSG8nnSjc7JoI4zrTk7YseYpxZtm7PV6H01gaOoseMxclXX/5FId7X2tSljVoWUyI00 uFCxC1lQ8vcp492YEe+kePrvaAqwJcL5a4Pck= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717765878; x=1718370678; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jdQO58detoxSojod5QHZ1nPr+5bgHSiBlXQUpe17psk=; b=D+1M1cRohzQAg5i3NOYMN1XoXaPBi9vTDhJxck3LOeqeP+i4lzydgi8gLntzi9Yvwf xfIjOraP4cuXVwVZOFAXnf+5KjGgZetWbd08zYGdaRe4YGe3NveRVaAh84DHMcNClrjY zIEJmJsAyv93OLc+9ZKNhsPPvBA5SIjUbxXLN3iBB+W4tv0hxlZB847vkOHi95j7zvJI S9J/BkhGPC/lAYHUzIxzybGcqBBvLWjKNQK2J9Qc9doKJX3kcRan2o8dnfH9ttyvtS3Y 9xWRR7vYV9leWjSFthU9HCnKrnKt28FFwtLvHQbfrab71tPn7ZXD0RPlQsDxl5JqtD9j H7xQ== X-Gm-Message-State: AOJu0Ywp7ln12Dlvo32IEHGd2LotbGWuoDlY8Hmb2VO1Dnz3XJuPvuwC auJhBK1q1yCE9SHJ5LuBXcxQAmpvkKEz1eMFm6LuhagaH4fk3uwpx4NKrwk9YbsSy797gOgdOfx +N1J1bjhWs+vUbfmz3fmKBjX0AGGQzMOlOw/PUw== X-Google-Smtp-Source: AGHT+IGRs4q8wlzQQ3N6zVRRtcLZQfZ/SBjDqlJVlWj/0oIlLp0qgqvLk3phpz0R6eGOSdJOj0e7q/91IDH5cQC7RTg= X-Received: by 2002:a17:90b:148c:b0:2c1:a77c:669a with SMTP id 98e67ed59e1d1-2c2bcaf970emr2295076a91.13.1717765877989; Fri, 07 Jun 2024 06:11:17 -0700 (PDT) MIME-Version: 1.0 References: <20240412111136.3470304-1-luca.vizzarro@arm.com> <20240606213420.254260-1-luca.vizzarro@arm.com> <20240606213420.254260-5-luca.vizzarro@arm.com> In-Reply-To: <20240606213420.254260-5-luca.vizzarro@arm.com> From: Jeremy Spewock Date: Fri, 7 Jun 2024 09:11:06 -0400 Message-ID: Subject: Re: [PATCH v5 4/5] dts: add `show port info` command to TestPmdShell To: Luca Vizzarro Cc: dev@dpdk.org, =?UTF-8?Q?Juraj_Linke=C5=A1?= , Paul Szczepanek Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jun 6, 2024 at 5:34=E2=80=AFPM Luca Vizzarro wrote: > > Add a new TestPmdPort data structure to represent the output > returned by `show port info`, which is implemented as part of > TestPmdShell. > > The TestPmdPort data structure and its derived classes are modelled > based on the relevant testpmd source code. > > This implementation makes extensive use of regular expressions, which > all parse individually. The rationale behind this is to lower the risk > of the testpmd output changing as part of development. Therefore > minimising breakage. > > Bugzilla ID: 1407 > > Signed-off-by: Luca Vizzarro > Reviewed-by: Paul Szczepanek Reviewed-by: Jeremy Spewock