From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 26FB743D6D; Thu, 28 Mar 2024 17:48:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 12F38410FC; Thu, 28 Mar 2024 17:48:53 +0100 (CET) Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) by mails.dpdk.org (Postfix) with ESMTP id 67A09410FC for ; Thu, 28 Mar 2024 17:48:51 +0100 (CET) Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-5c229dabbb6so728729a12.0 for ; Thu, 28 Mar 2024 09:48:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1711644530; x=1712249330; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=jPtdSNggvA4hFH2RNCTDEsGzSApeGQ8mTI9ecEeDavw=; b=W6f+nOihIxVc/0z+FFOt8TFlW6HW0taGhpwuatm1OWdcH0PhOe7uc9zSWixYgIdR3t k+Jsdz2wyd21VZ3g37D+2wVe3XWwKBMSCY+EwH1UBTR9yfU5/EAmOdKoCIJbJHwGHz5P 1q1NJGzoC2I2b2/YEwCTsICdlFn+MSV4RMXN0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711644530; x=1712249330; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jPtdSNggvA4hFH2RNCTDEsGzSApeGQ8mTI9ecEeDavw=; b=kEbR9IbwTUg82i1nn+d46XJGwvrwxkVmNH3mTSbOXykFRVgPB7qKZX4m6gjsPsPr0C ZyepO1EnyiFYXpaeFP52V2t4RVcsJztmFg7eaJhHcvQ4ch15DTXUFiIa1XCW5BsT6bym S5oukRtmcKdUoftsPoKeRc/2V0HwjcIDSbXobZPWu/R2ujrrNBmMkBF8w7KSnKJ64bMD hoQyo1kJrxmqhZqQi5hap/1Nze1Jf7FlKYPf5P7NjEm/TgMiCvM5hAqAnEiTrQaKUhhJ NGjbwi3+YOuL8lxK1QfDImzYqSmPd/2mPanfW3ZbGX4e3+G4pOuRqFgSJ7B1mJKz7aVQ qEjA== X-Gm-Message-State: AOJu0YwP1MMD25aUIzPZ+FDStWB+lC4361nC7ZGhnv/+JuFTwPTamiWV yyW3a4933mHTjH0YcU830E9hXB8oZYDZZDqQAvsVnWT3Rh3cTN7XMZLO57NKYLOTWEuyroQWL0p cch7/wiPEo0Th6xbbyHGxUe0Elm6OEUAvMZE8CA== X-Google-Smtp-Source: AGHT+IFcfAhqtgv4X3Q4BcrXuYP2OVqV6ZdONFtJVMjpZbGwDhU6JHaZwX2ofsYvfhNuN+5SajLBsVWogMWqgQgAl70= X-Received: by 2002:a17:90a:3045:b0:29f:a779:1075 with SMTP id q5-20020a17090a304500b0029fa7791075mr3077958pjl.37.1711644530669; Thu, 28 Mar 2024 09:48:50 -0700 (PDT) MIME-Version: 1.0 References: <20240326190422.577028-1-luca.vizzarro@arm.com> <20240326190422.577028-4-luca.vizzarro@arm.com> In-Reply-To: <20240326190422.577028-4-luca.vizzarro@arm.com> From: Jeremy Spewock Date: Thu, 28 Mar 2024 12:48:39 -0400 Message-ID: Subject: Re: [PATCH 3/6] dts: add testpmd shell params To: Luca Vizzarro Cc: dev@dpdk.org, =?UTF-8?Q?Juraj_Linke=C5=A1?= , Jack Bond-Preston , Honnappa Nagarahalli Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org We talked about this in DTS meeting, looking at this some more, we already use default parameters for Eal and structure those, so we already have sort of tied ourselves into a situation of if those ever change (unlikely) we would need to change as well, so maybe this could be something we use, I'd like to hear more of peoples thoughts on this and what Juraj thinks when he is back. Just because this is fairly large and bloats the testpmd file a little bit, it might be more worth it to move this into a separate file and import it so this file doesn't get too large. Especially because this file will likely already grow quite a bit just from the amount of testpmd commands we are going to have to handle in the future. On Tue, Mar 26, 2024 at 3:04=E2=80=AFPM Luca Vizzarro wrote: > > Implement all the testpmd shell parameters into a data structure. > > Signed-off-by: Luca Vizzarro > Reviewed-by: Jack Bond-Preston > Reviewed-by: Honnappa Nagarahalli > --- > 2.34.1 >