From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93DEB44120; Fri, 31 May 2024 23:07:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 856EF42DD1; Fri, 31 May 2024 23:07:07 +0200 (CEST) Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) by mails.dpdk.org (Postfix) with ESMTP id B08B642DCE for <dev@dpdk.org>; Fri, 31 May 2024 23:07:05 +0200 (CEST) Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-6c7bf648207so54282a12.0 for <dev@dpdk.org>; Fri, 31 May 2024 14:07:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1717189625; x=1717794425; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=gbaoEjXndHkWtoCFpR7dEBk500bzRv+jNIsRBjhEC6s=; b=Q7NKTWv8xhBhVAxMwX936cova3P2eejmY4WGl88M4Z4BFQm2Oqygso2RsU0Cj+3VaU wLw2Cd/NO70+x/6KgYzzCROJEmLYqXsumLIqINvqzWc+MGbgLt5LOa89EqwJthRuEn70 zhBpWOUGy/sJrmpZISC6IpbL9Cz8dxGsPTXws= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717189625; x=1717794425; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gbaoEjXndHkWtoCFpR7dEBk500bzRv+jNIsRBjhEC6s=; b=Z/yxH7UvKxVJMC6y5nqwTqn7mNqK4A8qoOBHdp6wHffaUd3qpU2yrWg2hJwiCiV4Zs lzHbphdBGO8cmCF7O7qGlM3lB3rS8TWStzsbP2zx2AFNe6l27JmfDAHmhtXQRZl+TrYs vB607EVL6rqBMjyzHXNrvTgVwdL0i27+ddQRXeVQLQysg22VS50F3YRgcTENdtvuk+Ez bSMSJjP/jjsSCwVT6K+INVdnozpkPAHXWFYEnuw7HrnpAvmI8OpJQUWFY3A8dPVzP464 RgjknG0u9JYFhDmGIEV61KylGzvkYuTnslh1QnRbCztCn/Qo2Lem92DCa/L4zeMNxWHM jMYw== X-Gm-Message-State: AOJu0YzqiAfWrnOv7tUS0pE7d7N8brVDGFKkeBbb63fEK5MJVZYSW8jn NCjrmmQAoVZXpnFoGHsWiUf8+x0f7xCjJAYQGDNmn3o5ZK8Xbr3cF0pD48Wz/L60ob+OXeXE8po 5UdPf4Ea2DUAmrbHb/qiDJcLCA/uWGDpqOVau90jJ1eL5npNy X-Google-Smtp-Source: AGHT+IEnoHgJRI3gyC/CbU9hIAICNj2ozUoIonyHHUDLagx4MZDT1WHLCtaLXWKTi3MkVjBj/1PRHJ943/mQ9MHUU90= X-Received: by 2002:a17:90b:4ecd:b0:2c1:c648:1623 with SMTP id 98e67ed59e1d1-2c1dc573674mr3084897a91.20.1717189624852; Fri, 31 May 2024 14:07:04 -0700 (PDT) MIME-Version: 1.0 References: <20240412111136.3470304-1-luca.vizzarro@arm.com> <20240509112635.1170557-1-luca.vizzarro@arm.com> <20240509112635.1170557-5-luca.vizzarro@arm.com> In-Reply-To: <20240509112635.1170557-5-luca.vizzarro@arm.com> From: Jeremy Spewock <jspewock@iol.unh.edu> Date: Fri, 31 May 2024 17:06:53 -0400 Message-ID: <CAAA20URtSF7xQg_1DfU6Sf54v5sbPficdb0OD3iHsD1mGp9+kw@mail.gmail.com> Subject: Re: [PATCH v2 4/5] dts: add `show port info` command to TestPmdShell To: Luca Vizzarro <luca.vizzarro@arm.com> Cc: dev@dpdk.org, =?UTF-8?Q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech>, Paul Szczepanek <paul.szczepanek@arm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org All looks good to me, with one documentation nit-pick On Thu, May 9, 2024 at 7:26=E2=80=AFAM Luca Vizzarro <luca.vizzarro@arm.com= > wrote: > > Add a new TestPmdPort data structure to represent the output > returned by `show port info`, which is implemented as part of > TestPmdShell. > > The TestPmdPort data structure and its derived classes are modelled > based on the relevant testpmd source code. > > This implementation makes extensive use of regular expressions, which > all parse individually. The rationale behind this is to lower the risk > of the testpmd output changing as part of development. Therefore > minimising breakage. > > Bugzilla ID: 1407 > > Signed-off-by: Luca Vizzarro <luca.vizzarro@arm.com> > Reviewed-by: Paul Szczepanek <paul.szczepanek@arm.com> > --- <snip> > +class DeviceCapabilitiesFlag(Flag): > + """Flag representing the device capabilities.""" > + > + RUNTIME_RX_QUEUE_SETUP =3D auto() > + """Device supports Rx queue setup after device started.""" > + RUNTIME_TX_QUEUE_SETUP =3D auto() > + """Device supports Tx queue setup after device started.""" > + RXQ_SHARE =3D auto() > + """Device supports shared Rx queue among ports within Rx domain and = switch domain.""" > + FLOW_RULE_KEEP =3D auto() > + """Device supports keeping flow rules across restart.""" > + FLOW_SHARED_OBJECT_KEEP =3D auto() > + """Device supports keeping shared flow objects across restart.""" > + In the other flag classes it looks like these doc-strings were changed to be in the class var format (`#:`), but these might have been missed when going through and changing the others. > + @classmethod > + def make_parser(cls) -> ParserFn: <snip> > 2.34.1 >