From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F336643883; Wed, 10 Jan 2024 15:10:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E2124402F1; Wed, 10 Jan 2024 15:10:09 +0100 (CET) Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by mails.dpdk.org (Postfix) with ESMTP id F2CA2402F0 for ; Wed, 10 Jan 2024 15:10:08 +0100 (CET) Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-28d2be70358so2267348a91.0 for ; Wed, 10 Jan 2024 06:10:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1704895808; x=1705500608; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=GlFerzOK5QrOc34dVALE4i5Jhc1ks4yqT1Fv+Pqh5tU=; b=ASgS1wo+//53/0x+O+CHnRz3CaJ1MyWVyD2ABV8TS78C1q8FhxP2ri89Xe00XiItcg n6PQMoSoQQoSr4XVigFdQyXPz0i59aHWtZEva32wWMaghuwuJDa9avqRJO129jXgbjZB J4pTSpHHpvc37m0xfn9qoCXNq8kDcdyiHRzr8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704895808; x=1705500608; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GlFerzOK5QrOc34dVALE4i5Jhc1ks4yqT1Fv+Pqh5tU=; b=FYw09kxdsEuaOKzGeqQ1cBRpmNp1luETfmSrrYH+Q3v68+OHYHvRwxOEALV0TiqTOW GXS2Twxp29kycOulYVrZXSg3PAFyqtOJDAhPMyG0aGlPKBtswzf5JexcimOMtS5SLC6j yC6Lwf6DGizA9pZjiWlHDvWkrTja719xAfXwSaEjVg6KkNXpDkOog7ZqX/TqKxvyJdXU 2JAepxCDhlOEtmI61Hxf+zyA572i9Q55ZITHN1+bwpHVp3dNA7lfoWOOtX2tkjoqYhCS D+SwJxnUcGXXK/bA694gWrxERagFjNglJ1u8I+Nx1qWzwkcihIDEsm77tfjO9dTLeT23 g34A== X-Gm-Message-State: AOJu0YxrV1AL6H2nKDqSF7s0fUCa4C+b63Z94pvY7AYAY/rPKbt7HlRj RAGiLAEsX2I/RXX5DqoA7987qWJSNl4mHrDmBYzZH02X9GFrpA== X-Google-Smtp-Source: AGHT+IENnU9pEQ/xyMzCHLsK/BY7UH7eKEdtlP/gu7J2LZhJbg6AiMLSuUAzr5tuCo7Md50oaLpBaOn2AIrZyY3xj44= X-Received: by 2002:a17:90a:db49:b0:28c:8ea3:26a0 with SMTP id u9-20020a17090adb4900b0028c8ea326a0mr615998pjx.23.1704895808155; Wed, 10 Jan 2024 06:10:08 -0800 (PST) MIME-Version: 1.0 References: <20240103223206.23129-1-jspewock@iol.unh.edu> <20240109153633.766-1-jspewock@iol.unh.edu> <20240109153633.766-2-jspewock@iol.unh.edu> In-Reply-To: From: Jeremy Spewock Date: Wed, 10 Jan 2024 09:09:57 -0500 Message-ID: Subject: Re: [PATCH v7 1/7] dts: add startup verification and forwarding modes to testpmd shell To: =?UTF-8?Q?Juraj_Linke=C5=A1?= Cc: Honnappa.Nagarahalli@arm.com, thomas@monjalon.net, wathsala.vithanage@arm.com, probb@iol.unh.edu, paul.szczepanek@arm.com, yoan.picchi@foss.arm.com, lylavoie@iol.unh.edu, ferruh.yigit@amd.com, andrew.rybchenko@oktetlabs.ru, dev@dpdk.org Content-Type: multipart/alternative; boundary="000000000000064848060e97fda1" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --000000000000064848060e97fda1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Good to know, I'll fix this. On Wed, Jan 10, 2024 at 8:18=E2=80=AFAM Juraj Linke=C5=A1 wrote: > > diff --git a/dts/framework/remote_session/testpmd_shell.py > b/dts/framework/remote_session/testpmd_shell.py > > index 0184cc2e71..11c5c7f93c 100644 > > --- a/dts/framework/remote_session/testpmd_shell.py > > +++ b/dts/framework/remote_session/testpmd_shell.py > > > @@ -82,3 +182,50 @@ def get_devices(self) -> list[TestPmdDevice]: > > if "device name:" in line.lower(): > > dev_list.append(TestPmdDevice(line)) > > return dev_list > > + > > + def wait_link_status_up(self, port_id: int, > timeout=3DSETTINGS.timeout) -> bool: > > + """Wait until the link status on the given port is "up". > > + > > + Arguments: > > + port_id: Port to check the link status on. > > + timeout: Time to wait for the link to come up. The default > value for this > > + argument may be modified using the :option:`-t, > --timeout` command-line argument > > This should be just :option:`--timeout`, otherwise Sphinx complains: > WARNING: unknown option: '-t, --timeout' > > > + or the :envvar:`DTS_TIMEOUT` environment variable. > > + > > + Returns: > > + Whether the link came up in time or not. > > + """ > --000000000000064848060e97fda1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Good to know, I'll fix this.

On Wed, Jan 10, 2024 at 8:1= 8=E2=80=AFAM Juraj Linke=C5=A1 <juraj.linkes@pantheon.tech> wrote:
> diff --git a/= dts/framework/remote_session/testpmd_shell.py b/dts/framework/remote_sessio= n/testpmd_shell.py
> index 0184cc2e71..11c5c7f93c 100644
> --- a/dts/framework/remote_session/testpmd_shell.py
> +++ b/dts/framework/remote_session/testpmd_shell.py
<snip>
> @@ -82,3 +182,50 @@ def get_devices(self) -> list[TestPmdDevice]: >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if "device name:&= quot; in line.lower():
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 dev_list= .append(TestPmdDevice(line))
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return dev_list
> +
> +=C2=A0 =C2=A0 def wait_link_status_up(self, port_id: int, timeout=3DS= ETTINGS.timeout) -> bool:
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 """Wait until the link sta= tus on the given port is "up".
> +
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 Arguments:
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 port_id: Port to check the = link status on.
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 timeout: Time to wait for t= he link to come up. The default value for this
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 argument may = be modified using the :option:`-t, --timeout` command-line argument

This should be just :option:`--timeout`, otherwise Sphinx complains:
WARNING: unknown option: '-t, --timeout'

> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 or the :envva= r:`DTS_TIMEOUT` environment variable.
> +
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 Returns:
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Whether the link came up in= time or not.
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 """
--000000000000064848060e97fda1--