From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D34C343330; Wed, 15 Nov 2023 00:41:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6518A40285; Wed, 15 Nov 2023 00:41:56 +0100 (CET) Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by mails.dpdk.org (Postfix) with ESMTP id 4854D40261 for ; Wed, 15 Nov 2023 00:41:55 +0100 (CET) Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-28039ee1587so4779000a91.2 for ; Tue, 14 Nov 2023 15:41:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1700005314; x=1700610114; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=i2F18PzzngrKQ+nm77pKJh1h1t+aFh/XVkR51rFOpyc=; b=XFNgWciWcERcr3jPIuGN8+GnqFdfHDpIWSSh2oxTkWS/KWPP5HM0noITsyhC9ULyVh nnZRA+CBJQcOG7Fkmh35aH43qnmtbtzfMEn2pmKmzzdMtIt+fH1siEUp12XF1PuqBfBi irTFf3ih4hUuRK1glU/civpkqvQxmKc2BLdDc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700005314; x=1700610114; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=i2F18PzzngrKQ+nm77pKJh1h1t+aFh/XVkR51rFOpyc=; b=iDwWd5dUjpuwuVZT3xwasLlx8C1Y+xEw7xAGpvq1oSfumyVncuWwSnaq+uZ5N7wFo2 vipo4P5suSmXO+yf4CueDBsDBB6TRdvijxQHtN9dI5OkDuU3si12XuRR37YaBl8QMEDX ARR3LUVKknv2nuD9JZvSVA6lLcH86TA26Gxn0lNfa0on2jf7eqCkUozaRwL0AQHEToNr /chqPZX7KE8F+klR2elfZLOzHP0h2oe9Kp3fjMD8ZT3Sgvt9GeKxrMqC1RAJp1y35Wi0 DOXSjMXpWFkl522zi0xB66us4Ypsj06iN5giAUSdzi8t6zVMsYLUs4FbPdwxBmzjVO02 JmkQ== X-Gm-Message-State: AOJu0YxNzllaVazPlTPSKFpouT8ytZ9X98Cuq/uXDg+jVe6pPX00LzVw afxwgVABi8wqJyudK84GKQSi617GAHu+aEIDgkXcxA== X-Google-Smtp-Source: AGHT+IGMu5ZGdrjcVlfircleoiYq1SRhfgP9JzGKSjdFax0bspphTdGgyvQgdfp3DByvdxCZvCyvpzxTVTG+HEFOnJY= X-Received: by 2002:a17:90b:4c07:b0:280:99f0:4234 with SMTP id na7-20020a17090b4c0700b0028099f04234mr8655999pjb.7.1700005314250; Tue, 14 Nov 2023 15:41:54 -0800 (PST) MIME-Version: 1.0 References: <20231109231707.25400-1-jspewock@iol.unh.edu> <20231109231707.25400-2-jspewock@iol.unh.edu> <5777666.tdWV9SEqCh@thomas> In-Reply-To: <5777666.tdWV9SEqCh@thomas> From: Jeremy Spewock Date: Tue, 14 Nov 2023 18:41:43 -0500 Message-ID: Subject: Re: [PATCH v3 1/1] dts: bind to DPDK driver before running test suites To: Thomas Monjalon Cc: dev@dpdk.org, Honnappa.Nagarahalli@arm.com, juraj.linkes@pantheon.tech, wathsala.vithanage@arm.com, paul.szczepanek@arm.com, yoan.picchi@foss.arm.com, Patrick Robb Content-Type: multipart/alternative; boundary="000000000000df6e3e060a25548f" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --000000000000df6e3e060a25548f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Nov 14, 2023 at 4:49=E2=80=AFPM Thomas Monjalon wrote: > 13/11/2023 18:56, Patrick Robb: > > On Thu, Nov 9, 2023 at 6:17=E2=80=AFPM wrote: > > > > > From: Jeremy Spewock > > > > > > Modifies the current process so that we bind to os_driver_for_dpdk fr= om > > > the configuration file before running test suites and bind back to th= e > > > os_driver afterwards. This allows test suites to assume that the port= s > > > are bound to a DPDK supported driver or bind to either driver as > needed. > > > > > > Signed-off-by: Jeremy Spewock > > > > > > We discussed this aspect of binding during last week's CI meeting and= I > > understood Juraj to be consenting to returning to DTS running the bindi= ng > > to the dpdk driver (so, what you're doing here), as opposed to relying = on > > the user to do it, and making it a smoke test. As we've discussed, that= 's > > how the old DTS framework ran, and I prefer to stick to this approach. > One > > aspect I raised was how in a lab context it's desirable for us to defin= e > as > > much as possible within config files, and have environmental > configuration > > be handled by DTS. So, since there was basically agreement here, I thin= k > > your changes here are appropriate. > > > > Acked-by: Patrick Robb > > Not sure it is a good idea to add something knowing it will be reworked, > but you agreed, so I apply. > > I believe logically the methods I am adding here wouldn't end up needing to be refactored, the refactor part would be of the already existing logic in the TGNode to allow for it to be able to use the method I wrote here. There are a few things that would need to change if we wanted to be able to support doing this on the TGNode because the current framework doesn't exactly allow for it since the devbind script doesn't exist on that node. The main reason I refrained from doing that rework in this patch is due to the lack of need for the support of it on the TGNode at this time (and potentially in the future) and the lack of existing support. The methods I am writing here however would likely not need to be reworked, just moved to their superclass if we decided we wanted to do the TGNode rework and add support. Apologies if I made it sound like I was submitting these changes just for them to be completely overridden and changed in the near future and hopefully that makes a little more sense. Thank you for applying! > PS: please make all versions of the same patch in the same email thread. > I will start doing this in future patches, sorry for any difficulty it may have caused trying to see previous comments. --000000000000df6e3e060a25548f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


<= div dir=3D"ltr" class=3D"gmail_attr">On Tue, Nov 14, 2023 at 4:49=E2=80=AFP= M Thomas Monjalon <thomas@monjalo= n.net> wrote:
13/11/2023 18:56, Patrick Robb:
> On Thu, Nov 9, 2023 at 6:17=E2=80=AFPM <jspewock@iol.unh.edu> wrote:
>
> > From: Jeremy Spewock <jspewock@iol.unh.edu>
> >
> > Modifies the current process so that we bind to os_driver_for_dpd= k from
> > the configuration file before running test suites and bind back t= o the
> > os_driver afterwards. This allows test suites to assume that the = ports
> > are bound to a DPDK supported driver or bind to either driver as = needed.
> >
> > Signed-off-by: Jeremy Spewock <jspewock@iol.unh.edu>
> >
> > We discussed this aspect of binding during last week's CI mee= ting and I
> understood Juraj to be consenting to returning to DTS running the bind= ing
> to the dpdk driver (so, what you're doing here), as opposed to rel= ying on
> the user to do it, and making it a smoke test. As we've discussed,= that's
> how the old DTS framework ran, and I prefer to stick to this approach.= One
> aspect I raised was how in a lab context it's desirable for us to = define as
> much as possible within config files, and have environmental configura= tion
> be handled by DTS. So, since there was basically agreement here, I thi= nk
> your changes here are appropriate.
>
> Acked-by: Patrick Robb <probb@iol.unh.edu>

Not sure it is a good idea to add something knowing it will be reworked, but you agreed, so I apply.
=C2=A0

=
I belie= ve logically the methods I am adding here wouldn't end up needing to be= refactored, the refactor part would be of the already existing logic in th= e TGNode to allow for it to be able to use the method I wrote here. There a= re a few things that would need to change if we wanted to be able to suppor= t doing this on the TGNode because the current framework doesn't exactl= y allow for it since the devbind script doesn't exist on that node. The= main reason I refrained from doing that rework in this patch is due to the= lack of need for the support of it on the TGNode at this time (and potenti= ally in the future) and the lack of existing support.

The methods I am wri= ting here however would likely not need to be reworked, just moved to their= superclass if we decided we wanted to do the TGNode rework and add support= . Apologies if I made it sound like I was submitting these changes just for= them to be completely overridden and changed in the near future and hopefu= lly that makes a little more sense.

Thank you for applying!

<= /div>
=C2=A0
PS: please make all versions of the same patch in the same email thread.

I will start doing this in future patches, sorry for = any difficulty it may have caused trying to see previous comments.
--000000000000df6e3e060a25548f--