From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EBD93457BD; Mon, 26 Aug 2024 19:13:17 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D4AF2400EF; Mon, 26 Aug 2024 19:13:17 +0200 (CEST) Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by mails.dpdk.org (Postfix) with ESMTP id 69BD84003C for ; Mon, 26 Aug 2024 19:13:16 +0200 (CEST) Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-2d3c05dc63eso3581403a91.0 for ; Mon, 26 Aug 2024 10:13:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1724692395; x=1725297195; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Ta4Y3lA0APf9lVTViY8PZy+io6w6NMW+plBmYFhxh9o=; b=EdatTgxQE1moM7D6f48LxCx+ekjZgkpGLrkR8+yNClu4/uT0UXZUGuxa4miQZ2Yib8 UA+4gOWQoz8vhCeSF1vMXCaN20oRmymP+468DlCV6BcNM87HcxvJP4lrlDn5Z1f7XotE sY/EdXuSvIbQo3ehRqd6wP7Ziwdt+qKVqUpAw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724692395; x=1725297195; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ta4Y3lA0APf9lVTViY8PZy+io6w6NMW+plBmYFhxh9o=; b=DWzqFn4zvSuHSoEWOr+v6k8O8YaWL9d4KTKfKug5jQXMX4kiRU532P2m9FyM4BG18/ PMEffHVwhgoECML+y9yi3Qi5qj3gMhXWg638oPFrUiSz7HE7Vr+TD0KE62wCM8Nucjzh xTASu1HI760xbgPUtmE86NDI+eZV+AbwFv3XlYjDF7WiRt6R1TXAuodvOOetBYip6fyd 3MZzV5SGrBtucjJoHx9mR3cvF08XyLBJddosj/YFFRJ8yNWlkcYOJ5YhEky9hgTYQeRt fo79LVRND05S+EoTjsJszD1GoXJ3eu/a27W3K5ie0/FT9ChrNye/Ky1Ikz6V+2dnWrcn 6Btw== X-Forwarded-Encrypted: i=1; AJvYcCVZ7q63zHZwL5c7eZ+9ZCkIercShf2NBuuFpkkpM0qYT8/H/r7LLEZ8i7tvBCukbXtGTlU=@dpdk.org X-Gm-Message-State: AOJu0YwMZZ2ZSWvpRZN3bKRpY4HZkpVUb+myct0zoN6JC7zPtdXqDzXi b9d/4hwytrfDzV8/i/KfkQntRGvIHsiCpDC+c4LhPoCc6ZO5ZeriHD5vk1RLHOyHxBijvhvEgzl Jt1u13miTxIhskAfGuEbGQTl9/0/FHhWRYdcJjw== X-Google-Smtp-Source: AGHT+IG/E+VkbRDzogmC+e+HAsg1rRAbZoY85j3fHaendZJymw0HTAi8Mqk0BV9kZxDxA/VfLOME+G4j1sBwsJ0sl24= X-Received: by 2002:a17:90b:2397:b0:2d3:da6d:8330 with SMTP id 98e67ed59e1d1-2d646bd1a3dmr11634521a91.4.1724692395432; Mon, 26 Aug 2024 10:13:15 -0700 (PDT) MIME-Version: 1.0 References: <20240301155416.96960-1-juraj.linkes@pantheon.tech> <20240821145315.97974-1-juraj.linkes@pantheon.tech> <20240821145315.97974-10-juraj.linkes@pantheon.tech> In-Reply-To: <20240821145315.97974-10-juraj.linkes@pantheon.tech> From: Jeremy Spewock Date: Mon, 26 Aug 2024 13:13:02 -0400 Message-ID: Subject: Re: [PATCH v3 09/12] dts: add topology capability To: =?UTF-8?Q?Juraj_Linke=C5=A1?= Cc: thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, probb@iol.unh.edu, paul.szczepanek@arm.com, Luca.Vizzarro@arm.com, npratte@iol.unh.edu, dmarx@iol.unh.edu, alex.chapman@arm.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Aug 21, 2024 at 10:53=E2=80=AFAM Juraj Linke=C5=A1 wrote: > > Add support for marking test cases as requiring a certain topology. The > default topology is a two link topology and the other supported > topologies are one link and no link topologies. > > The TestProtocol of test suites and cases is extended with the topology > type each test suite or case requires. Each test case starts out as > requiring a two link topology and can be marked as requiring as > topology directly (by decorating the test case) or through its test > suite. If a test suite is decorated as requiring a certain topology, all > its test cases are marked as such. If both test suite and a test case > are decorated as requiring a topology, the test case cannot require a > more complex topology than the whole suite (but it can require a less > complex one). If a test suite is not decorated, this has no effect on > required test case topology. > > Since the default topology is defined as a reference to one of the > actual topologies, the NoAliasEnum from the aenum package is utilized, > which removes the aliasing of Enums so that TopologyType.two_links and > TopologyType.default are distinct. This is needed to distinguish between > a user passed value and the default value being used (which is used when > a test suite is or isn't decorated). > > Signed-off-by: Juraj Linke=C5=A1 This patch looks good to me outside of some of the overlapping comments from the DecoratedNicCapability class (mainly just _get_unique).