From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 89C5245945; Mon, 9 Sep 2024 17:56:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 549DA40EDB; Mon, 9 Sep 2024 17:56:11 +0200 (CEST) Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by mails.dpdk.org (Postfix) with ESMTP id 8552740ED8 for ; Mon, 9 Sep 2024 17:56:09 +0200 (CEST) Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-7c691c8f8dcso3050000a12.1 for ; Mon, 09 Sep 2024 08:56:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1725897368; x=1726502168; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=MUQBjtIbTzhNzVbEeWJ6A18E+EUvsUS7oRImpKggi58=; b=NuqcMeVc1fWbraj3rsEqxy+EyJv0HonBS8LPSzheyMnKFZilD5+VMhRIFqeY06XVAv J7W2GoSFPd9+yU8+5SlW3a5DYzHaHmMXiS9KNfZytDq4/z6X4RZKlD+xKqlDeJHnSpOW GlmeT7ovFm05FNe4FbxaPRfpVfXL85LDBAHe0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725897368; x=1726502168; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MUQBjtIbTzhNzVbEeWJ6A18E+EUvsUS7oRImpKggi58=; b=K4j4Quan3hxY8zyENznP8KJBJGARbfHoKEbTvmjAuOsJw/8J0GOQsK5Q3GcVl+kFcS vsYX/N8v9zgUhsO9aeLqSz87VfkcxqsOFT7ouFb9lN8ZBICtAFfn4u9IkJTZyLAhAuDS IYKbmdNFwj9aIZGkwM3sSaTixNJNLOwMXVjvGN/WW20bel/Yp6arTaF6FhwN54DlibIr 5uu6KBUHlMaaaFhH3XcQFvvTkz/N1uX1S4viA4L9UC9YtRU1lJ1WAcISAW26Qlnwt4jq Xj/Eajx80ckWmQzVVOh/gzi5KZik9a2URGX/VlQt2oH8sF5w+GH3fHPBfSFAf9s9euFX 6Ygw== X-Forwarded-Encrypted: i=1; AJvYcCVLHgXiVWE8wK+z2mLvWDZD9neOdaNRVEy/xbW2YV6y2kUxqQemN3NXIFTn9U2NL4eEzrE=@dpdk.org X-Gm-Message-State: AOJu0YzcXuA7kNbhH0CR0WyzxLLFc7GgHiQ9e/tXbmqfMdwbJdMc7zW4 sMotN81wQg4ddj5X3nm7wg70yv/Q4HIl9Vq9Wyfn+mpxwqk+yTNuhmoCW2ddpL9RpCkByfVBalP DAD4xe/ItfwO1htWxhfBrmPVa3eKYpbSQFHLh2Q== X-Google-Smtp-Source: AGHT+IEYQdBm5baz+9wKYVHRMyGmV6gOJEeQgv9GZFLAC1p9tkAkp926Kq8f4uHWwvTPkRz6m9qmCSpqYXgr4fLS3fE= X-Received: by 2002:a17:90a:5802:b0:2c9:5c67:dd9e with SMTP id 98e67ed59e1d1-2dad50139d8mr13615789a91.19.1725897368403; Mon, 09 Sep 2024 08:56:08 -0700 (PDT) MIME-Version: 1.0 References: <20240812172251.41131-1-jspewock@iol.unh.edu> <20240812172251.41131-2-jspewock@iol.unh.edu> In-Reply-To: From: Jeremy Spewock Date: Mon, 9 Sep 2024 11:55:55 -0400 Message-ID: Subject: Re: [PATCH 1/1] dts: add binding to different drivers to TG node To: =?UTF-8?Q?Juraj_Linke=C5=A1?= Cc: alex.chapman@arm.com, Luca.Vizzarro@arm.com, wathsala.vithanage@arm.com, Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com, npratte@iol.unh.edu, thomas@monjalon.net, yoan.picchi@foss.arm.com, probb@iol.unh.edu, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Sep 9, 2024 at 8:16=E2=80=AFAM Juraj Linke=C5=A1 wrote: > > > > On 12. 8. 2024 19:22, jspewock@iol.unh.edu wrote: > > From: Jeremy Spewock > > > > The DTS framework in its current state supports binding ports to > > different drivers on the SUT node but not the TG node. The TG node > > already has the information that it needs about the different drivers > > that it has available in the configuration file, but it did not > > previously have access to the devbind script, so it did not use that > > information for anything. > > > > This patch moves the steps to copy the DPDK tarball into the node class > > rather than the SUT node class, and calls this function on the TG node > > as well as the SUT. It also moves the driver binding step into the Node > > class and triggers the same pattern of binding to ports that existed on > > the SUT on the TG. > > > > This is a very inefficient way to do this. We'll have to build DPDK > twice and that's very time consuming. I was thinking in terms of just This patch shouldn't be compiling DPDK twice, are you referring to the process of copying the tarball over and extracting it taking too long? If so, that makes sense that it takes longer than we need for this one task. I figured it wouldn't hurt to have the whole DPDK directory there, and that it could even be potentially useful to have it if the TG ever needed it. That and it seemed like the most straightforward way that kept these two set up in a similar way. Extracting the tarball is obviously pretty quick, so I guess the real question here is whether it is fine to add the time of one extra SCP of the DPDK tarball around. > copying the script to the TG node and storing its location on the TG > node. We should have access to the script whether DTS is run from the > repository or a tarball. We should have access to it regardless, but extracting only that one script would be different based on if it was a tarball or a repository since, I believe at least, I would have to use the tarfile library to read and extract only this one file to copy over if it was a tarball. It would be faster I assume, so if you think it is worth it I could make the change. Unless you are saying that we wouldn't need to take the devbind script from the tarball that is passed into the DTS run and instead assume that we can just go one directory up from `dts/` on the runner host. That could be an interesting idea which would be faster, but I wasn't sure if that was something that was fine to do since (I don't think at least) there is anything that technically ties you to running from in a DPDK directory other than the docker container. >