From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4970944120; Fri, 31 May 2024 23:08:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3AED442DDE; Fri, 31 May 2024 23:08:36 +0200 (CEST) Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by mails.dpdk.org (Postfix) with ESMTP id BBA8742DB2 for ; Fri, 31 May 2024 23:08:34 +0200 (CEST) Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-2bdf11888a5so2083747a91.0 for ; Fri, 31 May 2024 14:08:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1717189714; x=1717794514; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=hdt02QSHTHmQgogKgz7fOjH/aNJV6/sq7zcDtZ2Yphw=; b=gDFNumMN39MyisPPJbkM+d9CDZMS2Js34u87ZkCWTsyNM4xuUMfdzcmsREmhT+Gpdb e6YzQZJz7lqGJXnwGd5bsNywWbBsQvEoR9xpRvolwBAoY+lcjJgLMMMfG3GLqC0iNVRB +8xzdJtvejGgCHDBb8peQm2bOxwH9tYV0KY7U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717189714; x=1717794514; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hdt02QSHTHmQgogKgz7fOjH/aNJV6/sq7zcDtZ2Yphw=; b=H1ItZUyRnqgOJLJZHddIS+sxrmWRJ4nJE7nAymaRe/mOXpxlBj7GuJ5WlJ+1WBYXh5 rDvpgTx4mkt1ACbvz2AO+DZKrEfzQU0G/0LPvHrMu+FCY91kog2G47WfBfW9SlA3RBMw 2stRWckjXLqDjBTt3yIYGB5zDVso55V0MkLfdsZQUcIvWiX3wXyk/rMVOjiDQH8arQk/ eM+LtFSgzI4vXsb5lbGtDSjuu1AcolwcUnkbCk1bDaLoOhEzxK1dE/F7+uNrRpyOapSA pP5ybchSXRttdDiuxNoE1V/R9doI3sQJFCxSbwWAABeugvFPQ72ywNqeUw++LcFJ3nVZ yFKg== X-Forwarded-Encrypted: i=1; AJvYcCVhsOx27D15ibr1KoEbgMFFPaSS+uLaaanU3EK76sd/fGzfTe+lJXflDOrm/BQfcbi+CBCPtdjD75JlIhA= X-Gm-Message-State: AOJu0YwO4S54Ky05pUlpMHRBrskvpPsrthV0/uCd9C+s7Fhdyj0C+61B GelxV/dCy6/Df2VVvRk2kM4qlVOi13oSjMEJmTkt6PpjrV/euYthWX4U6CZ9UHsiTNnZ7WimalR DDiQeZYByCpSIZg/T/3Bo5Px/QljFw4gDr6jNaA== X-Google-Smtp-Source: AGHT+IG+JJej7T1XHq0Xl9PzQCtn+/paWXFg4HOzm4w5C5g/o39L3SECou9cW8sNV8mKYl2buLEXawv9Sg3BwVDUpZI= X-Received: by 2002:a17:90a:c907:b0:2bf:c92d:2948 with SMTP id 98e67ed59e1d1-2c1dc56c451mr2704318a91.3.1717189713907; Fri, 31 May 2024 14:08:33 -0700 (PDT) MIME-Version: 1.0 References: <20240514201436.2496-1-jspewock@iol.unh.edu> <20240530163339.14566-1-jspewock@iol.unh.edu> <20240530163339.14566-4-jspewock@iol.unh.edu> <10406e58-8b37-4f5a-bcd9-c0a24922345a@arm.com> In-Reply-To: <10406e58-8b37-4f5a-bcd9-c0a24922345a@arm.com> From: Jeremy Spewock Date: Fri, 31 May 2024 17:08:22 -0400 Message-ID: Subject: Re: [PATCH v2 3/4] dts: add methods for modifying MTU to testpmd shell To: Luca Vizzarro Cc: juraj.linkes@pantheon.tech, paul.szczepanek@arm.com, wathsala.vithanage@arm.com, Honnappa.Nagarahalli@arm.com, probb@iol.unh.edu, yoan.picchi@foss.arm.com, npratte@iol.unh.edu, thomas@monjalon.net, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, May 31, 2024 at 12:34=E2=80=AFPM Luca Vizzarro wrote: > > Due to the nature of this patch the console is spammed with a lot of > commands. Would it be better to log these in debug and instead log: > Setting port X to MTU XXXX > as INFO? Potentially, but this would require a global change for how logging works when sending commands to interactive shells in general. They are each logged as their own message since they are each individual commands being sent into the shell which (in general) we do want to log. I could maybe add an optional flag to the send command function that logs its output to debug rather than info however which might be a nicer solution. I agree that it does get cluttered.