From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A6F5344177; Thu, 6 Jun 2024 20:53:12 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 900EF427D7; Thu, 6 Jun 2024 20:53:12 +0200 (CEST) Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) by mails.dpdk.org (Postfix) with ESMTP id 0DAB4427DC for ; Thu, 6 Jun 2024 20:53:11 +0200 (CEST) Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-6c53a315c6eso1065804a12.3 for ; Thu, 06 Jun 2024 11:53:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1717699990; x=1718304790; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vJ2GZ3znXtGnOqCyH4JQ5MrmZZO+wSrU28JTKex026Y=; b=N07M3HRugPaC9cZ1ADG6bkGHr6q0D7VYDLgqzJeW7LDlSGXXa7YTwD2T/cgpshRXBj ykaas7zSwZ0hTgH0OoO0K53n7pIqJv7iOaVRbGM61Qm0YKPEOYnsddMiQRsC92N4/r1O 5t+2pD8bAsLniH7xM71Fst5cEUwY8PQRpt1Ys= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717699990; x=1718304790; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vJ2GZ3znXtGnOqCyH4JQ5MrmZZO+wSrU28JTKex026Y=; b=tKZ9/hp9QQeoiy6Xhup/aMq9dWULkpuse4y5Cw1Mt0SBhpSGssuJQq8tdknubDfee+ 0BtQN9fbHb6Qqhii9NpXVTU9FKH862gAZ9Mg8H0Zhjfc8JwdjzJUCv3qufkAu3OrSbim B/2CF7ovdpUwM/25yKj/JqlLSx3beDg7X0oCkJkOhAzuB0sGn//S75E71/eonDAXUr9d r8MPPsNoYWSkPSM9b0BmnDSdYmtGDbxCjdmtpZGatoj8yoL2QVX13g0+JxGiQ86pIZKG TywbC9iT2R/Is8MbF2o4C1X2FbzKLtl8d3Lac5j9/TwrqW9mW+dSIEuyyP+fyuzGy0uc dHiw== X-Gm-Message-State: AOJu0YyoBG+FThrQazKa9l4wQeDqqLOfbQ1pL7dkaHYEovysy2dOWJEQ wt7TRldcXd/uwyNEDtCH7vWYpyA++wi4HERBkWWGobMun3uzkxBazYi4C5Fk26AboqnJ4vhDaDr zz8byY3fuU/e3mJOZ9MM6hH997owLUMcsA1Kg2g== X-Google-Smtp-Source: AGHT+IHk7slsi+xYM2WEc2pbgK6tijheuKjOUimYXngzFUq3T/BgvPVrO4a7F+5hx0IhH9t0MQR2tk0arZeMcJZdbxQ= X-Received: by 2002:a17:90a:aa90:b0:2c1:9cd4:6665 with SMTP id 98e67ed59e1d1-2c2bcc647edmr361818a91.35.1717699990191; Thu, 06 Jun 2024 11:53:10 -0700 (PDT) MIME-Version: 1.0 References: <20240412111136.3470304-1-luca.vizzarro@arm.com> <20240606091718.151516-1-luca.vizzarro@arm.com> <20240606091718.151516-5-luca.vizzarro@arm.com> In-Reply-To: <20240606091718.151516-5-luca.vizzarro@arm.com> From: Jeremy Spewock Date: Thu, 6 Jun 2024 14:52:57 -0400 Message-ID: Subject: Re: [PATCH v4 4/5] dts: add `show port info` command to TestPmdShell To: Luca Vizzarro Cc: dev@dpdk.org, =?UTF-8?Q?Juraj_Linke=C5=A1?= , Paul Szczepanek Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jun 6, 2024 at 5:17=E2=80=AFAM Luca Vizzarro wrote: > > Add a new TestPmdPort data structure to represent the output > returned by `show port info`, which is implemented as part of > TestPmdShell. > > The TestPmdPort data structure and its derived classes are modelled > based on the relevant testpmd source code. > > This implementation makes extensive use of regular expressions, which > all parse individually. The rationale behind this is to lower the risk > of the testpmd output changing as part of development. Therefore > minimising breakage. > > Bugzilla ID: 1407 > > Signed-off-by: Luca Vizzarro > Reviewed-by: Paul Szczepanek Reviewed-by: Jeremy Spewock