From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 31EC745905; Wed, 4 Sep 2024 21:49:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0A33B427E9; Wed, 4 Sep 2024 21:49:33 +0200 (CEST) Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by mails.dpdk.org (Postfix) with ESMTP id 1823A427E5 for <dev@dpdk.org>; Wed, 4 Sep 2024 21:49:32 +0200 (CEST) Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-2d87176316eso889429a91.0 for <dev@dpdk.org>; Wed, 04 Sep 2024 12:49:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1725479371; x=1726084171; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=rYtvniRDUQuUHCkOlXxJ0UIWfz5UH0Bb5cjpAKj9zRw=; b=OkVHEyggaTAhTXt/8pogf/DhL90vv+tEzjCZvOGRHy7pLcUSUpFWtvysoPbCEhH23j 6xhUAtoZh0TjacaACvCw+FNfpkEav494qhGyrmsFELPUhTwePNOA6n9PQAj/xnJfvpcL 3dOjl6obRGEda54m3D2+5BoGbRamS0QGCTvVw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725479371; x=1726084171; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rYtvniRDUQuUHCkOlXxJ0UIWfz5UH0Bb5cjpAKj9zRw=; b=s0E/UVi85lwTKP0wij0FDjzrcoNh71nXwHfD5y6z7wTPAXGHRNM2P10iAbHPXr9M4N 2IoillErgss50JIdRyAarDFtHhSYdKbOP6CKVX3lPjEx3M8z2ZjUikEvhb4GEzA97M8J c6gAM7G/extS0wmWHJOTeDdM5canHapSunfYOalEAhKHSKpUo7Xiv1aGqHsRD+8YZnbx XzGQH0c060D3bMAQZRc/WdpET76rPK8XA7GGfQh/0372+rK/T6paNTKVYGlp83G3Uw56 NRhQacSiwyl06k8bpZKnasiz5bD8P5fjn7jTXW8B+0fe/MS/nQfYnjxKKVCFF32Vwcia Iu3w== X-Forwarded-Encrypted: i=1; AJvYcCVzCRvHxQmvTqUNZ6gBkHzNyi7mgGVmImVvz6Zg/qrR4byR7tEpdQllP4BF2b5pAe5rcfg=@dpdk.org X-Gm-Message-State: AOJu0YybDgFGPXWqlCO1Z0IE9POsjg5cwzdkSEquleNWS6bqVA8W1Ecl fawDie4V+nPk8V2AVENHtLEd4mIawrdfTV7HsnUvlSY+rTWBHPmhNHHwKtU+NPIz++7r5YvtxAR BZI1nyd2zK7H12bAn2Uak/NSddkPi1rCMd3hzyQ== X-Google-Smtp-Source: AGHT+IFHMKVEEqbV+SrSLfuFOTLC3g2KxGME5qkDZ/fsvPcARtwjwPepMwkt4/vPoQasAMqTOkYVa0wJuzcqidbCWmg= X-Received: by 2002:a17:90a:9205:b0:2d8:a943:87d1 with SMTP id 98e67ed59e1d1-2da8f2f4f4dmr5282855a91.13.1725479371334; Wed, 04 Sep 2024 12:49:31 -0700 (PDT) MIME-Version: 1.0 References: <20240807194341.26102-1-dmarx@iol.unh.edu> <20240823211637.30046-1-dmarx@iol.unh.edu> <20240823211637.30046-3-dmarx@iol.unh.edu> In-Reply-To: <20240823211637.30046-3-dmarx@iol.unh.edu> From: Jeremy Spewock <jspewock@iol.unh.edu> Date: Wed, 4 Sep 2024 15:49:19 -0400 Message-ID: <CAAA20USSCi40-D0ZRKBq3CTTGGDbFh-YRYB3YfU3tU6ksr05pg@mail.gmail.com> Subject: Re: [PATCH v14 2/2] dts: VLAN test suite implementation To: Dean Marx <dmarx@iol.unh.edu> Cc: probb@iol.unh.edu, npratte@iol.unh.edu, luca.vizzarro@arm.com, yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com, juraj.linkes@pantheon.tech, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org All looks great to me, thank you for the patch and addressing comments, there is just one comment that I left here about something that I missed pointing out on the previous version, but once that is addressed I think this will be ready. On Fri, Aug 23, 2024 at 5:16=E2=80=AFPM Dean Marx <dmarx@iol.unh.edu> wrote= : <snip> > + def send_packet_and_verify_insertion(self, expected_id: int) -> None= : > + """Generate a packet with no vlan tag, send and verify on the du= t. > + > + Args: > + expected_id: The vlan id that is being inserted through tx_o= ffload configuration. > + """ > + packet =3D Ether() / Raw(load=3D"xxxxx") > + received_packets =3D self.send_packet_and_capture(packet) > + test_packet =3D None > + for packet in received_packets: > + if b"xxxxx" in packet.load: Sorry, it looks like I missed putting a comment on this conditional in my last review, but we should probably also put a hasattr() check in here as well. > + test_packet =3D packet > + break > + self.verify(test_packet is not None, "Packet was dropped when it= should have been received") > + if test_packet is not None: > + self.verify(test_packet.haslayer(Dot1Q), "The received packe= t did not have a vlan tag") > + self.verify( > + test_packet.vlan =3D=3D expected_id, "The received tag d= id not match the expected tag" > + ) <snip> >