From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4BFC344180; Fri, 7 Jun 2024 15:11:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D7F4540151; Fri, 7 Jun 2024 15:11:04 +0200 (CEST) Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) by mails.dpdk.org (Postfix) with ESMTP id D590F40150 for ; Fri, 7 Jun 2024 15:11:03 +0200 (CEST) Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-6c4926bf9bbso1461022a12.2 for ; Fri, 07 Jun 2024 06:11:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1717765863; x=1718370663; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=bCwmOsLT9O64tLjhCnX5TgZSt9cApXfeITgI9uAz6Vs=; b=SMV7J8xK9jidl7zgV745XC7JFu4E0pZTatSgOTkvtLNvhSK+64klvvrjU6rPtLcLSc vCcje4V8OXiTnjpK0a1eTpMLg3zSrpPJPzzysUnp42P/3sVPRR9CvoVsJ2S7sBtN2E5N IW3q2kye+sDZzJytqff6LpxIA+cz6caasZHSw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717765863; x=1718370663; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bCwmOsLT9O64tLjhCnX5TgZSt9cApXfeITgI9uAz6Vs=; b=pMPx+3TbBPYGLSW7SQ+9+KK/Dji3hhdnHIDvSzoWF+uKRPvwOZS0wDONJ1lJHRzpbt Vby+ceVB5Xz+tEfYqWINpKpE4zOylP1SIYdXopJhU5qTzeTdIussgYuYFu1NCpL8tvOu U0d2Ji7lUCXkS0sBI2NEz6/P3qB49dY7HDlSdzpmRiPmg7gUJTbktuAc3JleO1ci2VRC OaKK91lHdhzsiA04mrKi+GVCkMRI2BBiBAfudsdhef7lgW2tCd5SPbARwzUs/nJuQmKR j1B/K9+Edf93QYOCzW8cBFEILW3brk3owthTRL1NWard0NIac0L7Q0SGq+PHeILx8GL4 NiQw== X-Gm-Message-State: AOJu0Ywcb9OIPKSjuc+9E2i6b1n3rpTBy7jVVjQH51JSeRff7mNMthVm rI/Lf1iLAEUvXt9rjNbbkgWOmyWdTNqKaoxjsomnZoMy21vQfeCohbHA6Tp/+/KZ9xOU/UEOEFF mt2f7J0Sf3wFpOgkkhlCbDgHH02W+7GM5HiE9ng== X-Google-Smtp-Source: AGHT+IHOtOKQ7JNFpLlctGATQ4rMoX85teVjQkATatNRn/HjhTFrX4w0ow0+iWJ1uojlWWApadglCvi94OsSCEGqMO4= X-Received: by 2002:a17:90a:5312:b0:2c2:c9b6:123a with SMTP id 98e67ed59e1d1-2c2c9b61449mr874525a91.4.1717765862698; Fri, 07 Jun 2024 06:11:02 -0700 (PDT) MIME-Version: 1.0 References: <20240412111136.3470304-1-luca.vizzarro@arm.com> <20240606213420.254260-1-luca.vizzarro@arm.com> <20240606213420.254260-2-luca.vizzarro@arm.com> In-Reply-To: <20240606213420.254260-2-luca.vizzarro@arm.com> From: Jeremy Spewock Date: Fri, 7 Jun 2024 09:10:51 -0400 Message-ID: Subject: Re: [PATCH v5 1/5] dts: fix InteractiveShell command prompt filtering To: Luca Vizzarro Cc: dev@dpdk.org, =?UTF-8?Q?Juraj_Linke=C5=A1?= , Paul Szczepanek Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jun 6, 2024 at 5:34=E2=80=AFPM Luca Vizzarro wrote: > > When sending a command using an instance of InteractiveShell the output > should filter out the trailing shell prompt when returning it. After > every command two shell prompts are summoned. One is consumed as it is > used as a delimiter for the command output. The second one is not > consumed and left for the next command to be sent. > > Given that the consumed prompt is merely a delimiter, this should not be > added to the returned output, as it may be mistakenly be interpreted as > the command's own output. > > Bugzilla ID: 1411 > Fixes: 88489c0501af ("dts: add smoke tests") > > Signed-off-by: Luca Vizzarro > Reviewed-by: Paul Szczepanek Reviewed-by: Jeremy Spewock