From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A2F34457BD; Mon, 26 Aug 2024 19:25:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9075F400EF; Mon, 26 Aug 2024 19:25:21 +0200 (CEST) Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by mails.dpdk.org (Postfix) with ESMTP id EF7804003C for ; Mon, 26 Aug 2024 19:25:20 +0200 (CEST) Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-714186ce2f2so3478686b3a.0 for ; Mon, 26 Aug 2024 10:25:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1724693120; x=1725297920; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Oesl/RNg36dcIWz/mu9JtcZdYFGGAqP1zqL9fJICJMQ=; b=Uyp/6yHushiY3PpXujabjeNbuv9uwVlj81sxqJ/t7FHt4TNLINmoDKGGDYhbGu8w0Z Xud87cZQoXRhEQBSlca/Leyovg1nu5fO4mQRBs/o2JDZ3k62wXks9XAoJVyEqN6pJcX3 rxOfxvhlk5kYd35/Mh/YsnqWyuuEqH1N5eW5g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724693120; x=1725297920; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Oesl/RNg36dcIWz/mu9JtcZdYFGGAqP1zqL9fJICJMQ=; b=XccdOnwv517o87B2h56nAPu9CGJnOXoASEzqQ8qZDUcFU/W0GYihDWuUXFT689vNhE CGkh0VgV6AlM4058hyUv0W8dE4Uo2GA76V2iPvB/M6k5819GltejRuzAEY4I50SeeVYx SCAJyLrrsZCdWMHixUHT2COmdSUwZq21kLCHYDcOVUwacC8YbZf0qESRAo8LW5sVK37E jUCF/l/ecRcqfr8geNWwczHzg981lDCP58fJtJYZIC25yckAsVjcd2eqybKA2/TMCB8u zUEshFv7nhVv6seqG/CpxNOtul21JaWNanXGoo4QkBjR0rfy9VqCeDM2ytfdEmW1Ix7O dwNw== X-Forwarded-Encrypted: i=1; AJvYcCV++3OfwS0yd4GnO7wzuFm3vw1n68uVhpqkO+G0ASiRBlY7BxC+DZHlLR/pBAnIE/pBn/I=@dpdk.org X-Gm-Message-State: AOJu0YzUP54XuY1mCq1g1WGVsQf/GUS0MbYCE7gEHssSRFpBVozr72Ev 9Qhdox5kic5AdebH6JM3GgJaN07ColJO45HfLlFt7Yi+ZuQMbx9K8vECeEsIlmlr9wivKJyKAm/ zgA+hFHmgiBj6LoqpC+U0/Y30hi7cMwAJCIsJAQ== X-Google-Smtp-Source: AGHT+IEKVaNWTBP/BpGkY087bH3anyE1k6ZTfl3dSuuIESxaDI0etqEeJVCrdfqcb9vtAsH8T29sXUzZXjnxNq2bSLc= X-Received: by 2002:a05:6a20:d497:b0:1ca:ccd0:582b with SMTP id adf61e73a8af0-1cc89d29eb6mr10308810637.10.1724693119868; Mon, 26 Aug 2024 10:25:19 -0700 (PDT) MIME-Version: 1.0 References: <20240301155416.96960-1-juraj.linkes@pantheon.tech> <20240821145315.97974-1-juraj.linkes@pantheon.tech> In-Reply-To: <20240821145315.97974-1-juraj.linkes@pantheon.tech> From: Jeremy Spewock Date: Mon, 26 Aug 2024 13:25:08 -0400 Message-ID: Subject: Re: [PATCH v3 00/12] dts: add test skipping based on capabilities To: =?UTF-8?Q?Juraj_Linke=C5=A1?= Cc: thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, probb@iol.unh.edu, paul.szczepanek@arm.com, Luca.Vizzarro@arm.com, npratte@iol.unh.edu, dmarx@iol.unh.edu, alex.chapman@arm.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hey Juraj, Thanks for the series! This is definitely a large shift in how the framework operates, but I think a lot of these changes are hugely helpful and the code is very well written in general. I left some comments mostly about places where I think some things could be a little more clear, and one about a functional difference that I think could be useful, but let me know what you think. Also, I tried to apply this patch to help with the review process but I couldn't get it to work. I think this is mainly due to the fact that this uses the MTU updating commit on main, and my version of that patch is far behind main right now, so we probably just resolved conflicts differently somehow. I will work on updating that series now and break the MTU patch into its own series to make it easier to use. Thanks, Jeremy