Re: [PATCH v2 5/5] dts: add testpmd set ports queues

[Jeremy Spewock <jspewock@iol.unh.edu>]

On Fri, Aug 9, 2024 at 11:14 AM Jeremy Spewock <jspewock@iol.unh.edu> wrote:
>
> > +
> > +        Raises:
> > +            InternalError: If `number_of` is invalid.
>
> I might be more in favor of this being an
> InteractiveCommandExecutionError or some other DTSError just to have a
> little more control over the error codes and to make it more clear
> that the error came specifically from the framework.

Sorry, I am just realizing this is a DTS error that you added two
months ago, this comment is invalid.

>
> > +        """
> > +        if number_of < 1:
> > +            raise InternalError("The number of queues must be positive and non-zero")
> > +
> > +        self.send_command(f"port config all rxq {number_of}")
> > +        self.send_command(f"port config all txq {number_of}")
> > +
> >      def show_port_info_all(self) -> list[TestPmdPort]:
> >          """Returns the information of all the ports.
> >
> > --
> > 2.34.1
> >