From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB69B45824; Tue, 20 Aug 2024 18:04:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7E6F3406B7; Tue, 20 Aug 2024 18:04:14 +0200 (CEST) Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by mails.dpdk.org (Postfix) with ESMTP id 05FFF4025F for ; Tue, 20 Aug 2024 18:04:14 +0200 (CEST) Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-2d439572aeaso1676344a91.1 for ; Tue, 20 Aug 2024 09:04:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1724169853; x=1724774653; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=A+NpBTIXXrVBC1qiZhnUr33/Qt1NhpiPLpQALKOmEHg=; b=eTyGEUawqITeB+UIJ2lHx7pzpR0fl4prPa+6Ie1/Gop3/BXmHOmeiteemtezb3EYpu j1xILKLBt1enjW252u2mAsMduZ6z+dodK5Pehr6X/+BcSVLaE/9YskG1FbFh433hh7L8 ic6jOqD2op8v+lkuroazFnCvyT3WrSxJlihEA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724169853; x=1724774653; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A+NpBTIXXrVBC1qiZhnUr33/Qt1NhpiPLpQALKOmEHg=; b=R0q//Jj4JeRMwvc/nZtVivmFHCB82e/o5v1zbAMlkrTVZefZEVKnNEU8EqGHWAhdvg 6ubu89Es8hOz1I/YPKhfClVT7eEVZwxAf4NXDebcwtAoKg2jKVSrF+ytW+QgWqeICu59 bI8wheLylFG3aisNbaUhZD1TpOG3JMEgVYZkABdRkjPrfxFNjKct8Ne6Izaas73AWX6U G6xzTZMXSr01k3JscxZYNVBVFidhg8UP/LevMwh3bMyx9BvU8sN9MP5D9WbV8rQ4p7Xc OBED4OLJZs1w3Ku/O7rZGIo589zKnUmpvgXDglI+wlkijYdYo0qVy2qtbx5HW0NGA5ox wp9A== X-Gm-Message-State: AOJu0Yx157gbQvRtA0gtW7BLm89cJ/yEmDT9PaF/BB4Gt4Med45qXgt6 PZ3z2vGat1mwkKNORKZTrSs/8ubN17elPCQsPpuv29w+VBJzOSZsxVLgvOeGyrwTyhE/EzAlgjx 8lzGK2mhisSNcGL3uii+IwtysWrr3xQJV8uF4Bg== X-Google-Smtp-Source: AGHT+IHNqWUpA+ZU0KtU/lyrofpxHKRA/1YqguAo+hNq2dVvHnPAXO7LjXz1xypTigomQjycjcHaKKhisVCqO1PViVI= X-Received: by 2002:a17:90a:f182:b0:2cf:f860:f13b with SMTP id 98e67ed59e1d1-2d4732ac56emr5500068a91.17.1724169852872; Tue, 20 Aug 2024 09:04:12 -0700 (PDT) MIME-Version: 1.0 References: <20240806121417.2567708-1-Luca.Vizzarro@arm.com> <20240806124642.2580828-1-luca.vizzarro@arm.com> <20240806124642.2580828-6-luca.vizzarro@arm.com> In-Reply-To: From: Jeremy Spewock Date: Tue, 20 Aug 2024 12:04:01 -0400 Message-ID: Subject: Re: [PATCH v2 5/5] dts: add testpmd set ports queues To: Luca Vizzarro Cc: dev@dpdk.org, =?UTF-8?Q?Juraj_Linke=C5=A1?= , Honnappa Nagarahalli , Paul Szczepanek Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Aug 9, 2024 at 11:14=E2=80=AFAM Jeremy Spewock wrote: > > > + > > + Raises: > > + InternalError: If `number_of` is invalid. > > I might be more in favor of this being an > InteractiveCommandExecutionError or some other DTSError just to have a > little more control over the error codes and to make it more clear > that the error came specifically from the framework. Sorry, I am just realizing this is a DTS error that you added two months ago, this comment is invalid. > > > + """ > > + if number_of < 1: > > + raise InternalError("The number of queues must be positive= and non-zero") > > + > > + self.send_command(f"port config all rxq {number_of}") > > + self.send_command(f"port config all txq {number_of}") > > + > > def show_port_info_all(self) -> list[TestPmdPort]: > > """Returns the information of all the ports. > > > > -- > > 2.34.1 > >