From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 719F444104; Wed, 29 May 2024 22:37:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3339940687; Wed, 29 May 2024 22:37:55 +0200 (CEST) Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by mails.dpdk.org (Postfix) with ESMTP id 2562340273 for <dev@dpdk.org>; Wed, 29 May 2024 22:37:54 +0200 (CEST) Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-2bfdae7997aso108148a91.2 for <dev@dpdk.org>; Wed, 29 May 2024 13:37:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1717015073; x=1717619873; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=F376XNzCWrD7YVDQdTItHXXXwHZQPRw4qD7Jv3g4cQg=; b=UfjI1Bovodfq/TTA4VoGcKeOpXfal4U7QXbyOEbuNUNW07np8fD3YzAwf5XzrDuNi2 RVyouwaI0J1o5oxDzoFAFyOBpjRA0gsOCMVTWb9O9Td5zOEBFlBzCsOpbdUIb6KYhYp3 7pTOmmF/SzUIOU2fK+0CHM0jRwIDQSmr5vWB0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717015073; x=1717619873; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=F376XNzCWrD7YVDQdTItHXXXwHZQPRw4qD7Jv3g4cQg=; b=n7nPzWx+aWnkFoWvvprMzBhI8KOLrv137Uv8yyk7r2mAkBU26b6zWmaOwXGl6H5WIk eSYiKExL50OkE2lGyKbqAX200FL+As++dLCEbCWy9kGQG2u08wdYuHoiZb2wnOontO3d SUbEIhXHkpQNJ8UDe4HxQ7uBKyEABv5VgdR1S5CYyRmAwSMan4dL6ORFE+aHpiBbD8Tg IS9lSQ1UyTnD76qkXNht850djG6shrf5yVrQC2oc8JjuC4rnc+tNZlhwrb7M6ZtK55Gf QJHOIOQo3s6kCNDBp42jDL5FPgI2+qnrM2j8KAN9RgbfUgtYFKqJl5lE/UPysMwFHxh1 2aQw== X-Forwarded-Encrypted: i=1; AJvYcCXyUaHOj/tsCxCoCMFRlEA/xOFPIsxy1xjUOjffdbU8tqEtvfQ+nn4Qb3RuSJEg1lUqIb7gFPaGOblgZCw= X-Gm-Message-State: AOJu0YxAX1F6Y709Sq5cehOeEu3moCOUfH6NjaREjiijMDaWhsnGcdAu vx5oOyrKz8Kw3fDK5RxriZEXYV7BsIpRRCDy9BWX1YkCEkcQVoLLZY+CmexSOlOtKBuwL7SyrMa 0npkVs/BRVNqHgJdzdJSD7o3Ly/6AF46eiHXF2w== X-Google-Smtp-Source: AGHT+IFL9x4paCSOiEj+vh4SUMkAMjnxP4ZcnBvu9B1hihMxsg5Cr7l/UHohzglsAhGaqKuyoL7bw6dmiS7t5/Kcaps= X-Received: by 2002:a17:90a:71c6:b0:2c1:a6e1:6a7 with SMTP id 98e67ed59e1d1-2c1abc40bf2mr210410a91.31.1717015073364; Wed, 29 May 2024 13:37:53 -0700 (PDT) MIME-Version: 1.0 References: <20240514201436.2496-1-jspewock@iol.unh.edu> <20240514201436.2496-3-jspewock@iol.unh.edu> <CAJvnSUBsrP8ffsd=swJyPdM_089jm1WSc-VTDG=Zf=HmujpqFQ@mail.gmail.com> In-Reply-To: <CAJvnSUBsrP8ffsd=swJyPdM_089jm1WSc-VTDG=Zf=HmujpqFQ@mail.gmail.com> From: Jeremy Spewock <jspewock@iol.unh.edu> Date: Wed, 29 May 2024 16:37:42 -0400 Message-ID: <CAAA20UT_Yft0xF7d-iwJjz=OrGOJPB+JendBCDVp7=DyhginmQ@mail.gmail.com> Subject: Re: [PATCH v1 2/4] dts: add context manager for interactive shells To: Patrick Robb <probb@iol.unh.edu> Cc: yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com, juraj.linkes@pantheon.tech, Luca.Vizzarro@arm.com, wathsala.vithanage@arm.com, thomas@monjalon.net, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Wed, May 22, 2024 at 9:53=E2=80=AFAM Patrick Robb <probb@iol.unh.edu> wr= ote: > > Reviewed-by: Patrick Robb <probb@iol.unh.edu> > > I don't have any comments beyond Luca's suggestions, but saw the typo bel= ow. > > On Tue, May 14, 2024 at 4:15=E2=80=AFPM <jspewock@iol.unh.edu> wrote: > > + def __exit__(self, type: BaseException, value: BaseException, trac= eback: TracebackType) -> None: > > + """Exit the context block. > > + > > + Upon exiting a context block with this class, we want to ensur= e that the instance of the > > + application is explicitly closed and properly cleaned up using= it's close method. Note that > > it's -> its > Ahh, this typo plagues me all over the place, I always add the apostrophe without thinking. Good catch.