From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9D9DE455D4; Wed, 10 Jul 2024 17:37:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5F35040E0A; Wed, 10 Jul 2024 17:37:03 +0200 (CEST) Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) by mails.dpdk.org (Postfix) with ESMTP id 50B0842D7A for <dev@dpdk.org>; Wed, 10 Jul 2024 17:37:02 +0200 (CEST) Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-7163489149eso4709898a12.1 for <dev@dpdk.org>; Wed, 10 Jul 2024 08:37:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1720625821; x=1721230621; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ZYF8YewRf2hjQxnkOBnlyvkUjzmNvM/2hDOXeonyIRo=; b=dqFM0XcRGtuGmivK3Ha5jipYs7K6wNAmAyXnmh6UwEbvd1NDa6rhvTMP4ANYMhvT4H 79DpGvJNfojMjwlMcMiVqgmOvKbRd0Vwc/LVm2d+2Hu66oMSx+zxSWoeV0oT6aBmrzke a56LMMhBpzkv1c5eQGa4g6TjGbBWHx/kqXonM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720625821; x=1721230621; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZYF8YewRf2hjQxnkOBnlyvkUjzmNvM/2hDOXeonyIRo=; b=e4QRr1XG91Ar7DMJf3wuqrktzvdkcPRUuVZ7LBW5QRJ8Cp0u5n1NHGsbeEuTS/zDbD BcH/hjyNI4oBv0Cpy1xvLIJqx3KS7J7wMXhesHhsj8Jgv2rHhTvQAaayjfGY9Wrjwjgm NoGVl7F/KMblL2PuArBvM9cA4jCrSWWqdHI/35hK/6+gBopPqvtXjh3N27OV/0if4MT+ Kahodz8GeiElqcesWxTdAfavJNbMYQWCAVf92goiXQ/FKR2gqgpFClPU/fd3lKv8a6Ae gqoiRha20Xa8IRfRcitwSPlwy+EZ9U4JBmJoZItfuwOetCkaCkK+WlSgI8vqzT0xyO85 PKkQ== X-Forwarded-Encrypted: i=1; AJvYcCU6E/V7m3BrM4gXrcpBLD5pKOZ9+zrFLPXW/zb+bzmviwb8oYSIB1n8xMhhLm3j0aVlfvKJngwT2SSQ/qg= X-Gm-Message-State: AOJu0Yyg02jautae5EsHQeQImq6bB1GDQL7DCXzRXrclGwgN+vYQsU6c S0rX7W6MA2Z4NnSupFPH/CcL6RMBKUDCWNWcLT78IC5wobOMzqQ5FJw3NmjjCH2przIUpcOxeY0 UPvl0agLh9RxA7s5xhDRQT5CrMUSQ2X1qh2MIVw== X-Google-Smtp-Source: AGHT+IE5/0NnCh+WscFpkgzEnNLWJoayWlQ41ijjeN/ugrjtk7BsbzEHqNQmI3Hj04Nhguto78aYn55VyfxWU5It+K0= X-Received: by 2002:a05:6a21:32a1:b0:1c0:e997:7081 with SMTP id adf61e73a8af0-1c29822cff8mr6753176637.29.1720625821087; Wed, 10 Jul 2024 08:37:01 -0700 (PDT) MIME-Version: 1.0 References: <20240617194638.12926-2-dmarx@iol.unh.edu> <20240703180820.18723-1-dmarx@iol.unh.edu> In-Reply-To: <20240703180820.18723-1-dmarx@iol.unh.edu> From: Jeremy Spewock <jspewock@iol.unh.edu> Date: Wed, 10 Jul 2024 11:36:49 -0400 Message-ID: <CAAA20UTeVrdyC5x7ufc4=P7FDE36dP0EdPP_PCEaM+2wLtQLLw@mail.gmail.com> Subject: Re: [PATCH v5 1/3] dts: add functions to testpmd shell To: Dean Marx <dmarx@iol.unh.edu> Cc: Honnappa.Nagarahalli@arm.com, juraj.linkes@pantheon.tech, probb@iol.unh.edu, paul.szczepanek@arm.com, yoan.picchi@foss.arm.com, bruce.richardson@intel.com, luca.vizzarro@arm.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org All of the code here looks good to me, if you end up putting in a new version for adding the comment that I mentioned on the other commit it might be worth changing the name of this commit again to something like add queue functions to testpmd, but I'm not sure this is super critical since you explain them in the body of the commit. Otherwise: Reviewed-by: Jeremy Spewock <jspewock@iol.unh.edu>