From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C765B440FA;
	Tue, 28 May 2024 23:08:17 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id AB6014064C;
	Tue, 28 May 2024 23:08:17 +0200 (CEST)
Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com
 [209.85.208.170])
 by mails.dpdk.org (Postfix) with ESMTP id 8FD0F4025D
 for <dev@dpdk.org>; Tue, 28 May 2024 23:08:15 +0200 (CEST)
Received: by mail-lj1-f170.google.com with SMTP id
 38308e7fff4ca-2e96f298fbdso13278991fa.1
 for <dev@dpdk.org>; Tue, 28 May 2024 14:08:15 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=iol.unh.edu; s=unh-iol; t=1716930495; x=1717535295; darn=dpdk.org;
 h=content-transfer-encoding:cc:to:subject:message-id:date:from
 :in-reply-to:references:mime-version:from:to:cc:subject:date
 :message-id:reply-to;
 bh=MKtvHr2q5Z5F/HoKXIkbCaWHapAx3H8+72syrf/XLVU=;
 b=PZkgVjRYxKWVfB/HSQHKp3ya9OJKonhJsJTYxzkJFjcWz6mAio81K/M7N2Th6n3Q5x
 Tr9aKcnf/SZpWKmNauWus5YP19H5+Uc/u9jahitPHdcI5o2JyxFTY05IvLqMvkbAXJkV
 9PzdamW9h4TaCItEpqHfsjh9Z+uALltAjiJH0=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1716930495; x=1717535295;
 h=content-transfer-encoding:cc:to:subject:message-id:date:from
 :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=MKtvHr2q5Z5F/HoKXIkbCaWHapAx3H8+72syrf/XLVU=;
 b=bJ7foZG6NwsILHb5iGOyuaGRw6baoSpLgQ0IV6SxSJZpwgl3jfyVtP+0r3/qU6gyb0
 sjzISI7hppeHieM3+NRPrriG9B70Id31V5hJeoTWog6G2EJfvAjn019AgAUC+0OJOnTr
 SRHn9atgibL1KIm60lZrU202W8Tjf03Qh4qXLI8OmTToyitNcWF9wLD4nw/TuRE9TAet
 2ove7Sq5piPPujBeafrpk47VaPkjdt7a5oInAFhKUQrTW5yDOPkAa5BRaqbzW7CqVpOY
 sEYvLc557W2cNEChF/aNewXcIAkrm+5VCFpTOBIH52S5YqEdA4/jfqpmX2i1NVHAtTmH
 PggQ==
X-Gm-Message-State: AOJu0Yx38FSJ44UKbxWjLQB+BfjOZeP06GbvdC4Co0B65eqEu6mK7C4e
 eB1BTNrc+sESRZhBhgh5I08iH7sn92IIMuifXNp/UWjnWqctsI6YLa9N0tLdBqL65sb+ZIU7J/5
 l3H63jNorjdkHH8OBhAvLlvG9XW0FJYVSM+CniQ==
X-Google-Smtp-Source: AGHT+IGKMsvxpVtWz8AYQhsCVF+RWvjrgwkKt7EeSqlMFzvebCubJ5R9vPcscwG8FOSGH6a1NM90NZnMx/VQmEukow0=
X-Received: by 2002:a2e:7014:0:b0:2ea:24db:d85b with SMTP id
 38308e7fff4ca-2ea24dbda4emr1716601fa.36.1716930495126; Tue, 28 May 2024
 14:08:15 -0700 (PDT)
MIME-Version: 1.0
References: <20240326190422.577028-1-luca.vizzarro@arm.com>
 <20240509112057.1167947-1-luca.vizzarro@arm.com>
 <20240509112057.1167947-2-luca.vizzarro@arm.com>
In-Reply-To: <20240509112057.1167947-2-luca.vizzarro@arm.com>
From: Jeremy Spewock <jspewock@iol.unh.edu>
Date: Tue, 28 May 2024 17:08:02 -0400
Message-ID: <CAAA20UTiv9EoHzbSXTyimtkY74PLg6e9Ryw6qD-YMKixxWPJXQ@mail.gmail.com>
Subject: Re: [PATCH v2 1/8] dts: add params manipulation module
To: Luca Vizzarro <luca.vizzarro@arm.com>
Cc: dev@dpdk.org, =?UTF-8?Q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech>, 
 Paul Szczepanek <paul.szczepanek@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

I think there was just one typo, otherwise:

Reviewed-by: Jeremy Spewock <jspewock@iol.unh.edu>

On Thu, May 9, 2024 at 7:21=E2=80=AFAM Luca Vizzarro <luca.vizzarro@arm.com=
> wrote:
>
> This commit introduces a new "params" module, which adds a new way
> to manage command line parameters. The provided Params dataclass
> is able to read the fields of its child class and produce a string
> representation to supply to the command line. Any data structure
> that is intended to represent command line parameters can inherit it.
>
> The main purpose is to make it easier to represent data structures that
> map to parameters. Aiding quicker development, while minimising code
> bloat.
>
> Signed-off-by: Luca Vizzarro <luca.vizzarro@arm.com>
> Reviewed-by: Paul Szczepanek <paul.szczepanek@arm.com>
> ---
<snip>
> +def comma_separated(values: Iterable[Any]) -> str:
> +    """Converts an iterable in a comma-separated string."""

I think this was meant to be "...an iterable into a comma-separated..."

> +    return ",".join([str(value).strip() for value in values if value is =
not None])
> +
> +
<snip>
> 2.34.1
>