From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B0EC743EC3; Tue, 16 Jul 2024 16:59:18 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 69AF640BA6; Tue, 16 Jul 2024 16:59:18 +0200 (CEST) Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by mails.dpdk.org (Postfix) with ESMTP id 84053406B4 for ; Tue, 16 Jul 2024 16:59:17 +0200 (CEST) Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-2c98a97d1ccso4734265a91.0 for ; Tue, 16 Jul 2024 07:59:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1721141956; x=1721746756; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=e6XEqduWbAGhH2WLWM+LQSBkY3YA48bX3YQoSuwjYwQ=; b=V604eylN8z8H70BDS0fcCoVS0N+TeFgG1s/mp8xWcUZ1ZIr+K9REU9ofU5bga4VE20 dYOHpHUThBFTwQhJ+TP3ni3ib6IB9Y11L1Rr/L0I+i1MiqP2DljGH9X4iVPL2rBNjxW5 w2HrZM4tAlKAA4oWWpcp+WL7NSmPlBq48N6hQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721141956; x=1721746756; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e6XEqduWbAGhH2WLWM+LQSBkY3YA48bX3YQoSuwjYwQ=; b=kYkxWVB7JKIw/citI2qVo0j50SgpC1Bp68Mf9c6UUyZK6Gf6owhfhBQXjXUK4IfGfM HqqNTzk5cn/U7yMayHu+RlLsVbXW1Xdzt379XahXYF9wBSRe15gqQspigwdWVqtNhD8L +sDRmX8CKVW6I2OX5Y16oXQ4KMRBhRQZSwqy7bqKyoiz4eyqE1fKe0wQBKxnMpn2tpGi 3+lcvFwEwApyoRXeziBPPwdd5oIyACydLdjBQ0W6in3PFEHVadD1Hgmt2Xrzz1V2hVHr CtPr0XP1N3vZlF2MVdVIQ7mL35pF6wdlbZYkNri04snW1HA2HQTqt89kwHKs3E7QGOnx n9sQ== X-Forwarded-Encrypted: i=1; AJvYcCW92ge78RR12stdsFzPqtprmsjS5VS6QBotwVCVcRxd+KRYOTus5HOuZWkYNkPCzfEU3JNDa241BLvdpks= X-Gm-Message-State: AOJu0Yx86l/kEAsRWwdnJ95+hae6ze1GpfRhEENrXgAG3CRFcpXY4fiv bdNWrVQv9558lHxZ6IS/LN/DZ2sW0ez3BKQ96d8qh2dXJH89L9xQp2ErfA4fuQP+Z5iM+eK/JvW TExK6Enf2f1f9U5BGQMaS0cKhAt9VaBghVPNMng== X-Google-Smtp-Source: AGHT+IG57+G93JCBslgp2PHDl24hqdbDRQhz4xDl0bNoKfDgQmdOU5FGChVNQvoMBnemyCe1lq8C9PxxOX0yL6UtogE= X-Received: by 2002:a17:90a:4417:b0:2c9:6a0e:6e66 with SMTP id 98e67ed59e1d1-2cb37dc910cmr3467629a91.5.1721141956452; Tue, 16 Jul 2024 07:59:16 -0700 (PDT) MIME-Version: 1.0 References: <20240613201831.9748-3-npratte@iol.unh.edu> <20240705171341.23894-12-npratte@iol.unh.edu> In-Reply-To: <20240705171341.23894-12-npratte@iol.unh.edu> From: Jeremy Spewock Date: Tue, 16 Jul 2024 10:59:04 -0400 Message-ID: Subject: Re: [PATCH v2 5/6] dts: add conditional behavior for test suite To: Nicholas Pratte Cc: probb@iol.unh.edu, dmarx@iol.unh.edu, luca.vizzarro@arm.com, yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com, juraj.linkes@pantheon.tech, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org I think it makes sense to allow users to not specify any test suites in the config file if they specify them through other means, so I like this change. On Fri, Jul 5, 2024 at 1:20=E2=80=AFPM Nicholas Pratte wrote: > > There is some odd functionality/behavior in how the --test-suite > parameters interacts in conjunction with the 'test_suites' attribute in > the config file. If a user leaves an empty list underneath > 'test_suites,' or if they negate the attribute entirely, even if said > user adds test suites via the --test-suite parameter, a schema violation > is thrown. > > This patch mitigates this, by removing the schema requirement if the > user has indicated test suites within main.py parameters, allowing for > the 'test_suites' attribute to be optional. > > Bugzilla ID: 1360 > Signed-off-by: Nicholas Pratte Reviewed-by: Jeremy Spewock