From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E841E440B7; Wed, 29 May 2024 19:12:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6E8D440273; Wed, 29 May 2024 19:12:11 +0200 (CEST) Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by mails.dpdk.org (Postfix) with ESMTP id 6F5694026F for ; Wed, 29 May 2024 19:12:10 +0200 (CEST) Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-6f850ff30c0so1890786b3a.0 for ; Wed, 29 May 2024 10:12:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1717002729; x=1717607529; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=4HbgBWiIpBFQwNViGNCKfdOcDlcaZ5CeWSxRJcpzves=; b=UgnaSmX80vo8L2TgEnDGaNCe6tVL1k38T0pnaeTZNVn7RBYpUXrYmIxwaUGZ2l33HC MjCDSGpvgbQKQ8DCIHd76XIP7Hhm6tZV/dUhq5ma50Ldd6JE10umVm8XMePeSUC1Gwul djOOr5TelmTsR8MU1xBSXabme3fvei6CbGCWc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717002729; x=1717607529; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4HbgBWiIpBFQwNViGNCKfdOcDlcaZ5CeWSxRJcpzves=; b=iGJ82T6LfS1AIcLudtj/wwXLWINICBSJP6H95DK9zeRiAwkTRFD8hfSAgFgdK+rSpW IEdBlCCLspG+3pd7MAOaef+NI14EkYcBNrjXrB/4x9uivMqJhXhybv5lCXSPyQfEthl1 58INaLHlFGu44/78SGFnWXU3fCrhu6APD0yJvFqOHVXRD/mRKZCamM+RRE2A0OdbB2yk 3WBIy34rsqMcg43ockmrwcSYtebeSFR6NgsvYy3SDpFSjThxEkjNZ3Jdl9J6feV/lVXV kqMfTP8QqiRyl9fP3+/rdqR8STn4i2yD5w2C1xJyhQt+a2LRnmqNwsBNFxmiaN7C4qsW 9V9Q== X-Gm-Message-State: AOJu0Yw52z7u8W6wHdh1YMLJyY8o2klazYnQ2b9q/h/AgJXP/gvkT9h6 hft5fnoSjMx8xSY7AT9tMiusxsZ1IIRnLOR/nlaNoR2vPURKB51bLVF43jpnv3oaxP5ZRUGaPQ1 jZ7G3a2VHF1k4tCHe3qACozNowcjMuC3BVX+5OA== X-Google-Smtp-Source: AGHT+IEKPsIdUOe9BOYB8YzEbBc62Nj3R/fiyUhGFYhhdkxyAxwH3UW9jheeCJAua1mpjifrTAC7SeIkhfPitfstT0A= X-Received: by 2002:a17:90a:a103:b0:2bf:e9cd:c858 with SMTP id 98e67ed59e1d1-2bfe9cdd3d3mr7314503a91.17.1717002729359; Wed, 29 May 2024 10:12:09 -0700 (PDT) MIME-Version: 1.0 References: <20240326190422.577028-1-luca.vizzarro@arm.com> <20240509112057.1167947-1-luca.vizzarro@arm.com> <20240509112057.1167947-6-luca.vizzarro@arm.com> <39ebf4c1-e4d2-4167-8c4e-5af101883f05@arm.com> In-Reply-To: <39ebf4c1-e4d2-4167-8c4e-5af101883f05@arm.com> From: Jeremy Spewock Date: Wed, 29 May 2024 13:11:57 -0400 Message-ID: Subject: Re: [PATCH v2 5/8] dts: add testpmd shell params To: Luca Vizzarro Cc: dev@dpdk.org, =?UTF-8?Q?Juraj_Linke=C5=A1?= , Paul Szczepanek Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, May 29, 2024 at 11:59=E2=80=AFAM Luca Vizzarro wrote: > > On 28/05/2024 22:05, Jeremy Spewock wrote: > > This looks good, the only comment I had was in some classes the > > docstrings didn't get updated to what was discussed previously in the > > comments (making sure the comments are included in the class' > > docstring). I tried to point out a few places where I noticed it. > > Apologies for asking again, as I may have totally missed them. Would you > be able to clarify or give examples to what you are referring to exactly? > > Will update the docstring format for the Enum class members. > Apologies for the confusion, all I was referring to were the Enum class members and the HairpinMode class.