From: Drocula <quzeyao@gmail.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] kni: fix build on RHEL 7.5
Date: Thu, 9 Aug 2018 18:25:00 +0800 [thread overview]
Message-ID: <CAACUTVxWTycbgt5ho7HM=Hszz0EkKz-serLH5pPk9aNMYDnnnw@mail.gmail.com> (raw)
In-Reply-To: <3508b463-304d-8d52-e793-9bfbce1cd18a@intel.com>
This patch Fix compilation errors on Centos 7.4 when
CONFIG_RTE_KNI_KMOD_ETHTOOL is set to 'y'.
On Thu, Aug 9, 2018, 17:59 Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> On 8/6/2018 1:06 PM, Drocula wrote:
> > Signed-off-by: Drocula <quzeyao@gmail.com>
>
> +1 for fixing build error, hence
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> But it would be better to have more detail on the build error, why and
> when this
> change required in RedHat side, it would be good if this information can
> make on
> time, but not I am for still getting the patch.
>
> Also we require "Name Surname" syntax for sign off, can you please provide
> this.
>
> Thanks,
> ferruh
>
next prev parent reply other threads:[~2018-08-09 10:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-06 12:06 Drocula
2018-08-09 9:59 ` Ferruh Yigit
2018-08-09 10:25 ` Drocula [this message]
2018-08-09 10:33 ` Drocula
2018-08-09 12:09 ` [dpdk-dev] [PATCH v2] " Drocula
2018-08-09 12:15 ` Ferruh Yigit
2018-08-09 14:10 ` Thomas Monjalon
2018-08-09 14:03 ` Thomas Monjalon
2018-08-09 17:10 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAACUTVxWTycbgt5ho7HM=Hszz0EkKz-serLH5pPk9aNMYDnnnw@mail.gmail.com' \
--to=quzeyao@gmail.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).