From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8ADFEA00C3; Tue, 14 Dec 2021 12:40:03 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 00CC4406A2; Tue, 14 Dec 2021 12:40:02 +0100 (CET) Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by mails.dpdk.org (Postfix) with ESMTP id 3558A40041 for ; Tue, 14 Dec 2021 12:40:00 +0100 (CET) Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 02BDF402FC for ; Tue, 14 Dec 2021 11:39:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1639482000; bh=BqVifm6wgWUIQYrS+9nY4nylOhi2YY+00JLHOtYcut0=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=Dm4wW5shGv+Y0QgEB7fnUUj5sMWRuBwr5dXo6X+POs9m8/IuYL+iEehmncoB4LDtd Vghc/CaHbIr/Ob19TyLcHibkvci+CrsPzFQGrTTwh4ebqNmPy+WhKNSj2v2QEJQ0Fq T8kRRz6ZMlxKZoH5b9vwVS09YU5yVRguHwyb9widx9BRdGNyerqieim0d2vWvCJO0Q 8DOWBA7jtiDZLBhU2kijoUbgmgnHiWBuZceMqdM7BqXB+wBOf4OOQlHtlEyG1GLRxy sbDNN/oGppFsy8w7IAidfEhWaxcpZd4g8QKg80S9cw8JhDrriP2MRL44i70XWfSmpG z/FvjcTBl2AhQ== Received: by mail-qt1-f197.google.com with SMTP id p7-20020ac84087000000b002b60be80b27so26301523qtl.18 for ; Tue, 14 Dec 2021 03:39:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BqVifm6wgWUIQYrS+9nY4nylOhi2YY+00JLHOtYcut0=; b=GYRJOK6ZRJgDQ5aHciMVUNsEspPE1zfb5uwcUbQRlnEuTxI/huHh2HyMbAmuyVj8WP 8dEcwBrUwYGdeC2hHaaCq44aymHWIYjWpwPvZmnZeNK8my4G3A73FE8d+H69AqLvPtOS xOKDkqcEVfozOfIlFV7p4/VIbanMsc81cJcNtrz1oErmdLcTkOR3JQJBUpWEpS65oqN3 pGu+FjnQArXkSy5CzYq1g391vDd1oBcVZ91p/CGMl0rQQlghE53ENS0p0hiz0s2Q9epc Z2kFgaCrz351S9Q3LyS+7xwOjRAUqVo8+EUt7wg/6MPaWDxr8Qld/Egn007IJrcBYKrR 8G9g== X-Gm-Message-State: AOAM531sGtxEzvpSsbtPXnthm5K3gweP5/+0W058SCB50fg2TjgH/0Ol GCS7SDQipNM7VKghVD47qZZKGiazN836K8SEbiJhs7px6o6uasmbtKnZJ3IkaOb2sO+QXyvCRW9 1dOS032Lkeouq9/k1wJHtMLDeEr1NOjXIUsoS X-Received: by 2002:ac8:5703:: with SMTP id 3mr5133427qtw.113.1639481998889; Tue, 14 Dec 2021 03:39:58 -0800 (PST) X-Google-Smtp-Source: ABdhPJyYbY8PMKejK1a/MbE+fW90qY3A+9YKkHi2/34NuYjbDK3HAeXPL00e1jQbLditCCuE3x0v3wOT4CKexZMeqv4= X-Received: by 2002:ac8:5703:: with SMTP id 3mr5133393qtw.113.1639481998636; Tue, 14 Dec 2021 03:39:58 -0800 (PST) MIME-Version: 1.0 References: <20211209144315.3424225-1-christian.ehrhardt@canonical.com> <7bf4583f-c2de-0aa7-fb00-bf3e9ff8d99b@intel.com> <34e0a9a8-327e-0150-b18a-dc3bfdca7d11@intel.com> <43d82514-b3e0-1bbd-1351-f1221bfc53db@intel.com> <5ac74587-4a18-3e0b-f674-73f927a11f95@intel.com> In-Reply-To: <5ac74587-4a18-3e0b-f674-73f927a11f95@intel.com> From: Christian Ehrhardt Date: Tue, 14 Dec 2021 12:39:32 +0100 Message-ID: Subject: Re: 19.11.11 patches review and test To: Ferruh Yigit Cc: Kalesh Anakkur Purayil , Abhishek Marathe , Akhil Goyal , Ali Alnubani , David Christensen , Hariprasad Govindharajan , Hemant Agrawal , Ian Stokes , Jerin Jacob , John McNamara , Ju-Hyoung Lee , Kevin Traynor , Luca Boccassi , Pei Zhang , Raslan Darawsheh , Thomas Monjalon , benjamin.walker@intel.com, dpdk stable , dpdk-dev , pingx.yu@intel.com, qian.q.xu@intel.com, yuan.peng@intel.com, zhaoyan.chen@intel.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Dec 14, 2021 at 11:13 AM Ferruh Yigit wrote: > > On 12/14/2021 7:44 AM, Christian Ehrhardt wrote: > > On Tue, Dec 14, 2021 at 6:49 AM Kalesh Anakkur Purayil > > wrote: > > > > [snip] > > > >>>> [Kalesh] Yes, i am seeing the same error. I used make command to build dpdk, not meson. > >>>> The back ported commit you mentioned takes care of meson build only I think. > >>>> > >>> > >>> I see, make build is failing, and yes the fix is only for the meson. > >>> I will check the make build and will send a fix for it. > >> > >> [Kalesh]: looks like the below changes fixes the issue. I tried only on SLES15 SP3 and not on other SLES flavors. > >> > >> diff --git a/kernel/linux/kni/Makefile b/kernel/linux/kni/Makefile > >> index 595bac2..bf0efab 100644 > >> --- a/kernel/linux/kni/Makefile > >> +++ b/kernel/linux/kni/Makefile > >> @@ -16,6 +16,16 @@ MODULE_CFLAGS += -I$(RTE_OUTPUT)/include > >> MODULE_CFLAGS += -include $(RTE_OUTPUT)/include/rte_config.h > >> MODULE_CFLAGS += -Wall -Werror > >> > >> +# > >> +# Use explicit 'source' folder for header path. In SUSE 'source' is not linked to 'build' folder. > >> +# > >> +ifdef CONFIG_SUSE_KERNEL > >> + KSRC = /lib/modules/$(shell uname -r)/source > >> + ifneq ($(shell grep -A 1 "ndo_tx_timeout" $(KSRC)/include/linux/netdevice.h | grep -o txqueue),) > >> + MODULE_CFLAGS += -DHAVE_TX_TIMEOUT_TXQUEUE > >> + endif > >> +endif > > > > Back in the day we tried various "is Suse and kernel version x.y" > > approaches, but they failed as there was no clear version throughout > > all of the Suse streams (leap, tumbleweed, sles) that worked well for > > all. > > This change here follows the upstream approach of "just check if it is there". > > > > I've applied this to 19.11 and did test builds across various distributions: > > 1. no non-suse build changed > > 2. suse builds stayed as-is or improved > > Formerly failing: > > openSUSE_Factory_ARM aarch64 > > SLE_15 x86_64 -> now working > > openSUSE_Leap_15.3 x86_64 -> now working > > openSUSE_Tumbleweed x86_64 -> still failing > > Formerly working: > > SLE_12_SP4 x86_64 ppc64le -> still fine > > openSUSE_Factory_ARM armv7l -> still fine > > openSUSE_Leap_15.2 x86_64 -> still fine > > > > Thanks Kalesh for the fix, and thanks Christian for testing. > > I was expecting this approach will fix all builds, after patch only > 'openSUSE_Tumbleweed' is failing, right? I will check it. As just discussed on IRC, yes and the log for that is at https://build.opensuse.org/package/live_build_log/home:cpaelzer:branches:home:bluca:dpdk/dpdk-19.11/openSUSE_Tumbleweed/x86_64 It also is affected by an issue around -Werror=implicit-fallthrough, so even with KNI fixed it likely is going to fail. > And I think you need the fix as a patch anyway, @Kalesh are you > planning to send the patch? I don't need it, as I have already grabbed and preliminary added it: https://github.com/cpaelzer/dpdk-stable-queue/commit/d43fa3e198c08a3a76d70f4565b31ad3ab5f29c4 But surely, once/If you come up with a full patch that also includes tumbleweed I can replace it with yours. > > Past fixes always "inverted" the result, by fixing some but breaking others. > > This new patch works in "not breaking any formerly working build" but > > at the same time fixing a few builds. > > Therefore -> applied & thanks! > > > > I'll likely tag -rc2 before the end of the week. > > The good thing is that (so far) we have: > > 1. a non functional change > > 2. a change fixing clang-13 builds (TBH only one of many needed clang13 issues) > > 3. a change fixing sles15SP3 builds > > > > Due to those, no current ongoing tests will have to be restarted. > > Whoever was able to build, can continue the current tests. > > Whoever was blocked by SLES15SP3 or clang-13 had no tests other than a > > failing build and can work with -rc2 then. > > I'll explain the same in the mail about -rc2. > > > >> -include /etc/lsb-release > >> > >> ifeq ($(DISTRIB_ID),Ubuntu) > >> > >> Regards, > >> Kalesh > > > > [snip] > > > -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd