From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A3CCEA0548; Fri, 3 Dec 2021 07:22:59 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 30A644014F; Fri, 3 Dec 2021 07:22:59 +0100 (CET) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mails.dpdk.org (Postfix) with ESMTP id E76BB40041 for ; Fri, 3 Dec 2021 07:22:57 +0100 (CET) Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id BEFFB3F1AE for ; Fri, 3 Dec 2021 06:22:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1638512577; bh=yo2J2YulDrTLPT4gS2wzb3wCnGxLtEtgjZHm7EQ62Ck=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=q+Td1rGxIhUAFP7olcOjWIOTVadrmGABMJ9cNf7Kw3wALYfsz9frfnCgvQVmdFo+P nIdffQGTx7ycVL2RYC4DBb74ixxhOd1LxFa9HzhkXVk+WZdxObHNNMxra5SqP/2fK3 Nxmsvo7EIhswO1JiOhBoU4pOsisl/Au/KjVNRi1hcQpKfKKpJfItGe2I61FmqK0+mX OXI5cV8oKUhk4rGJwg4Y7ZKCZCHL1+18HK2FxV1Etj/zrggqMjuoCvt82IrLAp+BnR Nd0KRsckZFka5CnWLYeu3YR7IBz45RMFhWAQ5r2l2jKWAKOczfsNLBL4+xL/lykeqJ 0XfrYOQufmHmA== Received: by mail-qk1-f200.google.com with SMTP id bi22-20020a05620a319600b00468606d7e7fso2340995qkb.10 for ; Thu, 02 Dec 2021 22:22:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yo2J2YulDrTLPT4gS2wzb3wCnGxLtEtgjZHm7EQ62Ck=; b=HJZ/CngzXJVtfHzQWegcSMbGtanoWouqsDdJxnzkgmEygr0bwy18RIF5+cYha17IUl QUMEq++FFKGhHnv7aoqtlaGsVpDZo0CR5EmgN6wbPRpOwIPOvtzcLHB1RRyu8PMGQyTT /zEV3HeXHwCbmqpsmPpoocAXse34OEkLzpW6y/scKjJ4vgEbvjCKwy03rEFb2juEWjH+ nkua5LVp5OB3LB4Zj6JNSB5Ecd/TquWxvsy+z77kW+yzBqlX3Eqodm13DvuAWxFELVC3 qzP08biMZJbjuBzMVTIfQbiZ3rYAXvJ4ktamFdg3Le/BQv5hS+2uEMmTKM1YQxaE/J7t xCng== X-Gm-Message-State: AOAM531lB85/sAIWKZhpc28PrkI86yCyR4ymsXLdErpS4kvGsceZKp3a ITUlkdq6aucqUepG3O4RzdF2PwzB10uX4DTaEeEbGRbE87ETcBgxAgO72l9wzH6aTQTq8w6wZfO WQCffKqeLumj614BelpKew/wa5nEF0yKNYqkn X-Received: by 2002:ac8:5aca:: with SMTP id d10mr19127467qtd.469.1638512576919; Thu, 02 Dec 2021 22:22:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJwHpcXRxp3T2ItugkZLyir/b4pe93u5DAD6YVZ+0E2CCbiuVfn6B95KbGEDuZoFwDzd4kgSRREckxu5WFPUtsw= X-Received: by 2002:ac8:5aca:: with SMTP id d10mr19127455qtd.469.1638512576734; Thu, 02 Dec 2021 22:22:56 -0800 (PST) MIME-Version: 1.0 References: <20211130165621.2467243-1-christian.ehrhardt@canonical.com> <2790f1a6-a391-4f1d-6149-d1342bf94104@redhat.com> In-Reply-To: <2790f1a6-a391-4f1d-6149-d1342bf94104@redhat.com> From: Christian Ehrhardt Date: Fri, 3 Dec 2021 07:22:31 +0100 Message-ID: Subject: Re: please help backporting some patches to stable release 19.11.11 To: Maxime Coquelin Cc: David Marchand , "stable@dpdk.org" , Chenbo Xia , "dev@dpdk.org" Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Dec 2, 2021 at 9:18 PM Maxime Coquelin wrote: > > Hi Christian, > > On 12/2/21 14:45, Christian Ehrhardt wrote: > > On Tue, Nov 30, 2021 at 5:56 PM wrote: > >> > >> Hi commit authors (and maintainers), > >> > >> Despite being selected by the DPDK maintenance tool ./devtools/git-log-fixes.sh > >> I didn't apply following commits from DPDK main to 19.11 > >> stable branch, as conflicts or build errors occur. > >> > >> Can authors check your patches in the following list and either: > >> - Backport your patches to the 19.11 branch, or > >> - Indicate that the patch should not be backported > >> > >> Please do either of the above by December the 14th 2021 (More time than > >> usual as backports get harder). > > > > Sorry, but to meet some deadlines by test/verification I need to reduce the > > time for backports to make it into -rc1 to the 9th of December. > > > > That still is 7 days out from now and still longer than usual. > > > > > >> You can find the a temporary work-in-progress branch of the coming 19.11.11 > >> release at: > >> https://github.com/cpaelzer/dpdk-stable-queue > >> It is recommended to backport on top of that to minimize further conflicts or > >> misunderstandings. > >> > >> Some notes on stable backports: > >> > >> A backport should contain a reference to the DPDK main branch commit > >> in it's commit message in the following fashion: > >> [ upstream commit ] > >> > >> For example: > >> https://git.dpdk.org/dpdk-stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb > >> > >> When sending the backported patch, please indicate the target branch in the > >> subject line, as we have multiple branches, for example: > >> [PATCH 19.11] foo/bar: fix baz > >> > >> With git format-patch, this can be achieved by appending the parameter: > >> --subject-prefix='PATCH 19.11' > >> > >> Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org". > >> > >> FYI, branch 19.11 is located at tree: > >> https://git.dpdk.org/dpdk-stable > >> > >> Thanks. > >> > >> Christian Ehrhardt > >> > >> --- > >> > > ... > > >> b72099be7f David Marchand net/virtio-user: fix init when using existing tap > This commit should not be backported. Hi Maxime, thanks for the info. > We deliberately omitted adding the Fixes tag and Cc'ing stable@dpdk.org > so that it is not automatically backported. The tooling by default also picks up anything that has "fix" in the subject. But I start realizing that nowadays the community is much better at properly using "Fixes:" and "stable@". And OTOH explaining the same to David just a few minutes ago makes me feel that we should probably remove those kind of patches from the automatic candidate list. > Regards, > Maxime > -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd