From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by dpdk.org (Postfix) with ESMTP id 2EA441B1EE for ; Wed, 14 Nov 2018 20:39:34 +0100 (CET) Received: from mail-ed1-f71.google.com ([209.85.208.71]) by youngberry.canonical.com with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1gN10g-00060i-1Y for dev@dpdk.org; Wed, 14 Nov 2018 19:39:34 +0000 Received: by mail-ed1-f71.google.com with SMTP id z7-v6so8904168edh.19 for ; Wed, 14 Nov 2018 11:39:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=/9XCViZMQhyX3G8ePVvzOyfI6EHlPNM3/45IL1ek9vU=; b=cnSykDuPdLsB3jbYjuyWq2YrKHOAkq28+y3UcZorBdeKLz0LayIQwetvcBVjlqJMQj MiBqAqWKzN/aNiUqE9ybLi6kljNJauBQH/35TITcRIv5QT2yxDfkbLTzQqQxBbkPwnxD YTlm+1lQaOiLbayGIeERXQ4uoS7Di9VuhBXDdfelo1ZMSnRp25QJziHrOscQQXuZPU/B hIlNjYKTuNnKzEKm5t8dC9ikLmSHZhP0Avu2eZ1R+lSn9UdvtjfX1IzZp/SYKnvfyPKX 0p/QSJu/N4dshUtlp9LWdXhPzDGlGXKsY8o8NO0doSU6in+s82ZW2r7U8pKn7e6kEpMS 9qMg== X-Gm-Message-State: AGRZ1gIbk3SF7PPoCR2ILpJSKBZKPotRR4dKmORaN0vF7U/g3O1juaDK t3X6OJQ1q7dyAJ4APKGIHFE0ubl+vvpRPc23JdQPb7Bo7nP7YwC86r3QKQ9f/o+KnzwoSFdpkmk BJKNwJnVWmhyvzvuau5Unb0+XaY0eVx5v0YRm X-Received: by 2002:a50:9315:: with SMTP id m21mr3208230eda.58.1542224373641; Wed, 14 Nov 2018 11:39:33 -0800 (PST) X-Google-Smtp-Source: AJdET5ehMXZV3bpGZ1BK3qgWnEoXxntGfhtDPVXt7lwGUTn3+hXzzo9Jg6ZEmL5GNiEcKMi3s9NzhlVsm0FJHfH2QXw= X-Received: by 2002:a50:9315:: with SMTP id m21mr3208221eda.58.1542224373278; Wed, 14 Nov 2018 11:39:33 -0800 (PST) MIME-Version: 1.0 References: <20181114135445.GA13408@bricha3-MOBL.ger.corp.intel.com> <20181114143315.2695-1-christian.ehrhardt@canonical.com> In-Reply-To: <20181114143315.2695-1-christian.ehrhardt@canonical.com> From: Christian Ehrhardt Date: Wed, 14 Nov 2018 20:39:06 +0100 Message-ID: To: Luca Boccassi , dev , Bruce Richardson Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3] build: establish an invariant machine type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Nov 2018 19:39:34 -0000 On Wed, Nov 14, 2018 at 3:33 PM Christian Ehrhardt wrote: > > Add the machine definition 'default' which is special compared > to 'native' (most optimized for current system) or any explicit > type (external entity has to decide on the type). > > It defaults to the per arch agreed common minimal baseline > needed for DPDK to reasonable work. > > That might not be the most optimized, but the most portable > version while still being able to support the CPU features > required for DPDK. > > Going forward this can be bumped up by the DPDK project, but it > can never be an invariant like 'native'. > > Distributions and other needing portable code are expected to > define the machine as 'default'. > > Changes in v2: > - fixed the non 64 bit arm default type > - changed baseline to default to match the old build system > > Changes in v3: > - add acked-by's > - removed old wording from commit message > - adding Fixes line per request by Luca Boccassi FYI: I'll drop the version update from the commit (I didn't have a cover letter to add them instead). Also I'll add the Acked-by of Luca to the other patch as well and move the Fixes line as it was meant for the 1/2 of these. Overall I think v4 will then be fine, all acks in place and hopefully making it in before -rc4 is defined to fix more peoples builds. Replying to this mail with both updated patches soon, let me know if anything else is holding these back from being accepted. > Fixes: 54d609a13876 ("build: add ppc64 meson build") > > Acked-by: Bruce Richardson > Acked-by: Luca Boccassi > Signed-off-by: Christian Ehrhardt > --- > config/meson.build | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/config/meson.build b/config/meson.build > index 1af305f46..db32499b3 100644 > --- a/config/meson.build > +++ b/config/meson.build > @@ -7,6 +7,27 @@ if meson.is_cross_build() > else > machine = get_option('machine') > endif > + > +# machine type 'default' is special, it defaults to the per arch agreed common > +# minimal baseline needed for DPDK. > +# That might not be the most optimized, but the most portable version while > +# still being able to support the CPU features required for DPDK. > +# This can be bumped up by the DPDK project, but it can never be an > +# invariant like 'native' > +if machine == 'default' > + if host_machine.cpu_family().startswith('x86') > + # matches the old pre-meson build systems default > + machine = 'corei7' > + elif host_machine.cpu_family().startswith('arm') > + machine = 'armv7-a' > + elif host_machine.cpu_family().startswith('aarch') > + # arm64 manages defaults in config/arm/meson.build > + machine = 'default' > + elif host_machine.cpu_family().startswith('ppc') > + machine = 'power8' > + endif > +endif > + > dpdk_conf.set('RTE_MACHINE', machine) > machine_args = [] > > -- > 2.17.1 > -- Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd