From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-f170.google.com (mail-ig0-f170.google.com [209.85.213.170]) by dpdk.org (Postfix) with ESMTP id CCA5B9420 for ; Mon, 7 Dec 2015 09:28:00 +0100 (CET) Received: by igvg19 with SMTP id g19so74046734igv.1 for ; Mon, 07 Dec 2015 00:28:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=mV2vJ4YEgJ5NOhtnwPU4Dqojs5pvS9pyOgDwUTO5kmc=; b=JuR2nOw3XFWbLjj0UuYDM1w9jMX/aWGZEf33El47gem9Nb0tWC0qow5j3NYywgj4+A +H+4QNH+2ljo2p3i4eS/8Cu/bO6TYG/670qEvzcO/r1tYeCM1kBYzL77djIsX6c5WU0f t11W6g/8jr+S8Wv8OAehfGrN0IyzeefiJvuUJi2TtTlG4bdjWs6v/KTf1TcMkbxnPBAI 7+r1/8vrHGidaUUg12QBveKpi4NyrcuM7AMaty4q3QSimUfimlSJcFSOPJ4EcflhLJrD uJHtt/I/oSEiaKJJeBoGu+QHY4Sw8mn3Ann1sljwfsotvZM1NNcDLpICIeGcLM73HRaM GoZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=mV2vJ4YEgJ5NOhtnwPU4Dqojs5pvS9pyOgDwUTO5kmc=; b=kUUsvq9YraapHFGq+v9fmqt7bjrJim+yAuBUnWLrVP3dOLqIwpw+YO8eutMS7iwrM8 P0RQ3d/v3QTioNeqVKltY5B0S7LrWWLV2qN+JgYbMi9zT2+fx2Hh3D1FxORMrTPV5Lj/ bwtjjdPIgbaQSIFB7/qVuE48IeX8VFUKc6uQ5cA08vdznJZVRbegOGllLuoPwHQzE2uF C6d1K+43cfkpu5qjMYh8JhwvOdDwKADPCD3ahn1eMmyzi4aMo5EmKTT5WviVM4fyiSta RSQdinSMCTSJihUuKifbdXTdqyUVJ8oOLyLJHPNQiqecdltu/hHbOW/Qyxfy3nYDpOoh uIFA== X-Gm-Message-State: ALoCoQlkFL1zEBB34F9dQlqoC0a7heGo3aelJ7EG3gv7Ai3Ux1yBqPqD1FPqkG03NHFjDPPSCyap0hMS6XXyl3KqxHPcPRtpkaQCY8ipEr6ddMk+zf9s+eo= X-Received: by 10.50.171.138 with SMTP id au10mr5159678igc.82.1449476880163; Mon, 07 Dec 2015 00:28:00 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.20.131 with HTTP; Mon, 7 Dec 2015 00:27:40 -0800 (PST) In-Reply-To: <3710593.RiARQgaut7@xps13> References: <079fa1cfc3550c8147ea8b137fa1bc0f34d051dc.1448375477.git.pmatilai@redhat.com> <3710593.RiARQgaut7@xps13> From: Christian Ehrhardt Date: Mon, 7 Dec 2015 09:27:40 +0100 Message-ID: To: Thomas Monjalon Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] mk: fix the combined library problems by replacing it with a linker script X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Dec 2015 08:28:01 -0000 Hi, FYI I kind of "gave up" (not as bad as it sounds) and started looking into shipping it as individual libraries + linker script as well. To me it seemed what was more accepted in all the former discussions. It will surely cause more work for me in the short term, but I hope after the initial hill I have to climb to make it happen it will be not too much in future releases. So if "we" were the only one causing this to be deferred consider it for 2.2. That way distributions would become more similar which might help consumers of the DPDK libraries. In the worst case I can reverse apply it for 2.2 to get some more time to get it to work properly for us later on. Looking at the great changes to "make install" by Thomas being in 2.2 - getting the linker script "official" in 2.2 as well would also help to not get a major overhaul to packaging every version :-) have a great week, Christian Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Fri, Dec 4, 2015 at 6:19 PM, Thomas Monjalon wrote: > 2015-11-24 16:31, Panu Matilainen: > > The physically linked-together combined library has been an increasing > > source of problems, as was predicted when library and symbol versioning > > was introduced. Replace the complex and fragile construction with a > > simple linker script which achieves the same without all the problems, > > remove the related kludges from eg mlx drivers. > > > > Since creating the linker script is practically zero cost, remove the > > config option and just create it always. > > > > Based on a patch by Sergio Gonzales Monroy, linker script approach > > initially suggested by Neil Horman. > > > > Suggested-by: Sergio Gonzalez Monroy > > Suggested-by: Neil Horman > > Signed-off-by: Panu Matilainen > > As it is a big change and discussion is not totally closed, > it is deferred to release 2.3. > The fix from Ferruh could be sufficient for 2.2. >