From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 6A213A2E1B
for <public@inbox.dpdk.org>; Wed, 4 Sep 2019 11:14:03 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 32E1B1EC6E;
Wed, 4 Sep 2019 11:14:03 +0200 (CEST)
Received: from youngberry.canonical.com (youngberry.canonical.com
[91.189.89.112]) by dpdk.org (Postfix) with ESMTP id ADEAD1E8D1
for <dev@dpdk.org>; Wed, 4 Sep 2019 11:14:02 +0200 (CEST)
Received: from mail-vs1-f69.google.com ([209.85.217.69])
by youngberry.canonical.com with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
(Exim 4.76) (envelope-from <christian.ehrhardt@canonical.com>)
id 1i5RMY-000258-AF for dev@dpdk.org; Wed, 04 Sep 2019 09:14:02 +0000
Received: by mail-vs1-f69.google.com with SMTP id q9so3209352vsj.0
for <dev@dpdk.org>; Wed, 04 Sep 2019 02:14:02 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=olToYLg43s7DgNoX52VU4FbsYyNRhZuXj9ZIQVg47KM=;
b=amMD9RcSDT+2TI9VUtNysmYoSvGgvqUvHHVQUvlVcTVRtnbRLuKjfbGy0XORSlqqaF
/dD5KfiHoJw1BYj5B1DCLgP9hl1tgW+egh6QpGxViNQMNl4Qr0tuhmM7AMnmvyWUmOts
wd7zg80wyOknkiv/XJXUvHp199YNcQyI01RA640DlIo/Y5/4odl5faEbzNQ3xwGVCskM
OqeRWHqk9J/JM/WSUeLbVMfhgZltYH9ymcblnZwktG4LXZswa9AL+99HPowCkqIHz3nr
cK00pmzbEq0Vhx0u8rfykeNMtly8JofQHx5YSb742yOGPQrf8Qpa1Tm6MkHc70MbdWuU
HTdw==
X-Gm-Message-State: APjAAAWfDrzWYSfms1ZySoGYITPzP6/ppaWnMzTAMV8og9oN03yUCcbj
1UNoM7jHz7Rssc3DSIn4GYv+v2IR8M3Luk1AhpZYjuiIAXZ/KIgdjNS1s+85hBsm46w5lhjTWqE
RrLy6BiFHg0xfnGy8BGA+5yX1zWaLAf1FT8CY
X-Received: by 2002:a67:60c5:: with SMTP id u188mr1793222vsb.153.1567588441473;
Wed, 04 Sep 2019 02:14:01 -0700 (PDT)
X-Google-Smtp-Source: APXvYqxS+2A/+pQd77fpzU1btPw9S/B0+KOSOuiyY6FbTEpJIQFjDTEZZS/J2k93H0JyBKmmyvJFXvgfJ9fjvj4zhl8=
X-Received: by 2002:a67:60c5:: with SMTP id u188mr1793213vsb.153.1567588441263;
Wed, 04 Sep 2019 02:14:01 -0700 (PDT)
MIME-Version: 1.0
References: <CAATJJ0KUN93UctTPeP_eH-k+UmtZSjqK-NJ9RWQGrtEswq5V2A@mail.gmail.com>
<20190829153003.7974-1-christian.ehrhardt@canonical.com>
<20190829153431.GA624@bricha3-MOBL.ger.corp.intel.com>
<dfa09a89e1a2cb61295659b00c315de2d77762b9.camel@debian.org>
<CAATJJ0KBVCxYpJcA8s2dkwXTDVKO3SFF+kLjaG0FJVqfcmA26g@mail.gmail.com>
In-Reply-To: <CAATJJ0KBVCxYpJcA8s2dkwXTDVKO3SFF+kLjaG0FJVqfcmA26g@mail.gmail.com>
From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Date: Wed, 4 Sep 2019 11:13:34 +0200
Message-ID: <CAATJJ0JcNder5ycE8q9utunLawqq0u6Mz2tE9W5-k3dUYtwp0w@mail.gmail.com>
To: Luca Boccassi <bluca@debian.org>
Cc: Bruce Richardson <bruce.richardson@intel.com>, dev <dev@dpdk.org>,
Kevin Laatz <kevin.laatz@intel.com>, Thomas Monjalon <thomas@monjalon.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH v2] build: avoid --as-needed as it causes
overlinking
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Mon, Sep 2, 2019 at 9:09 AM Christian Ehrhardt
<christian.ehrhardt@canonical.com> wrote:
>
> On Thu, Aug 29, 2019 at 6:02 PM Luca Boccassi <bluca@debian.org> wrote:
> >
> > On Thu, 2019-08-29 at 16:34 +0100, Bruce Richardson wrote:
> > > On Thu, Aug 29, 2019 at 05:30:03PM +0200, Christian Ehrhardt wrote:
> > > > A while ago telemetry was added in 57ae0ec6 and it also added as-
> > > > needed
> > > > to config/meson.build. This seems no more needed these days as due
> > > > to other
> > > > build changes the ordering in buildlogs is:
> > > > [...] -lrte_telemetry [...] -Wl,--no-as-needed [...]
> > > > Which means telemetry no more benefits from --no-as-needed anyway.
> > > >
> > > > Overlinking problems get triggered by the meson generated pkgconfig
> > > > which
> > > > will have:
> > > > [...] -Wl,--no-as-needed <somelibsusedbydpdk>
> > > > This will overlink <somelibs> and in addition anything that follows
> > > > as it also doesn't wrap back to --as-needed. So if a projects
> > > > includes
> > > > dpdk libs + <other> it will also consider <other> with --no-as-
> > > > needed.
> > > >
> > > > Fixes:
> > > > https://bugs.launchpad.net/ubuntu/+source/dpdk/+bug/1841759
> > > >
> > > >
> > > > Signed-off-by: Christian Ehrhardt <
> > > > christian.ehrhardt@canonical.com
> > > > >
> > > > Acked-by: Luca Boccassi <
> > > > bluca@debian.org
> > > > >
> > > > ---
> > > > config/meson.build | 1 -
> > > > 1 file changed, 1 deletion(-)
> > > >
> > > > diff --git a/config/meson.build b/config/meson.build
> > > > index 2bafea530..a27f731f8 100644
> > > > --- a/config/meson.build
> > > > +++ b/config/meson.build
> > > > @@ -94,7 +94,6 @@ dpdk_conf.set('RTE_TOOLCHAIN_' +
> > > > toolchain.to_upper(), 1)
> > > > dpdk_conf.set('RTE_ARCH_64', cc.sizeof('void *') == 8)
> > > >
> > > > add_project_link_arguments('-Wl,--no-as-needed', language: 'c')
> > > > -dpdk_extra_ldflags += '-Wl,--no-as-needed'
> > > >
> > >
> > > This seems strange to me. What is it about linking the dpdk apps that
> > > require the argument, but makes it safe for non-builtin apps to avoid
> > > having the arg?
> >
> > We've been wondering about that for a while :-) It also seems to be not
> > reproducible on Ubuntu 18.04/gcc 7.4.
> >
> > Can the verbose linking log be shared here, so that we can have a look
> > at where no-as-needed lands? Might provide some clue
>
> That would be the verbose linking log of the Travis CI run right?
> I currently have no idea which knob to turn to get this :-/
>
> Having it accepted in upstream would make it more easy to fix this in
> the soon to be released Ubuntu 19.10.
> Is there a path to consider taking this fix as-is and continue the
> debug/discussion how the removal of the second line can even cause the
> symptoms that we have seen later?
re-ping for the above ^^
> Or is everyone afraid that we then will not continue on it at all?
>
>
> > --
> > Kind regards,
> > Luca Boccassi
>
>
>
> --
> Christian Ehrhardt
> Software Engineer, Ubuntu Server
> Canonical Ltd
--
Christian Ehrhardt
Software Engineer, Ubuntu Server
Canonical Ltd