From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-f170.google.com (mail-ig0-f170.google.com [209.85.213.170]) by dpdk.org (Postfix) with ESMTP id 6F5483208 for ; Thu, 3 Dec 2015 07:56:53 +0100 (CET) Received: by igcto18 with SMTP id to18so5636195igc.0 for ; Wed, 02 Dec 2015 22:56:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=c8YBn6P+2tuwxsrDDIe+SbHQhdULeXMN1rRshCMHZ74=; b=GIO2SayJB9P1WwjDulJ3FjQQRsHAKBBgvNUOQc4LZAf+3ZeVQjpBzGD0XRAMAs4Ola MPQAasaBRXwJD8FUulMGoXiakupducycyXV5oMfrz3qVrHafBcx8QwVDrZTlzXbkSpYt /MkTqYoDIA/e1e4IAShHJcCY1U+BZNeqHrIw2oc13SsUCBO8VakB0oj3g77uC2tKKC/X mo1gVGfY9FH+9sjoy1itTHLYcc9q6eQDy5zKQI9hcL8c7JgY3UcQsQJM/xY9tqAAR9vX uDw0HjCAw0Z8RVrxOZefL/hjPLzxtUoX2wMIwe1dXQKwR1wWvr3jBiM42unv8fbxb0zm skOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=c8YBn6P+2tuwxsrDDIe+SbHQhdULeXMN1rRshCMHZ74=; b=VqIPScgJXH/YmnczzhqixdIuCEBOmENkU1YBqSi7olKpsJaialgg5B1jTKJSdA+13N hDl0esAxXAWZBqCiweKqOYdBt4cqSlK9/fZ5Nat4uFO9ZFNvPA3JQtf3yQ55q/Z7Yhgf BxXo7j0EKmotx25LIb+yu+9+boa+5IzbFiL4vepMlJdpcVtysUzQsy83Mdmb1+hkQgrk JHVxBAZEtp98dBaqJf9BCYRwMlr96E80d57w7hGwumKJ80R7+dz+jxpmfpKXG3aj5NLw EVH4B8dHzlzzei5JsUbqku/ythEQERbEHqEVTwjLp16lkVFfSqxqyomneb0Dq1wZJcJG AfUg== X-Gm-Message-State: ALoCoQk+oHBvmv0cWREGWGFrEhUDaFtvn0QZ0DmjWgWpGRl0FwfaWPOZbT7LhZVyN2UzJ4CkoxML X-Received: by 10.50.225.38 with SMTP id rh6mr36552253igc.13.1449125812769; Wed, 02 Dec 2015 22:56:52 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.20.131 with HTTP; Wed, 2 Dec 2015 22:56:33 -0800 (PST) In-Reply-To: <2898846.N9SNaCC8LE@xps13> References: <1449059922-10976-1-git-send-email-christian.ehrhardt@canonical.com> <2898846.N9SNaCC8LE@xps13> From: Christian Ehrhardt Date: Thu, 3 Dec 2015 07:56:33 +0100 Message-ID: To: Thomas Monjalon Content-Type: text/plain; charset=UTF-8 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] mk: Make XEN_PMD build in combined library mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Dec 2015 06:56:53 -0000 Hi Thomas, it was already after the --start-group before my patch, only guarded by the "ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),n)" I've had no opinion on being inside/outside the group. I just wanted to move it out of the "ifeq" which was not appropriate for the -lxenstore. I didn't want to cause any other semantic change, so I kept it inside the group. But you are right, looking at it without just focusing on the ifeq it makes more sense to move it out of the group as well. I'll resubmit a slightly modified version. Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Thu, Dec 3, 2015 at 12:14 AM, Thomas Monjalon wrote: > 2015-12-02 13:38, Christian Ehrhardt: >> Building RTE_LIBRTE_PMD_XENVIRT was broken when RTE_BUILD_COMBINE_LIBS was >> enabled (http://dpdk.org/ml/archives/dev/2015-November/028660.html). >> Now the underlying issue is rather simple, the xen code needs libxenstore. >> But rte.app.mk so far only considered that when RTE_BUILD_COMBINE_LIBS was >> disabled. >> While it is correct to create the DPDK sublib linking only in the >> RTE_BUILD_COMBINE_LIBS=n case, the libxenstore should be added to the linked >> libs in any case if RTE_LIBRTE_PMD_XENVIRT is enabled. > [...] >> --- a/mk/rte.app.mk >> +++ b/mk/rte.app.mk >> @@ -113,6 +113,7 @@ endif # ! CONFIG_RTE_BUILD_SHARED_LIBS >> _LDLIBS-$(CONFIG_RTE_LIBRTE_BNX2X_PMD) += -lz >> >> _LDLIBS-y += --start-group >> +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_XENVIRT) += -lxenstore > > Why is it moved after --start-group and not above as other dependencies? > >> ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),n) >