From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 67268A00C3; Tue, 14 Dec 2021 08:45:33 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4F3F740688; Tue, 14 Dec 2021 08:45:33 +0100 (CET) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mails.dpdk.org (Postfix) with ESMTP id 02FAD40042 for ; Tue, 14 Dec 2021 08:45:32 +0100 (CET) Received: from mail-il1-f199.google.com (mail-il1-f199.google.com [209.85.166.199]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id D19663F0EB for ; Tue, 14 Dec 2021 07:45:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1639467931; bh=2LScaXFUgFZN13JqBGMR+72y30aDeK9h5zP2UqF9+gE=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=mGcbpUiy9X9iyuYactu6rhA9YjqdxUZ6/0YocxoTrrKrFgWRZdEp3xXVnqk04ByRv KzfNjAX8x6Kl9c0qfdStNZX3f19XDUBtSAxIEEok26taGjhSQvCkRr8e30h97y0Jua Yjpu7lqEYzpzKLdgBD8jfrf0wlaw/SVAOk0FSeG0jWXRnb/jEEjHCE+hvRSCFbo4OK 5k5qhD+y2zximvcnbl00spIUHrR0NUr551+DoGJsQdiUWI1lVoCfADrxMBRAtgLxnZ Bzn/NZA2YewlHTHcxMAoJz49xv4Hhi6UEuARpPBelAOiPNEU0ISQjQ0IV0nXh2MPxV bb7O9zrT2+ViQ== Received: by mail-il1-f199.google.com with SMTP id h25-20020a056e021d9900b002a10123b5d0so16928721ila.22 for ; Mon, 13 Dec 2021 23:45:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2LScaXFUgFZN13JqBGMR+72y30aDeK9h5zP2UqF9+gE=; b=8FtTZwACA070PCevIASpoMyNpsEBOij/jPmIB9KjbPBQwYbRILY/HhGa4dIzNntgRc Uxlm52Ol2kUPX0q69eCj90tGVDYuhu87cLDr3WAidE08NhqdyNBlVrTSkSyzGEr39pWc U6S2Bs3YfGd5eoN4t/GTWj7YCtwYT1ciSoFf+uf5TDv2BjxpAO98wF+APnchmpVh9qjR tjUGk5aueFO4R5Ay68y+vqZAas9Ve3b0tBJsDXThackArU7aoCtNLHN0BhOl0WSeJT5V AmimcJ7kxO8m5P1dKwPudMyEharQ6eESXulcIYvvm9rq0IatsFcdiAxQccrU5DR/J2ry u++Q== X-Gm-Message-State: AOAM533qSH42Y4Ed7WMwQQXOanIDITpiIKhOvuI8N1sozv/011hLQ/NA PXxFm3UKCh1FF6HS1SJTY6t/8cxd/Pssmfxho5zMsjiHWrHg62cvlfAD2kDOyp4RPDj1/EWrVN4 Xw5htDnq9DGJi5Eqw/J3n739vLmIgh6rn0ED7 X-Received: by 2002:a05:620a:172c:: with SMTP id az44mr2790071qkb.93.1639467920101; Mon, 13 Dec 2021 23:45:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJytmhRDrPJGRjQ9wZt2og0O0o5Q05NtHrPXwzFAWVUbigeXG/k1cLx3Kf0hNuBlvXJBZBAhpJMBlX9lifGBwqI= X-Received: by 2002:a05:620a:172c:: with SMTP id az44mr2790030qkb.93.1639467919806; Mon, 13 Dec 2021 23:45:19 -0800 (PST) MIME-Version: 1.0 References: <20211209144315.3424225-1-christian.ehrhardt@canonical.com> <7bf4583f-c2de-0aa7-fb00-bf3e9ff8d99b@intel.com> <34e0a9a8-327e-0150-b18a-dc3bfdca7d11@intel.com> <43d82514-b3e0-1bbd-1351-f1221bfc53db@intel.com> In-Reply-To: From: Christian Ehrhardt Date: Tue, 14 Dec 2021 08:44:53 +0100 Message-ID: Subject: Re: 19.11.11 patches review and test To: Kalesh Anakkur Purayil Cc: Ferruh Yigit , Abhishek Marathe , Akhil Goyal , Ali Alnubani , David Christensen , Hariprasad Govindharajan , Hemant Agrawal , Ian Stokes , Jerin Jacob , John McNamara , Ju-Hyoung Lee , Kevin Traynor , Luca Boccassi , Pei Zhang , Raslan Darawsheh , Thomas Monjalon , benjamin.walker@intel.com, dpdk stable , dpdk-dev , pingx.yu@intel.com, qian.q.xu@intel.com, yuan.peng@intel.com, zhaoyan.chen@intel.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Dec 14, 2021 at 6:49 AM Kalesh Anakkur Purayil wrote: [snip] >> > [Kalesh] Yes, i am seeing the same error. I used make command to build dpdk, not meson. >> > The back ported commit you mentioned takes care of meson build only I think. >> > >> >> I see, make build is failing, and yes the fix is only for the meson. >> I will check the make build and will send a fix for it. > > [Kalesh]: looks like the below changes fixes the issue. I tried only on SLES15 SP3 and not on other SLES flavors. > > diff --git a/kernel/linux/kni/Makefile b/kernel/linux/kni/Makefile > index 595bac2..bf0efab 100644 > --- a/kernel/linux/kni/Makefile > +++ b/kernel/linux/kni/Makefile > @@ -16,6 +16,16 @@ MODULE_CFLAGS += -I$(RTE_OUTPUT)/include > MODULE_CFLAGS += -include $(RTE_OUTPUT)/include/rte_config.h > MODULE_CFLAGS += -Wall -Werror > > +# > +# Use explicit 'source' folder for header path. In SUSE 'source' is not linked to 'build' folder. > +# > +ifdef CONFIG_SUSE_KERNEL > + KSRC = /lib/modules/$(shell uname -r)/source > + ifneq ($(shell grep -A 1 "ndo_tx_timeout" $(KSRC)/include/linux/netdevice.h | grep -o txqueue),) > + MODULE_CFLAGS += -DHAVE_TX_TIMEOUT_TXQUEUE > + endif > +endif Back in the day we tried various "is Suse and kernel version x.y" approaches, but they failed as there was no clear version throughout all of the Suse streams (leap, tumbleweed, sles) that worked well for all. This change here follows the upstream approach of "just check if it is there". I've applied this to 19.11 and did test builds across various distributions: 1. no non-suse build changed 2. suse builds stayed as-is or improved Formerly failing: openSUSE_Factory_ARM aarch64 SLE_15 x86_64 -> now working openSUSE_Leap_15.3 x86_64 -> now working openSUSE_Tumbleweed x86_64 -> still failing Formerly working: SLE_12_SP4 x86_64 ppc64le -> still fine openSUSE_Factory_ARM armv7l -> still fine openSUSE_Leap_15.2 x86_64 -> still fine Past fixes always "inverted" the result, by fixing some but breaking others. This new patch works in "not breaking any formerly working build" but at the same time fixing a few builds. Therefore -> applied & thanks! I'll likely tag -rc2 before the end of the week. The good thing is that (so far) we have: 1. a non functional change 2. a change fixing clang-13 builds (TBH only one of many needed clang13 issues) 3. a change fixing sles15SP3 builds Due to those, no current ongoing tests will have to be restarted. Whoever was able to build, can continue the current tests. Whoever was blocked by SLES15SP3 or clang-13 had no tests other than a failing build and can work with -rc2 then. I'll explain the same in the mail about -rc2. > -include /etc/lsb-release > > ifeq ($(DISTRIB_ID),Ubuntu) > > Regards, > Kalesh [snip] -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd