From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by dpdk.org (Postfix) with ESMTP id 9850D152A for ; Tue, 31 Jul 2018 15:33:40 +0200 (CEST) Received: from mail-oi0-f69.google.com ([209.85.218.69]) by youngberry.canonical.com with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1fkUmS-0001Ky-E9 for dev@dpdk.org; Tue, 31 Jul 2018 13:33:40 +0000 Received: by mail-oi0-f69.google.com with SMTP id v205-v6so13807232oie.20 for ; Tue, 31 Jul 2018 06:33:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dIlVsZ+tHXmLG0NkB6hgbgqfjoB2zZJ/zXAYt/UfSv4=; b=ZZJ9DqdBVv4pRMmIOOcVQKwo2+eN5plXeMI2CMrob0JoLbn8bJfKYo7m1NQxh3Iwz2 t7cfm/KUbrzZTU4y1phaUi8fAdcqzJdOV3NIuoZIdzp9X/QSuzn52XXn79l2fwATfkvp d4FZRqVbWBeUvL4Mg5GCvsVpqnnpXbOSR9aOKp2eI6xmDMmoWaumoPeA+GXmjA+KVsW9 AI46izOc/1EKQwXlZrInIjA8PnPf18tPWVbn6zABtxkW/qxE0n//tzC7HOkCdno+cfsj I+2dezOAtw0uIS4NiYevvfuXH3HgsODadrrfNsub69G2dGYwTSOrRfZg4I/OfLdxAT3B JW8g== X-Gm-Message-State: AOUpUlG61H9vUFIovPH0/n8FdSDsKOXqxNjNqY1kZgAUdy5wE74qjLwr wK+TY+zKFbX8T0zH+kzOtDGg9dXx+sTOYrD7ad5Evem8QzILqjiA/B3Ml3YxiBkvZA/o6SxgJLx GwbkXnvY54c/SkjqTrPOc4HLiIb3qEdLDRU9J X-Received: by 2002:aca:3c02:: with SMTP id j2-v6mr23640534oia.50.1533044019474; Tue, 31 Jul 2018 06:33:39 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfTpXDHSn8dYihahhXGvmgbeIobXE6CIcHkDhijm6JFl8HgjSiyHKfADlTkGgutiE7PadZ+Mn3xeo0qil6jYf0= X-Received: by 2002:aca:3c02:: with SMTP id j2-v6mr23640508oia.50.1533044019248; Tue, 31 Jul 2018 06:33:39 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Christian Ehrhardt Date: Tue, 31 Jul 2018 15:33:13 +0200 Message-ID: To: "Timothy M. Redaelli" Cc: Shahaf Shuler , yskoh@mellanox.com, dev , adrien.mazarguil@6wind.com Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: Avoid stripping the glue library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Jul 2018 13:33:40 -0000 On Tue, Jul 31, 2018 at 3:27 PM Timothy Redaelli wrote: > Stripping binaries at build time is usually a bad thing since it makes > impossible to generate (split) debug symbols and this can lead to a more > difficult debugging. > > CC: Adrien Mazarguil > Fixes: 59b91bec12c6 ("net/mlx5: spawn rdma-core dependency plug-in") > > Signed-off-by: Timothy Redaelli > --- > drivers/net/mlx5/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/mlx5/Makefile b/drivers/net/mlx5/Makefile > index 75bee4640..2e70dec5b 100644 > --- a/drivers/net/mlx5/Makefile > +++ b/drivers/net/mlx5/Makefile > @@ -409,7 +409,7 @@ endif > $(LIB_GLUE): mlx5_glue.o > $Q $(LD) $(GLUE_LDFLAGS) $(EXTRA_LDFLAGS) \ > -Wl,-h,$(LIB_GLUE) \ > - -s -shared -o $@ $< -libverbs -lmlx5 > + -shared -o $@ $< -libverbs -lmlx5 > > mlx5_glue.o: mlx5_autoconf.h > After IRC discussion I completely agree that this shouldn't be stripped, thanks for the fix. Acked-by: Christian Ehrhardt > > -- > 2.17.1 > > -- Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd