From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
To: Luca Boccassi <bluca@debian.org>
Cc: dev <dev@dpdk.org>, Bruce Richardson <bruce.richardson@intel.com>,
pbhagavatula@caviumnetworks.com, jerin.jacob@caviumnetworks.com,
stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] build: set -mfpu=neon flag for armv7a builds
Date: Thu, 15 Nov 2018 20:29:30 +0100 [thread overview]
Message-ID: <CAATJJ0KZ1epyBbkr0rCiaAstELgBtcTVNPaw6zPPFBAMu-8cUQ@mail.gmail.com> (raw)
In-Reply-To: <20181115165418.25195-1-bluca@debian.org>
On Thu, Nov 15, 2018 at 5:54 PM Luca Boccassi <bluca@debian.org> wrote:
>
> Building on armv7a with meson currenctly fails:
>
> /usr/lib/gcc/arm-linux-gnueabihf/8/include/arm_neon.h:10369:1: error:
> inlining failed in call to always_inline ‘vld1q_s32’: target
> specific option mismatch
>
> Set -mfpu=neon on that architecture like the legacy makefiles do to fix
> the issue.
>
> Fixes: b1d48c41189a ("build: support ARM with meson")
> Cc: stable@dpdk.org
>
> Signed-off-by: Luca Boccassi <bluca@debian.org>
Acked-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> ---
> config/arm/meson.build | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index 4b23b3954..b75513855 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -89,6 +89,9 @@ if cc.sizeof('void *') != 8
> dpdk_conf.set('RTE_CACHE_LINE_SIZE', 64)
> dpdk_conf.set('RTE_ARCH_ARM', 1)
> dpdk_conf.set('RTE_ARCH_ARMv7', 1)
> + # the minimum architecture supported, armv7-a, needs the following,
> + # mk/machine/armv7a/rte.vars.mk sets it too
> + machine_args += '-mfpu=neon'
> else
> dpdk_conf.set('RTE_CACHE_LINE_SIZE', 128)
> dpdk_conf.set('RTE_ARCH_ARM64', 1)
> --
> 2.19.1
>
--
Christian Ehrhardt
Software Engineer, Ubuntu Server
Canonical Ltd
next prev parent reply other threads:[~2018-11-15 19:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 16:54 Luca Boccassi
2018-11-15 19:29 ` Christian Ehrhardt [this message]
2018-11-18 14:32 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAATJJ0KZ1epyBbkr0rCiaAstELgBtcTVNPaw6zPPFBAMu-8cUQ@mail.gmail.com \
--to=christian.ehrhardt@canonical.com \
--cc=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=pbhagavatula@caviumnetworks.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).