DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] build: set -mfpu=neon flag for armv7a builds
@ 2018-11-15 16:54 Luca Boccassi
  2018-11-15 19:29 ` Christian Ehrhardt
  0 siblings, 1 reply; 3+ messages in thread
From: Luca Boccassi @ 2018-11-15 16:54 UTC (permalink / raw)
  To: dev
  Cc: bruce.richardson, pbhagavatula, jerin.jacob, christian.ehrhardt,
	Luca Boccassi, stable

Building on armv7a with meson currenctly fails:

/usr/lib/gcc/arm-linux-gnueabihf/8/include/arm_neon.h:10369:1: error:
    inlining failed in call to always_inline ‘vld1q_s32’: target
    specific option mismatch

Set -mfpu=neon on that architecture like the legacy makefiles do to fix
the issue.

Fixes: b1d48c41189a ("build: support ARM with meson")
Cc: stable@dpdk.org

Signed-off-by: Luca Boccassi <bluca@debian.org>
---
 config/arm/meson.build | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/config/arm/meson.build b/config/arm/meson.build
index 4b23b3954..b75513855 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -89,6 +89,9 @@ if cc.sizeof('void *') != 8
 	dpdk_conf.set('RTE_CACHE_LINE_SIZE', 64)
 	dpdk_conf.set('RTE_ARCH_ARM', 1)
 	dpdk_conf.set('RTE_ARCH_ARMv7', 1)
+	# the minimum architecture supported, armv7-a, needs the following,
+	# mk/machine/armv7a/rte.vars.mk sets it too
+	machine_args += '-mfpu=neon'
 else
 	dpdk_conf.set('RTE_CACHE_LINE_SIZE', 128)
 	dpdk_conf.set('RTE_ARCH_ARM64', 1)
-- 
2.19.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] build: set -mfpu=neon flag for armv7a builds
  2018-11-15 16:54 [dpdk-dev] [PATCH] build: set -mfpu=neon flag for armv7a builds Luca Boccassi
@ 2018-11-15 19:29 ` Christian Ehrhardt
  2018-11-18 14:32   ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Christian Ehrhardt @ 2018-11-15 19:29 UTC (permalink / raw)
  To: Luca Boccassi; +Cc: dev, Bruce Richardson, pbhagavatula, jerin.jacob, stable

On Thu, Nov 15, 2018 at 5:54 PM Luca Boccassi <bluca@debian.org> wrote:
>
> Building on armv7a with meson currenctly fails:
>
> /usr/lib/gcc/arm-linux-gnueabihf/8/include/arm_neon.h:10369:1: error:
>     inlining failed in call to always_inline ‘vld1q_s32’: target
>     specific option mismatch
>
> Set -mfpu=neon on that architecture like the legacy makefiles do to fix
> the issue.
>
> Fixes: b1d48c41189a ("build: support ARM with meson")
> Cc: stable@dpdk.org
>
> Signed-off-by: Luca Boccassi <bluca@debian.org>

Acked-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>

> ---
>  config/arm/meson.build | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index 4b23b3954..b75513855 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -89,6 +89,9 @@ if cc.sizeof('void *') != 8
>         dpdk_conf.set('RTE_CACHE_LINE_SIZE', 64)
>         dpdk_conf.set('RTE_ARCH_ARM', 1)
>         dpdk_conf.set('RTE_ARCH_ARMv7', 1)
> +       # the minimum architecture supported, armv7-a, needs the following,
> +       # mk/machine/armv7a/rte.vars.mk sets it too
> +       machine_args += '-mfpu=neon'
>  else
>         dpdk_conf.set('RTE_CACHE_LINE_SIZE', 128)
>         dpdk_conf.set('RTE_ARCH_ARM64', 1)
> --
> 2.19.1
>


-- 
Christian Ehrhardt
Software Engineer, Ubuntu Server
Canonical Ltd

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] [PATCH] build: set -mfpu=neon flag for armv7a builds
  2018-11-15 19:29 ` Christian Ehrhardt
@ 2018-11-18 14:32   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2018-11-18 14:32 UTC (permalink / raw)
  To: Christian Ehrhardt
  Cc: stable, Luca Boccassi, dev, Bruce Richardson, pbhagavatula, jerin.jacob

15/11/2018 20:29, Christian Ehrhardt:
> On Thu, Nov 15, 2018 at 5:54 PM Luca Boccassi <bluca@debian.org> wrote:
> >
> > Building on armv7a with meson currenctly fails:
> >
> > /usr/lib/gcc/arm-linux-gnueabihf/8/include/arm_neon.h:10369:1: error:
> >     inlining failed in call to always_inline ‘vld1q_s32’: target
> >     specific option mismatch
> >
> > Set -mfpu=neon on that architecture like the legacy makefiles do to fix
> > the issue.
> >
> > Fixes: b1d48c41189a ("build: support ARM with meson")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Luca Boccassi <bluca@debian.org>
> 
> Acked-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-11-18 14:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-15 16:54 [dpdk-dev] [PATCH] build: set -mfpu=neon flag for armv7a builds Luca Boccassi
2018-11-15 19:29 ` Christian Ehrhardt
2018-11-18 14:32   ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git