From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D61654416A; Thu, 6 Jun 2024 15:26:49 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C14C340EE4; Thu, 6 Jun 2024 15:26:49 +0200 (CEST) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mails.dpdk.org (Postfix) with ESMTP id 064D340E96 for ; Thu, 6 Jun 2024 15:26:48 +0200 (CEST) Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id CE1C83F1AF for ; Thu, 6 Jun 2024 13:26:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1717680407; bh=7LmGhb7Gug+jfd76B89WyB6Fqloj2W5wKK33LfOO3S0=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=bV3LAjgYP57sItOx0IuYCsfMYpsyQECir9BR5JvCae0M4ZE6/fQU2t0cEoU6vVYZM jumzybcfCKv5jiM+qm11liv526HwHIbsA5YzhCsXCYsGIICiDPDkKCuayXonSSBUhl ZR+rUsh4EN5tM4jxJlB8LphNo/TYORTBgEYwZdjKtPzgwCOSN2Filp96kcjsnhhKzd SwTIbp5jvXwMk4encITgXt+b6PGoVULYk/fGTb2AKYb7q33KSfKZ05WrU2tSaWtyGs sbvURWE8CcNacHvxFlfSIiOA17WsxC/MWbh8zReV4AiidNyV7ILzbGBFiMzRSjwtKX Ota1eqAfP9POw== Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-2c1e9951604so854664a91.3 for ; Thu, 06 Jun 2024 06:26:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717680406; x=1718285206; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7LmGhb7Gug+jfd76B89WyB6Fqloj2W5wKK33LfOO3S0=; b=AaL93UoRduMc+Y5Kw6PGf3PvSSHtzhFzcVfRrsKx7Wq7pG7Z8lISO0UJJcnrPRE2t/ 2RQ0XjIOLU7KPYajLOR0adBM4xfmBKd3Je7+a+e4msVFSL26pRn2g5deKYySfBR8jJZ6 Q4Dms/f+1XQnHVeLnV+ekgt5EKUEa/nCQXdfPm+NG4JDLeHE1o5yHQBldB1A4jKsnIBv s5S/7DkRHsA0Uegjkf4iU7LpNrBbtkgfzXce1ipSLUBmUA1utTb1AcUmZyVETIjzYbES 7No79nSutLzWKJt4CqYOc2hc6dXcqpzWiuOLV7lRELJYQjltbfsoNjPKN04APd5yCqF5 sZmw== X-Gm-Message-State: AOJu0Yxe9wDzIfxX9wlGEfTyqCrS2J4M7DURijZDHfWDrLBSNqYnzWit dhKPC5XyQH6pxnR9P2756LOlVuSY6Tw33MvLG4TX271g98lTgeI+AITHqzL8BzaxBxPjXBRbFnI j0vWoMZ0i8DlxpFEpT0Re4DyVCEglE6sWnVr4UhqJu/w0R2U+rqKPXsOj/By4weiBUXBVxCcH43 8ClDzDgcsJXcS/rb5AgOITTVs29Ks9HgU= X-Received: by 2002:a17:90b:f8c:b0:2bd:fa57:b35c with SMTP id 98e67ed59e1d1-2c27db1b5d7mr5046112a91.28.1717680406386; Thu, 06 Jun 2024 06:26:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHVeCrEu9518lpEe1MdAkC9EyPzzc8LZa6BYY9fkk6nZew/HgUTDvXPzrY2NfMjNT3fLAEW6xmlrDKG745GgAs= X-Received: by 2002:a17:90b:f8c:b0:2bd:fa57:b35c with SMTP id 98e67ed59e1d1-2c27db1b5d7mr5046096a91.28.1717680406024; Thu, 06 Jun 2024 06:26:46 -0700 (PDT) MIME-Version: 1.0 References: <20240606122654.2889214-1-david.marchand@redhat.com> In-Reply-To: <20240606122654.2889214-1-david.marchand@redhat.com> From: Christian Ehrhardt Date: Thu, 6 Jun 2024 15:26:20 +0200 Message-ID: Subject: Re: [PATCH] telemetry: lower log level on socket error To: David Marchand Cc: dev@dpdk.org, stable@dpdk.org, Ciara Power , Chengwen Feng , Bruce Richardson , Shaowei Sun <1819846787@qq.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jun 6, 2024 at 2:27=E2=80=AFPM David Marchand wrote: > > When starting two DPDK programs using the same DPDK prefix (like for > example OVS and testpmd, both running as primary processes in > --in-memory mode), the first DPDK process of the two spews some error > log when the second starts: > > TELEMETRY: Socket write base info to client failed > > This is because telemetry init involves trying to connect on existing > sockets to check if it can take over an existing socket file. > > On the other hand, this error log provides no helpful information. > Lower this log to debug level. I agree, it is useful info in rare occasions, but not a "please consider having a panic" error level. Thank you for polishing all edges of this one issue that I raised originall= y! Signed-off-by: Christian Ehrhardt > Fixes: e14bb5f10509 ("telemetry: fix connected clients count") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand > --- > lib/telemetry/telemetry.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/telemetry/telemetry.c b/lib/telemetry/telemetry.c > index 1663bd8c68..509fae76ec 100644 > --- a/lib/telemetry/telemetry.c > +++ b/lib/telemetry/telemetry.c > @@ -382,7 +382,7 @@ client_handler(void *sock_id) > "{\"version\":\"%s\",\"pid\":%d,\"max_output_len\= ":%d}", > telemetry_version, getpid(), MAX_OUTPUT_LEN); > if (write(s, info_str, strlen(info_str)) < 0) { > - TMTY_LOG_LINE(ERR, "Socket write base info to client fail= ed"); > + TMTY_LOG_LINE(DEBUG, "Socket write base info to client fa= iled"); > goto exit; > } > > -- > 2.44.0 > --=20 Christian Ehrhardt Director of Engineering, Ubuntu Server Canonical Ltd