Re: [dpdk-dev] 19.11.7 patches review and test

[Christian Ehrhardt <christian.ehrhardt@canonical.com>]

On Thu, Mar 4, 2021 at 11:43 AM Yu, PingX <pingx.yu@intel.com> wrote:
>
> Update the test result for Intel part. Test are almost finished except cryptodev and 5 issues are found.
> 1. Failed build DPDK with "Make".
> 2. in tool usertools/dpdk-devbind.py: bind NIC port to DPDK failed
> 3. sriov_kvm: vf launch testpmd init failed on ixgbe.
> 4. userspace_ethtool/retrieve_eeprom: Dumped eeprom not same as linux dumped.
> 5. core dumped when run detach port command.
> 4 & 5 found in NIC CVL.

Thanks Yu, PingX ; Chen, Box C and anyone related for the great
testing and report!

> # Basic Intel(R) NIC testing
>   * Build or compile:
>        * Build: cover the build test combination with latest GCC/Clang/ICC version and the popular OS revision such as Ubuntu20.04, CentOS 8.3 , CentOS Stream 8, etc.
>              - All passed on meson build.
>              - Failed build DPDK with "Make". In latest DPDK test, we have moved to meson build, but in DPDK 19.11.7, still have some cryptdev build need to use Make.
>           Another, an issue in tool usertools/dpdk-devbind.py: bind NIC port to DPDK failed in vm(https://bugs.dpdk.org/show_bug.cgi?id=644). The root cause is in 19.11.7 only support python3.

=> Thanks for the report and analysis. I agree that we don't want to make it
python3 only on a stable update. For now I'll revert the change.
If wanted the Author (Yongxin Liu on CC now) can consider providing a
py2 compatible backport.

...

>   *VF(i40e,ixgbe and igb): test scenarios including VF-RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc..
>             - Done and 1 issue is found
>               Issue1: sriov_kvm: vf launch testpmd init failed on ixgbe. There is a patch to fix this issue but failed to apply to 19.11. Dev will rework the patch later.

 => Ok, just to confirm you have a developer right now working on this
to backport the fix.
As far as I understood the hints so far this is broken by
15cfb0bfc4968e8a9da49c07ee2e57c9cd947473
but I failed to see a reference to the to-be-backported fix yet -
could you mention what you'd need backported?
Is there any ETA for this backport, since due to the changes we will
need an extra round for 19.11.7-rc2 as well.

>   *PF/VF(ICE): test scenarios including /Switch features/Package Management/Flow Director/Advanced Tx/Advanced RSS/ACL/DCF/Share code update/Flexible Descriptor, etc.
>          - Done. 2 new issues are found. These are new added test cases. They also failed on 19.11.6. Intel are debugging on these issues.

Ok, since that was in the former release I'd ignore them for now.

...

>    * Cryptodev:
>           *Function test: test scenarios including Cryptodev API testing/CompressDev ISA-L/QAT/ZLIB PMD Testing/FIPS, etc.
>                 - 20%.
>           *Performance test: test scenarios including Thoughput Performance /Cryptodev Latency, etc.
>                 - 20%.

TBH - I've never had crypto HW to do this.
Is this a stable result between 19.11.6 -> 19.11.7?
If so any idea what we would need to look at?

> Regards,
> Yu, Ping
>
> > -----Original Message-----
> > From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> > Sent: Monday, February 22, 2021 11:59 PM
> > To: stable@dpdk.org
> > Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
> > Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>;
> > Walker, Benjamin <benjamin.walker@intel.com>; David Christensen
> > <drc@linux.vnet.ibm.com>; Govindharajan, Hariprasad
> > <hariprasad.govindharajan@intel.com>; Hemant Agrawal
> > <hemant.agrawal@nxp.com>; Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob
> > <jerinj@marvell.com>; Mcnamara, John <john.mcnamara@intel.com>; Ju-
> > Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>;
> > Luca Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Yu, PingX
> > <pingx.yu@intel.com>; Xu, Qian Q <qian.q.xu@intel.com>; Raslan Darawsheh
> > <rasland@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>; Peng,
> > Yuan <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>
> > Subject: 19.11.7 patches review and test
> >
> > Hi all,
> >
> > Here is a list of patches targeted for stable release 19.11.7.
> >
> > The planned date for the final release is 8th March.
> >
> > Please help with testing and validation of your use cases and report any
> > issues/results with reply-all to this mail. For the final release the fixes and
> > reported validations will be added to the release notes.
> >
> > A release candidate tarball can be found at:
> >
> >     https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.7-rc1
> >
> > These patches are located at branch 19.11 of dpdk-stable repo:
> >     https://git.dpdk.org/dpdk-stable/log/?h=19.11
> >
> > Thanks.
> >
> > Christian Ehrhardt <christian.ehrhardt@canonical.com>
> >
> > ---
> > Ajit Khaparde (1):
> >       net/bnxt: fix cleanup on mutex init failure
> >
> > Alvin Zhang (6):
> >       net/ixgbe: detect failed VF MTU set
> >       net/i40e: fix Rx bytes statistics
> >       net/i40e: fix returned code for RSS hardware failure
> >       net/ice: fix RSS lookup table initialization
> >       test: fix buffer overflow in Tx burst
> >       app/testpmd: fix key for RSS flow rule
> >
> > Anatoly Burakov (1):
> >       fbarray: fix overlap check
> >
> > Ankur Dwivedi (1):
> >       test/event_crypto: set cipher operation in transform
> >
> > Ashish Sadanandan (1):
> >       mbuf: add C++ include guard for dynamic fields header
> >
> > Balazs Nemeth (1):
> >       net/qede: fix promiscuous enable
> >
> > Beilei Xing (1):
> >       net/i40e: fix global register recovery
> >
> > Bernard Iremonger (1):
> >       doc: fix QinQ flow rules in testpmd guide
> >
> > Bruce Richardson (18):
> >       build: provide suitable error for "both" libraries option
> >       eal: fix reciprocal header include
> >       ethdev: fix missing header include
> >       rib: fix missing header includes
> >       ipsec: fix missing header include
> >       fib: fix missing header includes
> >       app: fix build with extra include paths
> >       power: create guest channel public header file
> >       power: make channel message functions public
> >       power: rename public structs
> >       power: rename constants
> >       power: clean up includes
> >       eal: fix MCS lock header include
> >       power: fix missing header includes
> >       rib: fix missing header include
> >       mbuf: fix missing header include
> >       power: export guest channel header file
> >       build: force pkg-config for dependency detection
> >
> > Chengchang Tang (5):
> >       net/hns3: fix register length when dumping registers
> >       net/hns3: fix data overwriting during register dump
> >       net/hns3: fix dump register out of range
> >       net/hns3: fix firmware exceptions by concurrent commands
> >       net/hns3: fix VF reset on mailbox failure
> >
> > Chengwen Feng (3):
> >       net/hns3: fix VF query link status in dev init
> >       net/hns3: remove MPLS from supported flow items
> >       net/hns3: fix flow director rule residue on malloc failure
> >
> > Ciara Power (3):
> >       app/crypto-perf: fix spelling in output
> >       app/crypto-perf: fix latency CSV output
> >       app/crypto-perf: fix CSV output format
> >
> > Dapeng Yu (4):
> >       net/ixgbe: fix flex bytes flow director rule
> >       net/ice: check Rx queue number on RSS init
> >       net/ixgbe: disable NFS filtering
> >       app/testpmd: avoid exit without terminal restore
> >
> > Dmitry Kozlyuk (1):
> >       build: fix linker flags on Windows
> >
> > Fei Chen (1):
> >       vhost: fix vid allocation race
> >
> > Feifei Wang (10):
> >       app/eventdev: adjust event count order for pipeline test
> >       app/eventdev: remove redundant enqueue in burst Tx
> >       examples/eventdev: add info output for main core
> >       app/eventdev: fix SMP barrier in performance test
> >       examples/eventdev: check CPU core enabling
> >       examples/eventdev: move ethdev stop to the end
> >       net/ixgbe: add new flag of stripped VLAN for NEON
> >       net/ixgbe: support bad checksum flag for NEON
> >       net/ixgbe: support good checksum flag for NEON
> >       net/ixgbe: enable IXGBE NEON vector PMD when CHECKSUM need to
> > checksum
> >
> > Ferruh Yigit (11):
> >       app/procinfo: fix _filters stats reporting
> >       app/procinfo: fix check on xstats-ids
> >       app/procinfo: remove useless memset
> >       net/pcap: remove local variable shadowing outer one
> >       net/bonding: remove local variable shadowing outer one
> >       net/af_xdp: remove useless assignment
> >       app/crypto-perf: remove always true condition
> >       net/avp: remove always true condition
> >       net/pcap: fix byte stats for drop Tx
> >       net/pcap: fix infinite Rx with large files
> >       app/testpmd: fix help of metering commands
> >
> > Gaetan Rivet (2):
> >       net/bonding: fix port id validity check on parsing
> >       net/bonding: fix PCI address comparison on non-PCI ports
> >
> > Gagandeep Singh (2):
> >       test/ipsec: fix result code for not supported
> >       crypto/dpaa2_sec: fix memory allocation check
> >
> > George Prekas (1):
> >       app/testpmd: fix IP checksum calculation
> >
> > Gregory Etelson (1):
> >       app/testpmd: release flows left before port stop
> >
> > Haiyue Wang (1):
> >       net/ixgbe: fix UDP zero checksum on x86
> >
> > Harman Kalra (1):
> >       examples/l3fwd: remove limitation on Tx queue count
> >
> > Harry van Haaren (1):
> >       eventdev: fix a return value comment
> >
> > Heinrich Kuhn (1):
> >       net/nfp: read chip model from PluDevice register
> >
> > Hongbo Zheng (1):
> >       net/hns3: use new opcode for clearing hardware resource
> >
> > Huisong Li (4):
> >       net/hns3: fix error code in xstats
> >       net/hns3: validate requested maximum Rx frame length
> >       net/hns3: fix Rx/Tx errors stats
> >       net/hns3: fix xstats with id and names
> >
> > Hyong Youb Kim (2):
> >       net/enic: fix filter type used for flow API
> >       net/enic: fix filter log message
> >
> > Ido Segev (1):
> >       net/ena: flush Rx buffers memory pool cache
> >
> > Igor Ryzhov (1):
> >       net/i40e: fix stats counters
> >
> > Ivan Malov (1):
> >       net/sfc: fix TSO and checksum offloads for EF10
> >
> > Jiawei Wang (1):
> >       app/testpmd: fix packets dump overlapping
> >
> > Jiawei Zhu (1):
> >       net/virtio-user: fix run closing stdin and close callfd
> >
> > Jingjing Wu (1):
> >       net/iavf: fix vector mapping with queue
> >
> > Joyce Kong (1):
> >       eal/arm: fix debug build with gcc for 128-bit atomics
> >
> > Kalesh AP (4):
> >       net/bnxt: release HWRM lock in error
> >       net/bnxt: propagate FW command failure to application
> >       net/bnxt: fix VNIC RSS configure function
> >       net/bnxt: fix FW version log
> >
> > Lance Richardson (5):
> >       net/bnxt: disable end of packet padding for Rx
> >       net/bnxt: fix null termination of Rx mbuf chain
> >       net/bnxt: fix doorbell write ordering
> >       net/bnxt: fix fallback mbuf allocation logic
> >       net/bnxt: fix outer UDP checksum Rx offload capability
> >
> > Leyi Rong (1):
> >       net/ice: enlarge Rx queue rearm threshold to 64
> >
> > Li Feng (1):
> >       mem: exclude unused memory from core dump
> >
> > Lijun Ou (4):
> >       net/hns3: fix interception with flow director
> >       net/hns3: adjust format specifier for enum
> >       net/hns3: fix memory leak on secondary process exit
> >       doc: fix product link in hns3 guide
> >
> > Liron Himi (5):
> >       net/octeontx2: fix PF flow action for Tx
> >       net/mvpp2: remove debug log on fast-path
> >       net/mvpp2: remove VLAN flush
> >       net/mvpp2: remove CRC length from MRU validation
> >       net/mvpp2: fix frame size checking
> >
> > Long Li (1):
> >       net/netvsc: ignore unsupported packet on sync command
> >
> > Lukasz Wojciechowski (1):
> >       test/distributor: fix return buffer queue overload
> >
> > Marvin Liu (1):
> >       vhost: fix packed ring dequeue offloading
> >
> > Michael Baum (3):
> >       net/mlx4: fix handling of probing failure
> >       net/mlx5: fix leak on Rx queue creation failure
> >       net/mlx5: fix leak on Tx queue creation failure
> >
> > Murphy Yang (5):
> >       net/ice: fix outer UDP Tx checksum offload
> >       net/i40e: fix L4 checksum flag
> >       net/ice: disable IPv4 checksum offload in vector Tx
> >       net/i40e: add null input checks
> >       net/ice: fix outer checksum flags
> >
> > Olivier Matz (3):
> >       test/mcslock: remove unneeded per lcore copy
> >       build: fix plugin load on static build
> >       mempool: fix panic on dump or audit
> >
> > Qi Zhang (3):
> >       net/ice/base: fix tunnel destroy
> >       net/ice/base: fix null pointer dereference
> >       net/ice/base: fix memory handling
> >
> > Ruifeng Wang (3):
> >       lpm: fix vector IPv4 lookup
> >       net/octeontx: fix build with SVE
> >       common/octeontx2: fix build with SVE
> >
> > Samik Gupta (2):
> >       net/bnxt: fix Rx rings in RSS redirection table
> >       net/bnxt: fix VNIC config on Rx queue stop
> >
> > Shiri Kuzin (2):
> >       net/mlx5: refuse empty VLAN in flow pattern
> >       net/mlx5: fix VXLAN decap on non-VXLAN flow
> >
> > Souvik Dey (1):
> >       net/i40e: fix VLAN stripping in VF
> >
> > Sriharsha Basavapatna (1):
> >       net/bnxt: fix max rings computation
> >
> > Stephen Hemminger (1):
> >       test: fix terminal settings on exit
> >
> > Steve Yang (20):
> >       ethdev: fix max Rx packet length check
> >       app/testpmd: fix max Rx packet length for VLAN packets
> >       net/dpaa: fix jumbo frame flag condition for MTU set
> >       net/e1000: fix jumbo frame flag condition for MTU set
> >       net/hns3: fix jumbo frame flag condition for MTU set
> >       net/i40e: fix jumbo frame flag condition
> >       net/iavf: fix jumbo frame flag condition
> >       net/ipn3ke: fix jumbo frame flag condition for MTU set
> >       net/octeontx2: fix jumbo frame flag condition for MTU
> >       net/qede: fix jumbo frame flag condition for MTU set
> >       net/sfc: fix jumbo frame flag condition for MTU set
> >       net/thunderx: fix jumbo frame flag condition for MTU set
> >       net/cxgbe: fix jumbo frame flag condition
> >       net/enetc: fix jumbo frame flag condition for MTU set
> >       net/nfp: fix jumbo frame flag condition for MTU set
> >       net/liquidio: fix jumbo frame flag condition for MTU set
> >       net/dpaa2: fix jumbo frame flag condition for MTU set
> >       app/testpmd: fix setting maximum packet length
> >       net/ice: fix jumbo frame flag condition
> >       net/ixgbe: fix jumbo frame flag condition
> >
> > Suanming Mou (3):
> >       net/mlx4: fix port attach in secondary process
> >       net/mlx5: fix crash on secondary process port close
> >       net/mlx5: fix port attach in secondary process
> >
> > Sunil Kumar Kori (1):
> >       net/octeontx2: fix corruption in segments list
> >
> > Tal Shnaiderman (2):
> >       common/mlx5: fix pointer cast on Windows
> >       net/mlx5: fix comparison sign in flow engine
> >
> > Thomas Monjalon (1):
> >       mem: fix build
> >
> > Viacheslav Galaktionov (1):
> >       net/sfc: fix generic byte statistics to exclude FCS bytes
> >
> > Viacheslav Ovsiienko (2):
> >       doc: update flow mark action in mlx5 guide
> >       doc: fix mark action zero value in mlx5 guide
> >
> > Vladimir Medvedkin (1):
> >       rib: fix insertion in some cases
> >
> > Weifeng Li (1):
> >       net/i40e: fix X722 for 802.1ad frames ability
> >
> > Wenjun Wu (1):
> >       net/e1000: fix flow control mode setting
> >
> > Yicai Lu (1):
> >       ip_frag: remove padding length of fragment
> >
> > Yongxin Liu (1):
> >       usertools: fix binding built-in kernel driver
> >
> > Yunjian Wang (3):
> >       eal/linux: fix handling of error events from epoll
> >       net/bnxt: fix memory leak when mapping fails
> >       net/mvneta: check allocation in Rx queue flush
> >
> > Yuri Chipchev (1):
> >       net/mvpp2: fix stack corruption



-- 
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd