From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-f182.google.com (mail-qt0-f182.google.com [209.85.216.182]) by dpdk.org (Postfix) with ESMTP id 6EFE9558D for ; Mon, 13 Jun 2016 17:10:14 +0200 (CEST) Received: by mail-qt0-f182.google.com with SMTP id 9so35740243qtg.2 for ; Mon, 13 Jun 2016 08:10:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=UJeWa40HnNep2dU9sknm7tvZyoEh3b2bGd2IuYRImiY=; b=ioiC3oK6Uy5SeYe6IQTHwXeW1HvQgYAtAtuU+3qXudL9xejZ8r6tjYV7D0u3p17d5U 68r6s8MOKI46W2TJpAxy0/nBmzgvjHVcxN5grl3kxBCZQ6A7OtTf/o6naTMshS3z+8iy a7HIcfD6cTH87VxB1xcNQbZZS402SrskHBrY0C3T1a4hSO8rBd5Lb0/a5xjrg4WmMUca 2oeYL5qNq2yEo0u9Gx0nZknIzmTktPkWYkgwRVH3Wo+hU86cPnr4fmGQo3YJ94d2Lh6T ms0/ivI5ADIBljhoKLyXiVfJ77qNg//9Ivbe6tAPfiEeCnChhY0WHCYDZ0aQ5Wa6UNuX +zZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=UJeWa40HnNep2dU9sknm7tvZyoEh3b2bGd2IuYRImiY=; b=ZJBz44Wbx0She5PTwXM9L2x6qKkY7leZ2DI4vEpvwbvaYonJ0DuPdClGGQRJPq+fHU A61uSgDD2AoyQaun7Cc5fBY0JbGk0WgnJBU90edvh2bfV5TRneUG/bdHnTVVYhzy8zfS FYnMLfyT0iAWyQqxzuqPesrjdqGBVpT+KvapmQNw3JXjpKIF8xVbFg/7aB7TQJ9wmWPX Y6dMqMrN1+JSb31Wk17pIS8Iy0hSObgpb4tXPevKrKlkikcvlK0vFDjAsmq/hUEn1QXt X7Tz1TFRt+Zjk3yyns4u/PxosIevWW8gfNON+LZGTWAfRApQsTy3P9V57q7vIilQC8EI E0eA== X-Gm-Message-State: ALyK8tKCE2MGl5hw2aFVOLU4VWkp6+A0NE9e2EdRSEzDsWK0EM8BdBQeNETc4AddSMAtZAIdzoMQ0wxaZ4NyHej/ X-Received: by 10.237.35.152 with SMTP id j24mr4651796qtc.96.1465830613878; Mon, 13 Jun 2016 08:10:13 -0700 (PDT) MIME-Version: 1.0 Received: by 10.55.162.9 with HTTP; Mon, 13 Jun 2016 08:09:54 -0700 (PDT) In-Reply-To: <1494343.LIrEFGtHSn@xps13> References: <1494343.LIrEFGtHSn@xps13> From: Christian Ehrhardt Date: Mon, 13 Jun 2016 17:09:54 +0200 Message-ID: To: Thomas Monjalon Cc: dev Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] Duplicate config symbols X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jun 2016 15:10:14 -0000 On Mon, Jun 13, 2016 at 3:47 PM, Thomas Monjalon wrote: > 2016-06-13 13:50, Christian Ehrhardt: > > I wondered multiple times now when changing a config symbol that some of > > them are in the .config file multiple times. > > I totally feel like I'm overlooking something, but still it might be > worth > > to ask. > [...] > > Is there any reason to do so or is this an issue in make config? > > It is an issue in "make config" which has never been considered important. > I didn't want to make it more important :-) I'm fine with the second occurrence overwriting as it did a while now and knowing it is not a totally unknown issue. I had seen the old argument for not moving them out completely in the old thread - thanks for the link - that was important to understand why they are still there. Also found related patches from Keith about that now. > We could remove the first - overridden - occurences. > I think it can be fixed in mk/rte.sdkconfig.mk. > You mean just filtering them eventually while keeping them where they are so that the old request to have "the base config shows all config options" still fulfilled - yeah that could be an approach to make everybody happy. But then it would make for some evil unreadable sed or such, I could live with it as is knowing it is accepted as-is. I'll submit an RFC, but hope for someone with more dark magic to make it nicer. Kind Regards, Christian