From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <christian.ehrhardt@canonical.com>
Received: from mail-ig0-f172.google.com (mail-ig0-f172.google.com
 [209.85.213.172]) by dpdk.org (Postfix) with ESMTP id 86636567E
 for <dev@dpdk.org>; Thu,  3 Dec 2015 09:19:09 +0100 (CET)
Received: by igcmv3 with SMTP id mv3so7948565igc.0
 for <dev@dpdk.org>; Thu, 03 Dec 2015 00:19:09 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=canonical-com.20150623.gappssmtp.com; s=20150623;
 h=mime-version:in-reply-to:references:from:date:message-id:subject:to
 :cc:content-type;
 bh=qWB47nXk9KKXgJ+ea5VngxuH+dMOg5z9b5tBI5p6s0U=;
 b=L0YV4gFfGDxp+cu2+LGzPmFfLcfpGGR2TTF/YvPUE+7oGJvdtif8wZVGsno21i76f9
 9lWLkQ576MMSQJPwkaYu4BrfXEmFnerUOcHU3ZIpIChTUH8RVdAoTV5YPKojeBG6s7a9
 vSljNhCV6ouwkYtbitr8v6qW7+4+7t0Hh5Txfi919TCdDnRKyrHt1zwItFeZkWsfW7Q2
 f1ThRWxboSL8PNdSDva+9v93JQsq46v9oQIApD1hUhSzLmB5oT9diIrppgUt8ktrllQA
 pChndJW0TcxwH6I+rVC4TeudAHz2CfU50UBtLOHJHuwSgxrfuQpbMZKkcoTQdjmBzG3j
 4Bqg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to:cc:content-type;
 bh=qWB47nXk9KKXgJ+ea5VngxuH+dMOg5z9b5tBI5p6s0U=;
 b=mrSZ8qbfA4yJlZp05iTeCVwhzT2xoRTtBVpcqXFiOaPu/BaPZi0fYhnfhO++IuhIIE
 rVmc+VJZX3xrTl6UpMcaVA/xE7XBc18+v3plCEmN85eVSiv0FuAOdRjDDYN75g+oXhxG
 e+N+gHeU+zuk9haqoCSOAUqJw9sXxUKDXnKnE/oXeqkj1u7wO68xS70qsxmtVFnJ8D+A
 sj3/bDQ4rzOfBaMgtdbrNgStvHgVeLbCBympvbbmBnnEb2Pi/OOya5Bq6jYwIR/bR5N0
 OMVg0F9Lqh+3nDd9R1p9ZjQOPvBmDxtA0Dt/nWxQk8klz1XJGEP16C8HEbskIpxZQFhv
 HPvg==
X-Gm-Message-State: ALoCoQkzuZccKVDHMTaf8tC9IAYwQ0LpHGR4lcrnHPe5GAoPs9aCehQ2Lz06JryVnyQG81lz7rni
X-Received: by 10.50.79.138 with SMTP id j10mr8132371igx.6.1449130748909; Thu,
 03 Dec 2015 00:19:08 -0800 (PST)
MIME-Version: 1.0
Received: by 10.107.20.131 with HTTP; Thu, 3 Dec 2015 00:18:49 -0800 (PST)
In-Reply-To: <1449105754-17136-1-git-send-email-ferruh.yigit@intel.com>
References: <1449105754-17136-1-git-send-email-ferruh.yigit@intel.com>
From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Date: Thu, 3 Dec 2015 09:18:49 +0100
Message-ID: <CAATJJ0KytMmeL86cRQ+N8UeAbfJ9wc7MLLNYGsTk+jDQoaz=3Q@mail.gmail.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Content-Type: text/plain; charset=UTF-8
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] mk: fix compile error and ABI versioning
 for combined shared library
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Dec 2015 08:19:09 -0000

Hi Ferruh,
some minor bash improvements that could be made in the next revision:

On Thu, Dec 3, 2015 at 2:22 AM, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> diff --git a/scripts/merge_maps.sh b/scripts/merge_maps.sh
> new file mode 100755
> index 0000000..bc40dc8
> --- /dev/null
> +++ b/scripts/merge_maps.sh
> @@ -0,0 +1,29 @@
> +#!/bin/sh
> +
> +FILES=$(find $RTE_SDK -name "*.map" | grep -v build)
> +SYMBOLS=$(grep -h "{" $FILES | sort -u | sed 's/{//')

Guarding $RTE_SDK and $FILES with "" will help avoid some potential
issues due to words splitting.

[...]
> +               sed -n "/$s {/,/}/p" $f | sed '/^$/d' | grep -v global | grep -v local | sed '1d' | sed '$d'

As above with $f

[...]
> +       if [ "$prev_sym" == "none" ]; then

Should be only one = as == is non standard and could fail in some environments.


Christian Ehrhardt
Software Engineer, Ubuntu Server
Canonical Ltd