From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E9298A00C4; Thu, 4 Jun 2020 16:44:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9669D1D5D8; Thu, 4 Jun 2020 16:44:18 +0200 (CEST) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by dpdk.org (Postfix) with ESMTP id BCAC81D580 for ; Thu, 4 Jun 2020 16:44:17 +0200 (CEST) Received: from mail-ua1-f72.google.com ([209.85.222.72]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jgr6P-0008MO-DD for dev@dpdk.org; Thu, 04 Jun 2020 14:44:17 +0000 Received: by mail-ua1-f72.google.com with SMTP id p11so2123335uaq.0 for ; Thu, 04 Jun 2020 07:44:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=D3wXbesq4PKzEfTwVJ7dXgxjY8nWcqP5zh2Lj53WRaI=; b=VYCEonRgEdGZSNL9Kn+7ThvtEsQtKv0XTS9nyPPdRuiXlRjbDgRTDE3rzCsGJhnIUR iELfUUShIi/KFpBoLo6k+Z2P03tkvnkDkcjmqw+uBeg24azT0wr5Ppxd4Xzhme1cnSoe vnwmjbjm6ri93GY3BNKSlbrokPJe5KStFt/8K+oaTdDR+OXbGFe57ZYLDX3lwOxigOTx 5ZkO3dioDJVwvMPVRMUGNp0k2zQQSvnGTiH4gkeXjgvW6EEGENVBhyoJeCbDeYF5O0sG TmowxosOO6OcSgLeiueIEGjqjNUb0rpr8vsK8+1VrIphf/Un2rD7DJ65XhJhea2mPh19 2fvQ== X-Gm-Message-State: AOAM530fOr3iipluiilUoaOryjIYzGl1F28XN1CgA1TvGzqd8e55t5v3 ke5H7od5b+nv0KuSZoH9BAT+i73Jr3F8RJqVIIqTMxJAF5uchZ28SA3qt5lBb3VBdF7yoavWt5L 7yirsEqnkuNWVBmhJaLjpgmUDPJ3y588dRyNP X-Received: by 2002:a67:67c5:: with SMTP id b188mr3678266vsc.155.1591281856560; Thu, 04 Jun 2020 07:44:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJytPgj7uCCVjES8DVMctSxATbWP0FqyfpnxWFi8Ev6yrUcB8dLPJByPubnF3wi396PIqzAr4lKUFoUE/0rTduc= X-Received: by 2002:a67:67c5:: with SMTP id b188mr3678244vsc.155.1591281856285; Thu, 04 Jun 2020 07:44:16 -0700 (PDT) MIME-Version: 1.0 References: <20200507072629.2374881-1-christian.ehrhardt@canonical.com> <20200507112518.GA1457@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20200507112518.GA1457@bricha3-MOBL.ger.corp.intel.com> From: Christian Ehrhardt Date: Thu, 4 Jun 2020 16:43:50 +0200 Message-ID: To: Bruce Richardson Cc: Luca Boccassi , dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] autotest: fix for pure python3 environments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, May 7, 2020 at 1:25 PM Bruce Richardson wrote: > On Thu, May 07, 2020 at 10:36:35AM +0100, Luca Boccassi wrote: > > On Thu, 2020-05-07 at 09:26 +0200, Christian Ehrhardt wrote: > > > Without this fix in a pure python3 environment this will run into > > > issues like: > > > ModuleNotFoundError: No module named 'StringIO' > > > or later string encoding issues on check_output. > > > > > > Signed-off-by: Christian Ehrhardt > > > --- > > > app/test/autotest_runner.py | 16 +++++++--------- > > > 1 file changed, 7 insertions(+), 9 deletions(-) > > > > Acked-by: Luca Boccassi > > > > Note that this makes the file python3-only (as far as I can see) - I > > think it's fine at this point, given python2 is EOL? > > > I think for 20.11 we should aim to have all python in DPDK python3 only. > IMHO Robin's feeback wasn't forcing a mandatory v2 (I wa not planning on one). Nothing else happened on this, since we failed to hit 20.05 I wanted to ping again on this. > /Bruce > -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd