From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by dpdk.org (Postfix) with ESMTP id 9C3E914E8 for ; Tue, 31 Jul 2018 15:33:22 +0200 (CEST) Received: from mail-oi0-f72.google.com ([209.85.218.72]) by youngberry.canonical.com with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1fkUmA-0001KD-Co for dev@dpdk.org; Tue, 31 Jul 2018 13:33:22 +0000 Received: by mail-oi0-f72.google.com with SMTP id 20-v6so13765508ois.21 for ; Tue, 31 Jul 2018 06:33:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=U/e2x2DRXLj1kD28CB0Srkt5vecoWav7HtiLc5NTaHQ=; b=W6yadROfW39K/HvkBOgaKczQYa9MlDov7zUKrBgOw/rS42DYwNWBhpW2mnyoKhtjrc d7JON2dSu24CIuuNJFrnMvCoGBqV4gr6DXWvE8cqYmMfHqKi32PWqK8lXHpqKm3Vi3jM S52C9PA/+Y1iLuzHyODb+BKhwGAy1kEc/qgrr+R+leJhP9cR7G4E6hx7DTWvV9MGJe/6 AXPEu0xoK/lBi4QiWmnN7HxQBwjPCOJJTrtSa79iIXoJ2nkAfjFFBbiLrHYeJIzEsLhQ j7+UTTMmhOwamLQNihcfvAB4Cdo2zUtYfXFcfu13Cg6Zmh/ZXmrcr8U1o7hquPfH3p78 K4Tg== X-Gm-Message-State: AOUpUlEPrgZOo5eaTo3TzPUsHccagA12lhtzib473Jml2ipa7AMviPIH f4QneA917+S4FU6patUjqT+GhxAszB0efWw3XrvwXA7TlAjXgAG0wVKQeAHp9g/wEkNRhYYZVWh csnB03eED01YwBPjWCRTi3bp4ZeDZMFaYhULz X-Received: by 2002:aca:438a:: with SMTP id q132-v6mr20700908oia.331.1533044001389; Tue, 31 Jul 2018 06:33:21 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdzADfrAzdPhDBDyxnSYtVfMeoylnqCfBkMG3GYeY4uwU3r5DQ0va1VjGgABsKKWEc9dSuGN1cmz8J/DtKal94= X-Received: by 2002:aca:438a:: with SMTP id q132-v6mr20700893oia.331.1533044001080; Tue, 31 Jul 2018 06:33:21 -0700 (PDT) MIME-Version: 1.0 References: <99e701e9982397b2d3febb2f36309225481158e9.1533042801.git.tredaelli@redhat.com> In-Reply-To: <99e701e9982397b2d3febb2f36309225481158e9.1533042801.git.tredaelli@redhat.com> From: Christian Ehrhardt Date: Tue, 31 Jul 2018 15:32:55 +0200 Message-ID: To: "Timothy M. Redaelli" Cc: matan@mellanox.com, Shahaf Shuler , dev , adrien.mazarguil@6wind.com Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/mlx4: Avoid stripping the glue library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Jul 2018 13:33:22 -0000 On Tue, Jul 31, 2018 at 3:26 PM Timothy Redaelli wrote: > Stripping binaries at build time is usually a bad thing since it makes > impossible to generate (split) debug symbols and this can lead to a more > difficult debugging. > > CC: Adrien Mazarguil > Fixes: 27cea11686ff ("net/mlx4: spawn rdma-core dependency plug-in") > > Signed-off-by: Timothy Redaelli > --- > drivers/net/mlx4/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/mlx4/Makefile b/drivers/net/mlx4/Makefile > index 63bc00337..92e932250 100644 > --- a/drivers/net/mlx4/Makefile > +++ b/drivers/net/mlx4/Makefile > @@ -115,7 +115,7 @@ endif > $(LIB_GLUE): mlx4_glue.o > $Q $(LD) $(GLUE_LDFLAGS) $(EXTRA_LDFLAGS) \ > -Wl,-h,$(LIB_GLUE) \ > - -s -shared -o $@ $< -libverbs -lmlx4 > + -shared -o $@ $< -libverbs -lmlx4 > > mlx4_glue.o: mlx4_autoconf.h > > After IRC discussion I completely agree that this shouldn't be stripped, thanks for the fix. Acked-by: Christian Ehrhardt -- 2.17.1 > > -- Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd