From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7E3DAA0613 for ; Wed, 28 Aug 2019 14:30:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CC5A9271; Wed, 28 Aug 2019 14:30:57 +0200 (CEST) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by dpdk.org (Postfix) with ESMTP id 78347237 for ; Wed, 28 Aug 2019 14:30:56 +0200 (CEST) Received: from mail-vs1-f69.google.com ([209.85.217.69]) by youngberry.canonical.com with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1i2x6G-0001EF-5w for dev@dpdk.org; Wed, 28 Aug 2019 12:30:56 +0000 Received: by mail-vs1-f69.google.com with SMTP id u16so433261vsu.12 for ; Wed, 28 Aug 2019 05:30:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=g5zMPFWZgV9AL+KqEldpUlu7YhodW5T7vZUN2qCX90s=; b=tPG4XIAf9ILRauVFqaIkyBQMQoBMIDO2uu2gRRcethTC7d9Sdfizm2eunZoJ51CWbP uIjYpjWjrcsS9twdyzODnmfh9WWzBW5L+Ubi/eCdUwJT0PvLG2EqxM8x5YqIs5rwyxNy ek8Vw2onZ3MtwaRpgsg016Vz1zyvUg1lkXoRZzFV2Os6Gqk4hQvO/x3qURzSrhAorvF0 sstcyN7V3kgaJlERSSENmMajrFDOdG8s7d/Xg0r/w1SQVtLYmlvBs/z/IS/8VQg7C27r 38VdG3cB+/prB+xC+feU/u1edmHHGgFs1Gq9PAhUHHlyimcjMbJpnLWn+DV/7G+/E56D dvUw== X-Gm-Message-State: APjAAAXnHlV27C9pOmfoIny0lzojuZZMEx4zsA63rBc/MyOvUptFiQVS cKwNiXenHkuTxG/BCMtvyMF6UiH3LgWgMSbS1JCQ75/vAYcFa6CFTDgyiu7/VhLDCDIx2h/KFyd HV4EA4883maC/F9Rg697Bq8mKE9GF5ZLjLDUG X-Received: by 2002:a67:ec10:: with SMTP id d16mr2190222vso.220.1566995455315; Wed, 28 Aug 2019 05:30:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqy8wN2tOlvPsK5C2iOaJqo2nJzA1HcyHtG9BnBNJ8wIVpgIxuYLr0D3x+crPmjdvSqZLClAvBMTLBtRNRuYGwc= X-Received: by 2002:a67:ec10:: with SMTP id d16mr2190210vso.220.1566995455065; Wed, 28 Aug 2019 05:30:55 -0700 (PDT) MIME-Version: 1.0 References: <20190813112843.27072-1-christian.ehrhardt@canonical.com> <20190813112843.27072-2-christian.ehrhardt@canonical.com> <5561160f-beff-c615-9c15-cf00954149ac@linux.vnet.ibm.com> In-Reply-To: <5561160f-beff-c615-9c15-cf00954149ac@linux.vnet.ibm.com> From: Christian Ehrhardt Date: Wed, 28 Aug 2019 14:30:29 +0200 Message-ID: To: David Christensen Cc: dev , Luca Boccassi , Thomas Monjalon , Frank Heimes Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 1/1] net/mlx4: fix build on PPC64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Aug 14, 2019 at 1:49 AM David Christensen wrote: > > On 8/13/19 4:28 AM, Christian Ehrhardt wrote: > > The AltiVec header file breaks boolean type: > > > > error: incompatible types when initializing type > > '__vector _bool int' {aka '_vector(4) __bool int'} using type 'int' > > > > If __APPLE_ALTIVEC__ is defined, then bool type is redefined > > and conflicts with stdbool.h. > > > > There is no good solution to fix it for the whole project without > > breaking something else, so a workaround is inserted in mlx5 PMD. > > This workaround is not compatible with C++ but there is no C++ in DPDK. > > > > Related to: > > https://git.dpdk.org/dpdk/commit/?id=725f5dd0bfb50192a2d2341d4cc69084c2c4e03d > > > > Change-Id: Iceb058c07086def4176c5ab199ca4dd5018d0340 > > Signed-off-by: Christian Ehrhardt > > Tested-by: David Christensen Thanks David, ping for considering inclusion into 19.11 ? -- Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd