From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb0-f175.google.com (mail-yb0-f175.google.com [209.85.213.175]) by dpdk.org (Postfix) with ESMTP id 04D56689B for ; Thu, 12 Jan 2017 14:43:55 +0100 (CET) Received: by mail-yb0-f175.google.com with SMTP id w194so1927660ybe.0 for ; Thu, 12 Jan 2017 05:43:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=CYJ1yGxNMNl+MnTB7EwNcR81H5nqnrm4knfDFLutczc=; b=bIJ9BzKdwPran4+Ay5W38uZ3olWeTIHgIiXXZ/r3SGU5DwGA93vMtzDbWwsIA7SJ6f BWK5d+6HHpIU0QkBgg4sCSQoN8ILCAipHXv8Fcf8iJs2A9PbR2PBFdgCNzx2xYkZvr8T S6qYRFt6HdLWF+oUEL37AqnmI9A3fcsa2RJZeKE2OU3xf84gR0X4m0mok2/xV11ke6iW G2aRXm4JPAQTk3x/+dcZI15MSblVZdlmcERzEVqkWfTB4YLFMoFrD0zBgUrb1B5bkpK4 RWt01/QZ4KzLV43dDpAlCjeterQOWM3chYSJBzmacfQG/aoicHh8R9Fbz//PdLl6HC0+ OR7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=CYJ1yGxNMNl+MnTB7EwNcR81H5nqnrm4knfDFLutczc=; b=b+5H0gwFhjoo6MTN95e17N81QmS8Hlq0dtS70q92XhKjBtrN3CHP3+a7qxCke+wys1 4S/fsjkCHO8ZC3SNS9veEUGRWjgrxJpjOq/za48D0me5bhky8v6s21vFAE1HAun2g4KN x3FS1ioTXZh2HUXhcSLTLM/8/eyvjQmQ6HNUHHwwyohVvA0xp7XFk0UJjOkD4XLBXj8h YF1bMFPuP46afyfGrx33Lnjz/OrWQ76ybhNoVtjsEwRdaL73qoOj/yJnkTi6jbJeJ6xl 6O50AyxmoezvvZJWSLalt4/9Gv/4SGN3dXOv5yIzpX75opT4WXofJ7RcRVGSTEovaYzu DeXg== X-Gm-Message-State: AIkVDXKvm1XkCG+briQnKAzmeYTgKnH+PYQ9sQHjH5hxqvlh4kCheOAgLEBNyIogTb15Nm4dZQaDqGv+4qK60c3j X-Received: by 10.37.170.225 with SMTP id t88mr731713ybi.74.1484228635029; Thu, 12 Jan 2017 05:43:55 -0800 (PST) MIME-Version: 1.0 Received: by 10.13.227.196 with HTTP; Thu, 12 Jan 2017 05:43:24 -0800 (PST) In-Reply-To: <3810875.kgVK3RKdmy@xps13> References: <1481570642-15138-1-git-send-email-lboccass@brocade.com> <1481647672-9187-1-git-send-email-lboccass@brocade.com> <3810875.kgVK3RKdmy@xps13> From: Christian Ehrhardt Date: Thu, 12 Jan 2017 15:43:24 +0200 Message-ID: To: Thomas Monjalon Cc: Luca Boccassi , dev , Stefan Bader , Bruce Richardson Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2] SDK: Add scripts to initialize DPDK runtime X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jan 2017 13:43:56 -0000 On Mon, Dec 19, 2016 at 4:15 PM, Thomas Monjalon wrote: > Thanks for sending your Debian/Ubuntu work. > > 2016-12-13 16:47, Luca Boccassi: > > From: Christian Ehrhardt > > > > A tools/init directory is added with dpdk-init, a script that can be > > used to initialize a DPDK runtime environment. 2 config files with > > default options, dpdk.conf and interfaces, are provided as well > > together with a SysV init script and a systemd service unit. > > I have 2 concerns: > > - What does exactly mean "initialize a DPDK runtime environment"? > Should it be documented somewhere? > Sorry for the late reply, Luca made me aware that this was lost in the Christmas hole. It means that you make a system config ready to be used in a persistent way e.g. cross reboots. The common steps to prep a system in that regard are assigning a set of cards to dpdk (=>dpdk-devbind) and furthermore to set up hugepages as needed. The latter is only a simple helper for the convenience of the admin. It can suit 95% of the cases but if someone has something very specific in mind a manual hugepage setup might be needed. The conf files themself have comment on their usage. I'm not sure how much more (on top of the comments in the config files) a doc might be useful. But then that might just be because I happen to know about that stuff. We could hapilly copy the bit we have about it at https://help.ubuntu.com/16.04/serverguide/DPDK.html#dpdk-config-dev https://help.ubuntu.com/16.04/serverguide/DPDK.html#dpdk-config-hp Luca/Thomas - what do you think about that? > - Is it deprecating dpdk-setup.sh? > dpdk-setup is a one-shot effort and provides very different things. the init script is for the system lifecycle, to be controlled by config files and invoked automatically. ATM - we covered what is needed on a regular base in the script, while dpdk-setup has a longer list of use-cases. If anybody identifies functions of dpdk-setup which would be reasonable in a lifecycle management we should be open to take patches moving those from the one-shot to the system service. Also one could think of sharing some code between them - like providing sourcable shell fragment that both scripts use to execute - yet I don't think it is needed until I see a reasonable call that this is needed or helpful. Once (I don't expect that) all functionality would have moved it would be deprecated, but not for now in my Opinion. -- Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd