From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f177.google.com (mail-io0-f177.google.com [209.85.223.177]) by dpdk.org (Postfix) with ESMTP id 31E446A95 for ; Mon, 18 Jan 2016 15:56:15 +0100 (CET) Received: by mail-io0-f177.google.com with SMTP id 77so520009323ioc.2 for ; Mon, 18 Jan 2016 06:56:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=2coTUInL70AWDz81XX5i99J/V7q+glgyJpZdCudfXSM=; b=Q/vEnBOUm+fCKN/HxOZGHOPTgdSmNDzCxLqxgGcd3qVmXAQF8QEjKAm4FV3BvduJjK YKapL3NcitesViNU3I7Vvy3/Ztad7zhw7rX2W69gEgbWI7dNZr3pLrFh/ujTo5Wl79EW ujokhJfZ/GRMIH8phhT8cyB1V3U0zVH6nc4BcI5p2f+gsPnu15K1MQv0Oz+iad7x4SX1 SX06iUoBU/0lcP5lizXb3Qexu0IQnMwi6mQQN97JGsj0CwCj58ACVF0l1+UOKgH+fyXF Tk1pItLes0e8D2OP3L1Zb7gnbHq6b7Bw7gtJuVw5lK2EYXGHc7k9I9z7WZZcWfW2AblR pk/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=2coTUInL70AWDz81XX5i99J/V7q+glgyJpZdCudfXSM=; b=lOSevqQrC17LUXl1UysSbsNxh4ymNcMbqbYvwBKodqqzlcPkz/kHh3sXiHBn5Kcoy8 Mqeu58Ndf5nH4PGiC3pJednXwjEVkwX3d1Fb3IKRW04sR2hGjtvI2744jBu/rKR4CJq+ rhPCK8Wgc0zugQhz4GXQvNXdqggbMI1aC6DVN4uSU4WxpKvCwGfhWLwlr14qWXd+3P6g DIOF9m9IhaswaoCBaJozG/rGKvCXbuvJ+FgdbeDeYLdpWtnKSVLZx4DDeLJa8iLDBCU+ t0fRsNdvMq5S6UzSzq/Vuj2HxiOwhd5ewiz9CMjR3SqGjHoapOn5x9tS2AbOqr4zLXyf E9ag== X-Gm-Message-State: ALoCoQl+K5Fp9o0DZai78x8840Eys3cnDMRkTxZOsOHqdTqZ70vOrNh4N8IzFxLBNAzJgTuLHbUkOwiYfKd3Lj9VRObwpKpi0DZudhTPH7bG2ws1yjq2kwU= X-Received: by 10.107.128.201 with SMTP id k70mr21350205ioi.3.1453128973421; Mon, 18 Jan 2016 06:56:13 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.158.12 with HTTP; Mon, 18 Jan 2016 06:55:53 -0800 (PST) In-Reply-To: References: <1452250981-5286-1-git-send-email-christian.ehrhardt@canonical.com> From: Christian Ehrhardt Date: Mon, 18 Jan 2016 15:55:53 +0100 Message-ID: To: dev@dpdk.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] mk: Fix examples install X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jan 2016 14:56:15 -0000 Hi, Since there was neither positive nor negative feedback so far I wanted to ask if this patch is ok? Especially since we had a discussion on the approach I chose in the first approach to this issue I'd be happy about a ack/nak. Kind Regards, Christian Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Fri, Jan 8, 2016 at 12:08 PM, Christian Ehrhardt < christian.ehrhardt@canonical.com> wrote: > Forgot to mention, an easy way to test-trigger this e.g. on the dpdk 2.2 > tarball. > > make clean; make config T=3Dx86_64-native-linuxapp-gcc && && make -j && m= ake > V=3D1 DESTDIR=3DTest install-doc > > In this example the install-doc fails with this: > [...] > Build complete [x86_64-native-linuxapp-gcc] > make -f /home/ubuntu/dpdk-2.2.0/mk/rte.sdkinstall.mk install-doc > cp -a /home/ubuntu/dpdk-2.2.0/examples Test/usr/local/share/dpdk > cp: cannot create directory =E2=80=98Test/usr/local/share/dpdk=E2=80=99: = No such file or > directory > /home/ubuntu/dpdk-2.2.0/mk/rte.sdkinstall.mk:160: recipe for target > 'install-doc' failed > make[1]: *** [install-doc] Error 1 > /home/ubuntu/dpdk-2.2.0/mk/rte.sdkroot.mk:101: recipe for target > 'install-doc' failed > make: *** [install-doc] Error 2 > > Christian Ehrhardt > Software Engineer, Ubuntu Server > Canonical Ltd > > On Fri, Jan 8, 2016 at 12:03 PM, Christian Ehrhardt < > christian.ehrhardt@canonical.com> wrote: > >> Depending on non-doc targets being built before and the setting of DESTD= IR >> the copy of the examples dir being part of install-doc could in some >> cases fail >> with a non existant "$(DESTDIR)$(datadir)" target directory. >> Add the conditional rte_mkdir for that to avoid the issue. >> >> Signed-off-by: Christian Ehrhardt >> --- >> >> [diffstat] >> rte.sdkinstall.mk | 1 + >> 1 file changed, 1 insertion(+) >> >> [diff] >> diff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk >> index c159bf7..68e56b6 100644 >> --- a/mk/rte.sdkinstall.mk >> +++ b/mk/rte.sdkinstall.mk >> @@ -157,4 +157,5 @@ ifneq ($(wildcard $O/doc/*/*/*pdf),) >> $(Q)$(call rte_mkdir, $(DESTDIR)$(docdir)/guides) >> $(Q)cp -a $O/doc/*/*/*pdf $(DESTDIR)$(docdir)/guides >> endif >> + $(Q)$(call rte_mkdir, $(DESTDIR)$(datadir)) >> $(Q)cp -a $(RTE_SDK)/examples $(DESTDIR)$(datadir) >> > >